coop-cloud/matrix-synapse
4
0
Fork 1
Code Issues 4 Pull Requests Releases Wiki Activity

Expose max_upload_size as a configurable option #51

Merged
cas merged 2 commits from cas_expose_maxupload into main 2025-10-17 17:05:31 +00:00
Conversation 3 Commits 2 Files Changed 5 +10 -6
cas commented 2025-10-02 18:43:01 +00:00
Owner
Copy Link
No description provided.
cas added 1 commit 2025-10-02 18:43:01 +00:00
Expose max_upload_size as a configurable option e3df032bda
decentral1se reviewed 2025-10-03 16:18:44 +00:00
decentral1se left a comment
Owner
Copy Link

💟

💟
.env.sample
@ -86,6 +86,8 @@ RETENTION_MAX_LIFETIME=4w
#MEDIA_RETENTION_LOCAL_LIFETIME=30d
#MEDIA_RETENTION_REMOTE_LIFETIME=14d
MAX_UPLOAD_SIZE=50M
decentral1se commented 2025-10-03 16:18:28 +00:00
Owner
Copy Link

Is this a change in behaviour with this default? Might be nice to mention it in the release notes.

Is this a change in behaviour with this default? Might be nice to mention it in the release notes.
cas commented 2025-10-03 18:18:56 +00:00
Author
Owner
Copy Link

I believe I have preserved the default (eg, MAX_UPLOAD_SIZE is empty) by using the { or } construction in the templates (they were explicitly set to 50M before). That is an extra protection for people upgrading, and then we set the value explicitly for new installations.

I believe I have preserved the default (eg, MAX_UPLOAD_SIZE is empty) by using the { or } construction in the templates (they were explicitly set to 50M before). That is an extra protection for people upgrading, and then we set the value explicitly for new installations.
👍 1
decentral1se marked this conversation as resolved
homeserver.yaml.tmpl
@ -131,3 +131,3 @@
# https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html#max_upload_size
max_upload_size: 50M
max_upload_size: {{ or (env "MAX_UPLOAD_SIZE") 50M }}
decentral1se commented 2025-10-03 16:18:11 +00:00
Owner
Copy Link

Bump the config in abra.sh as well?

Bump the config in `abra.sh` as well?
cas commented 2025-10-03 18:19:51 +00:00
Author
Owner
Copy Link

Ah you are correct that it needs to be updated.

Ah you are correct that it needs to be updated.
cas commented 2025-10-03 18:21:04 +00:00
Author
Owner
Copy Link

I have pushed a commit to update config versions.

I have pushed a commit to update config versions.
decentral1se marked this conversation as resolved
cas added 1 commit 2025-10-03 18:20:52 +00:00
Bump config versions 7703bbbce7
decentral1se approved these changes 2025-10-03 18:37:02 +00:00
cas commented 2025-10-03 20:11:25 +00:00
Author
Owner
Copy Link

I will merge when i get a chance to test on an existing matrix server, unless someone wants to beat me to it.

I will merge when i get a chance to test on an existing matrix server, unless someone wants to beat me to it.
🎉 1
cas merged commit 730dbc4569 into main 2025-10-17 17:05:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se fauno flancian Frando iexos javielico jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband marlon mayel mirsal moritz nicksellen notplants p4u1 pau renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/matrix-synapse#51
No description provided.
Delete Branch "cas_expose_maxupload"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?