coop-cloud/mediawiki
coop-cloud
/
mediawiki
6
0
Fork 3
Code Issues 6 Pull Requests Releases Wiki Activity

Make language configurable #35

Merged
iexos merged 3 commits from iexos/mediawiki:add-lang-conf into main 2023-06-29 16:30:42 +00:00
Conversation 5 Commits 3 Files Changed 4 +7 -2
iexos commented 2023-06-28 16:23:28 +00:00
Member
Copy Link

Title says it all

Title says it all
iexos added 1 commit 2023-06-28 16:23:32 +00:00
continuous-integration/drone/pr Build is failing Details
5159ed1b36 enable choice of language
decentral1se reviewed 2023-06-29 11:48:19 +00:00
decentral1se left a comment
Owner
Copy Link

LGTM!

The only thing is, and this is still a bit "up in the air" as to how to handle (I think), is that if another operator deploys and doesn't copy over MEDIAWIKI_LANGUAGE then they'll potentially have a broken config cus they're missing the "en" default.

Two ways I've seen people mitigate that is 1) add a note to the release notes 2) add a default to the env loading.

LGTM! The only thing is, and this is still a bit "up in the air" as to how to handle (I think), is that if another operator deploys and doesn't copy over `MEDIAWIKI_LANGUAGE` then they'll potentially have a broken config cus they're missing the "en" default. Two ways I've seen people mitigate that is 1) add a note to the release notes 2) add a default to the `env` loading.
decentral1se reviewed 2023-06-29 11:48:54 +00:00
decentral1se left a comment
Owner
Copy Link

Oh wait a sec, does it also need to be threaded in via the compose.yml file env?

Oh wait a sec, does it also need to be threaded in via the `compose.yml` file env?
iexos commented 2023-06-29 12:04:32 +00:00
Author
Member
Copy Link

Oh wait a sec, does it also need to be threaded in via the compose.yml file env?

Hm, its working for me as is. Its only needed for the template, so maybe no?

The only thing is, and this is still a bit "up in the air" as to how to handle (I think), is that if another operator deploys and doesn't copy over MEDIAWIKI_LANGUAGE then they'll potentially have a broken config cus they're missing the "en" default.

True, didn't think of that! Will add a note.

> Oh wait a sec, does it also need to be threaded in via the `compose.yml` file env? Hm, its working for me as is. Its only needed for the template, so maybe no? > The only thing is, and this is still a bit "up in the air" as to how to handle (I think), is that if another operator deploys and doesn't copy over MEDIAWIKI_LANGUAGE then they'll potentially have a broken config cus they're missing the "en" default. True, didn't think of that! Will add a note.
decentral1se commented 2023-06-29 12:13:47 +00:00
Owner
Copy Link

Oh wait a sec, does it also need to be threaded in via the compose.yml file env?

Hm, its working for me as is. Its only needed for the template, so maybe no?

If you run env | grep -i language inside the container, do you see anything? If not, I'd say it's worth adding to the env stanza in the compose.yml. The config might already be written since you deployed before this change.

> > Oh wait a sec, does it also need to be threaded in via the `compose.yml` file env? > > Hm, its working for me as is. Its only needed for the template, so maybe no? > If you run `env | grep -i language` inside the container, do you see anything? If not, I'd say it's worth adding to the `env` stanza in the `compose.yml`. The config might already be written since you deployed before this change.
iexos commented 2023-06-29 13:37:28 +00:00
Author
Member
Copy Link

If you run env | grep -i language inside the container, do you see anything? If not, I'd say it's worth adding to the env stanza in the compose.yml. The config might already be written since you deployed before this change.

Yes, it is set inside the running container. And I can use it to change the language on a deploy --chaos.

Actually, there is all kinds of vars set in app that are not set in db, like LETS_ENCRYPT_ENV, ENTRYPOINT_CONF_VERSION, ... Same behaviour for my outline deployment. Is this a bug?

Anyway, will just add it.

> If you run `env | grep -i language` inside the container, do you see anything? If not, I'd say it's worth adding to the `env` stanza in the `compose.yml`. The config might already be written since you deployed before this change. Yes, it is set inside the running container. And I can use it to change the language on a `deploy --chaos`. Actually, there is all kinds of vars set in `app` that are not set in `db`, like `LETS_ENCRYPT_ENV`, `ENTRYPOINT_CONF_VERSION`, ... Same behaviour for my outline deployment. Is this a bug? Anyway, will just add it.
iexos added 1 commit 2023-06-29 13:47:16 +00:00
continuous-integration/drone/pr Build is failing Details
7d1810cf93 add MEDIAWIKI_LANGUAGE to compose.yml with default
decentral1se commented 2023-06-29 14:40:08 +00:00
Owner
Copy Link

Actually, there is all kinds of vars set in app that are not set in db, like LETS_ENCRYPT_ENV, ENTRYPOINT_CONF_VERSION, ... Same behaviour for my outline deployment. Is this a bug?

These are injected in via abra AFAIR. This supports kadabra being able to restart deployments because the env vars are attached via abra. This was mentioned in https://docs.coopcloud.tech/abra/upgrade/#06x-beta-07x-beta

> Actually, there is all kinds of vars set in app that are not set in db, like LETS_ENCRYPT_ENV, ENTRYPOINT_CONF_VERSION, ... Same behaviour for my outline deployment. Is this a bug? These are injected in via `abra` AFAIR. This supports `kadabra` being able to restart deployments because the env vars are attached via `abra`. This was mentioned in https://docs.coopcloud.tech/abra/upgrade/#06x-beta-07x-beta
👍 1
decentral1se approved these changes 2023-06-29 14:41:39 +00:00
iexos added 1 commit 2023-06-29 16:29:47 +00:00
continuous-integration/drone/pr Build is failing Details
de60261fce point to list of language options
iexos merged commit 5096046a86 into main 2023-06-29 16:30:41 +00:00
iexos deleted branch add-lang-conf 2023-06-29 16:30:46 +00:00
3wordchant commented 2023-06-29 18:22:16 +00:00
Owner
Copy Link

Thanks so much for this change! ♥

Hm, its working for me as is. Its only needed for the template, so maybe no?

Yes, in my experience variables which only appear in configs don't need to be added in compose.yml. Probably no harm in them being there though.

The only thing is, and this is still a bit "up in the air" as to how to handle (I think), is that if another operator deploys and doesn't copy over MEDIAWIKI_LANGUAGE then they'll potentially have a broken config cus they're missing the "en" default.

Best solution to this I can think of is to use the golang or construction to provide a default, e.g. https://git.coopcloud.tech/coop-cloud/matrix-synapse/src/branch/main/homeserver.yaml.tmpl#L41

Thanks so much for this change! ♥ >Hm, its working for me as is. Its only needed for the template, so maybe no? Yes, in my experience variables which only appear in configs don't need to be added in `compose.yml`. Probably no harm in them being there though. > The only thing is, and this is still a bit "up in the air" as to how to handle (I think), is that if another operator deploys and doesn't copy over MEDIAWIKI_LANGUAGE then they'll potentially have a broken config cus they're missing the "en" default. Best solution to this I can think of is to use the golang `or` construction to provide a default, e.g. https://git.coopcloud.tech/coop-cloud/matrix-synapse/src/branch/main/homeserver.yaml.tmpl#L41
Sign in to join this conversation.
Reviewers
No reviewers
decentral1se
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/mediawiki#35
No description provided.
Delete Branch "iexos/mediawiki:add-lang-conf"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?