coop-cloud/monitoring-ng
2
0
Fork 2
Code Issues 7 Pull Requests 4 Packages Projects Releases Wiki Activity

feat: make alerts configurable #19

Open
p4u1 wants to merge 1 commits from configurable-alerts into main
pull from: configurable-alerts
merge into: coop-cloud:main
Conversation 3 Commits 1 Files Changed 7 +37 -37
p4u1 commented 2026-03-31 18:16:24 +00:00
Owner
Copy Link

Alert threshholds can now be configured via env variables

I also seperated the basic auth, so that it is possible to deploy only prometheus without promtail

Alert threshholds can now be configured via env variables I also seperated the basic auth, so that it is possible to deploy only prometheus without promtail
p4u1 added 1 commit 2026-03-31 18:16:25 +00:00
feat: make alerts configurable 0aba60241f
p4u1 commented 2026-04-02 19:38:12 +00:00
Author
Owner
Copy Link

@dannygroenewegen did you get around to test this yet? :)

@dannygroenewegen did you get around to test this yet? :)
ammaratef45 approved these changes 2026-04-03 02:10:09 +00:00
ammaratef45 left a comment
Owner
Copy Link

nice!

nice!
README.md
@ -168,1 +161,4 @@
It is possible to enable the following alerts, by uncommenting the corresponding env variable:
- node disk space: `ALERT_NODE_DISK_SPACE_LEFT`
- node memory usage: `ALERT_NODE_MEMORY_USAGE`
ammaratef45 commented 2026-04-03 02:09:04 +00:00
Owner
Copy Link

nit: should probably remove the options from here since they are explained in the env file, otherwise we would have to remember that these need to be updates in 2 places

nit: should probably remove the options from here since they are explained in the env file, otherwise we would have to remember that these need to be updates in 2 places
❤️ 1
p4u1 commented 2026-04-03 07:44:45 +00:00
Author
Owner
Copy Link

Ah yes, good point!

Ah yes, good point!
dannygroenewegen requested changes 2026-04-03 11:00:24 +00:00
.env.sample
@ -80,4 +81,2 @@
#GF_MATRIX_HOMESERVER_URL="<homeserver-url>"
# ALerts
#ALERT_BACKUP_FAILED_ENABLED=true
dannygroenewegen commented 2026-04-03 10:54:03 +00:00
Owner
Copy Link

I've seen mentions that these backup alerts don't work, but is that the case for everyone? Or could someone still be relying on this?

And if these envs are removed, then grafana-alerts.json.tmpl can also be removed?

I've seen mentions that these backup alerts don't work, but is that the case for everyone? Or could someone still be relying on this? And if these envs are removed, then grafana-alerts.json.tmpl can also be removed?
.env.sample
@ -87,1 +83,3 @@
#ALERT_NODE_MEMORY_USAGE_ENABLED=true
## ALerts
# Node disk space alert will trigger when free disk space left is below the given number in percent
dannygroenewegen commented 2026-04-03 11:00:04 +00:00
Owner
Copy Link

Good enough for now. But 10% of a 20GB disk or a 2TB disk is a bit different. Can imagine we want a bit more fine-grained control depending on disk size and usage.

Good enough for now. But 10% of a 20GB disk or a 2TB disk is a bit different. Can imagine we want a bit more fine-grained control depending on disk size and usage.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin configurable-alerts:configurable-alerts
git checkout configurable-alerts
Sign in to join this conversation.
Reviewers
No Reviewers
ammaratef45
dannygroenewegen
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel dannygroenewegen decentral1se devydave fauno flancian Frando iexos jade javielico jjsfunhouse jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie marlon mayel mirsal moosemower moritz nicksellen notplants p4u1 pau pharaohgraphy PhiNatalie renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val vaznasty virtualboys wolcen wykwit xynosis yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/monitoring-ng#19
No description provided.
Delete Branch "configurable-alerts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?