coop-cloud/monitoring-ng
2
0
Fork 3
Code Issues 5 Pull Requests 3 Packages Projects Releases Wiki Activity

feat: smart monitoring #25

Open
fauno wants to merge 5 commits from smartctl into main
pull from: smartctl
merge into: :main
Conversation 3 Commits 5 Files Changed 6
+104
fauno commented 2026-06-19 23:40:46 +00:00
Owner
Copy Link
Copy Source

it requires a helper script on the host because swarm doesn't support privileged mode

it requires a helper script on the host because swarm doesn't support privileged mode
fauno requested review from dannygroenewegen 2026-06-19 23:40:48 +00:00
ammaratef45 changed target branch from alloy to main 2026-09-02 22:57:41 +00:00
fauno added 3 commits 2026-09-11 09:49:32 +00:00
feat: smart monitoring 53e03e12a4
feat: systemd timer b240c5273b
fix: scrape once per hour 48888a1fe9
fauno force-pushed smartctl from 1581ae6430 to 48888a1fe9 2026-09-11 09:49:32 +00:00 Compare
fauno commented 2026-09-11 09:50:28 +00:00
Author
Owner
Copy Link
Copy Source

this is ready for review and it's been working in production!

this is ready for review and it's been working in production!
dannygroenewegen requested changes 2026-09-17 10:08:01 +00:00
Dismissed
dannygroenewegen left a comment
Owner
Copy Link
Copy Source

Don't have a physical host to test this with. But added some comments from reading the code.
And maybe add a short line to the next release notes.

Don't have a physical host to test this with. But added some comments from reading the code. And maybe add a short line to the next release notes.
collect-smartctl-json.sh
@@ -0,0 +1,69 @@
#! /bin/bash
# Adapted from https://github.com/prometheus-community/smartctl_exporter/blob/master/collect-smartctl-json.sh
script_dir=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
dannygroenewegen commented 2026-09-17 10:05:15 +00:00
Owner
Copy Link
Copy Source

script_dir is set, but never used?

`script_dir` is set, but never used?
fauno commented 2026-09-24 15:11:22 +00:00
Author
Owner
Copy Link
Copy Source

mmm i just made small tweaks to the script, do you think we need our own?

mmm i just made small tweaks to the script, do you think we need our own?
collect-smartctl-json.sh
@@ -0,0 +57,4 @@
data="$($SUDO smartctl ${smartctl_args} ${device})"
# Accommodate a smartmontools pre-7.3 bug
data=${data#" Pending defect count:"}
type="$(echo "${data}" | "${json_tool}" "${json_args}" '.device.type')"
dannygroenewegen commented 2026-09-17 10:06:38 +00:00
Owner
Copy Link
Copy Source

type, family and model are set with a json expression, but the variables are not used? Looks like only data is written to the json file?

`type`, `family` and `model` are set with a json expression, but the variables are not used? Looks like only `data` is written to the json file?
fauno commented 2026-09-24 15:11:37 +00:00
Author
Owner
Copy Link
Copy Source

idem

idem
fauno commented 2026-09-24 15:18:08 +00:00
Author
Owner
Copy Link
Copy Source

ok they were used but i removed the uses, i pushed the changes now!

ok they were used but i removed the uses, i pushed the changes now!
compose.smartctl.yml
@@ -0,0 +4,4 @@
smartctl:
image: "prometheuscommunity/smartctl-exporter:v0.14.0"
volumes:
- "/dev:/dev"
dannygroenewegen commented 2026-09-17 10:07:37 +00:00
Owner
Copy Link
Copy Source

If it's running with --smrtctl.fake-data, then I don't think it's needed to mount /dev ?

If it's running with `--smrtctl.fake-data`, then I don't think it's needed to mount `/dev` ?
fauno marked this conversation as resolved
fauno added 1 commit 2026-09-24 15:12:12 +00:00
fix: /dev is not needed 9211b98cc1
fauno added 1 commit 2026-09-24 15:17:46 +00:00
fix: remove unused vars 5a10a45ced
fauno requested review from dannygroenewegen 2026-09-24 22:03:20 +00:00
You are not authorized to merge this pull request.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin smartctl:smartctl
git checkout smartctl
Sign in to join this conversation.
Reviewers
No Reviewers
dannygroenewegen
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) BornDeleuze Brooke cas (Cassowary) coopcloud dannygroenewegen (Danny Groenewegen) decentral1se (d1) fauno (fauno) jjsfunhouse kawaiipunk (KawaiiPunk) knoflook moosemower moritz notplants oxaliq (sorrel) p4u1 renovate-bot (Comrade Renovate Bot) simon stevensting trav (Trav Fryer) yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/monitoring-ng#25