coop-cloud/monitoring-ng
3
0
Fork 4
Code Issues 5 Pull Requests 5 Packages Projects Releases Wiki Activity

fix: smartctl needs access to /dev closes #52 #59

Merged
fauno merged 3 commits from smartctl-dev into main 2026-11-05 18:33:32 +00:00
Conversation 1 Commits 3 Files Changed 1
+1 -1
fauno commented 2026-11-03 21:45:23 +00:00
Owner
Copy Link
Copy Source

according to smartctl_exporter docs:

The smartctl_exporter can be run using local JSON data. The device names are pulled from actual devices in the machine while the data is redirected to the debug directory.

so the container needs access to the host /dev to enumerate disks

according to [smartctl_exporter docs](https://github.com/prometheus-community/smartctl_exporter#run-smartctl_exporter-using-json-data): > The smartctl_exporter can be run using local JSON data. **The device names are pulled from actual devices in the machine** while the data is redirected to the debug directory. so the container needs access to the host `/dev` to enumerate disks
fauno added 1 commit 2026-11-03 21:45:24 +00:00
fix: smartctl needs access to /dev closes #52 6db3afa97c
CODEOWNERS rules requested review from monitoring-ng-maintainers 2026-11-03 21:45:24 +00:00
compose.smartctl.yml Outdated
@@ -8,3 +8,3 @@
- "/dev:/dev:ro"
command:
- "--smartctl.fake-data"
- "--smartctl.interval=1h"
ammaratef45 commented 2026-11-05 18:17:36 +00:00
Owner
Copy Link
Copy Source

can you also include why we did this change in the description? (for paper trailing)

can you also include why we did this change in the description? (for paper trailing)
fauno commented 2026-11-05 18:33:09 +00:00
Author
Owner
Copy Link
Copy Source

done @ammaratef45 it wasn't needed because afaict the json files are read on every scrape

done @ammaratef45 it wasn't needed because afaict the json files are read on every scrape
fauno added 2 commits 2026-11-05 18:30:21 +00:00
fix: read only access 40d31a535f
fix: remove unneeded flag 085992dab0
fauno force-pushed smartctl-dev from 6950951d20 to 085992dab0 2026-11-05 18:30:21 +00:00 Compare
CODEOWNERS rules requested review from monitoring-ng-maintainers 2026-11-05 18:30:22 +00:00
fauno merged commit 400e0d71d1 into main 2026-11-05 18:33:32 +00:00
fauno deleted branch smartctl-dev 2026-11-05 18:33:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
ammaratef45
coop-cloud/monitoring-ng-maintainers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) BornDeleuze (Born Deleuze) Brooke cas (Cassowary) coopcloud dannygroenewegen (Danny Groenewegen) decentral1se (d1) devydave fauno (fauno) hex (Josh Dukes) jjsfunhouse kawaiipunk (KawaiiPunk) knoflook moosemower moritz notplants oxaliq (sorrel) p4u1 (p4u1) renovate-bot (Comrade Renovate Bot) simon stevensting (stevensting) trav (Trav Fryer) yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/monitoring-ng#59