coop-cloud/navidrome
1
1
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

chore: release 0.2.0+0.58.0 #3

Merged
pharaohgraphy merged 1 commits from :0.2.0+0.58.0 into main 2025-11-06 09:55:28 +00:00
Conversation 5 Commits 1 Files Changed 5 +17 -4
pharaohgraphy commented 2025-10-31 04:05:28 +00:00
Owner
Copy Link

Overview

Make the music path configurable via env var & bump to latest release version image
This has been tested on my own Navidrome deployment ✅

Description

This was needed otherwise I had to hack/hard-code the recipe locally to make it a binding path instead of the built-in volume.

## Overview Make the music path configurable via env var & bump to latest release version image This has been tested on my own Navidrome deployment ✅ ## Description This was needed otherwise I had to hack/hard-code the recipe locally to make it a binding path instead of the built-in volume.
pharaohgraphy added 1 commit 2025-10-31 04:05:29 +00:00
chore: release 0.2.0+0.58.0 12d7280f8d 
Make the music path configurable via env var & bump to latest release version image
decentral1se reviewed 2025-11-04 23:34:00 +00:00
decentral1se left a comment
Owner
Copy Link

👏

👏
compose.yml Outdated
@ -9,3 +9,3 @@
volumes:
- navidrome_data:/data
- navidrome_music:/music:ro
- "${MUSIC_PATH_HOST}:/music:ro"
decentral1se commented 2025-11-04 23:33:55 +00:00
Owner
Copy Link

Should it not be: "navidrome_music:${MUSIC_PATH_HOST}:ro"?

This is pretty unconventional but I can see why you'd want to customise this.

Does it work? We ran into related issues lately: toolshed/abra#492

Should it not be: `"navidrome_music:${MUSIC_PATH_HOST}:ro"`? This is pretty unconventional but I can see why you'd want to customise this. Does it work? We ran into related issues lately: https://git.coopcloud.tech/toolshed/abra/issues/492
pharaohgraphy commented 2025-11-04 23:46:44 +00:00
Author
Owner
Copy Link

Other way around, your suggestion would do the following:

  • Always use a Docker volume navidrome_music
  • Allow the env var to control where that's mounted to on the container

My change allows you to set a path to your music folder on the host.
And yes it works 💯

Other way around, your suggestion would do the following: - Always use a Docker volume `navidrome_music` - Allow the env var to control where that's mounted to **on the container** My change allows you to set a path to your music folder on the host. And yes it works 💯
decentral1se commented 2025-11-04 23:59:46 +00:00
Owner
Copy Link

Huh, I thought docker swarm didn't support that kind of syntax. Another issue with this is that it breaks volume support for other maintainers (navidrome_music dissapears from one version to the next). You can create a separate compose.hostvol.yml and do your own stuff there without disrupting the main config for the others. See https://docs.coopcloud.tech/maintainers/handbook/#optional-compose-files and the other recipes as examples of how to approach this.

Huh, I thought docker swarm didn't support that kind of syntax. Another issue with this is that it breaks volume support for other maintainers (`navidrome_music` dissapears from one version to the next). You can create a separate `compose.hostvol.yml` and do your own stuff there without disrupting the main config for the others. See https://docs.coopcloud.tech/maintainers/handbook/#optional-compose-files and the other recipes as examples of how to approach this.
👀 1
pharaohgraphy commented 2025-11-05 00:03:26 +00:00
Author
Owner
Copy Link

Why wouldn't it work? Docker binding/volume syntax is all the same no?

Valid point re: backwards-compat. upon updating though, I didn't think of that, but I'm 50/50 on the optional compose file because it makes NO sense to me to create a new docker volume for the music folder and make it read-only.

That means you'd have to manually mount the volume on another service to upload/add content... which is cumbersome & probs not the ideal use-case?

The binding mount makes a lot more sense as a default option, just like Jellyfin 🤷 so you can use a shared drive or anything else you like on the host to make the media populated & available.

Am I missing something here? 🙃

Why wouldn't it work? Docker binding/volume syntax is all the same no? Valid point re: backwards-compat. upon updating though, I didn't think of that, but I'm 50/50 on the optional compose file because it makes NO sense to me to create a new docker volume for the music folder and make it read-only. That means you'd have to manually mount the volume on another service to upload/add content... which is cumbersome & probs not the ideal use-case? The binding mount makes a lot more sense as a default option, just like Jellyfin 🤷 so you can use a shared drive or anything else you like on the host to make the media populated & available. Am I missing something here? 🙃
decentral1se commented 2025-11-05 00:09:38 +00:00
Owner
Copy Link

Let's see what the other maintainers think, @cas @ammaratef45?

Let's see what the other maintainers think, @cas @ammaratef45?
👍 1
pharaohgraphy commented 2025-11-06 03:42:35 +00:00
Author
Owner
Copy Link

Thanks for your feedback all, I've fixed this with a backwards-compatible EXTRA_VOLUME env var and updated the README accordingly 🙏

Tested on my own navidrome stack ✅

Thanks for your feedback all, I've fixed this with a backwards-compatible `EXTRA_VOLUME` env var and updated the README accordingly 🙏 Tested on my own `navidrome` stack ✅
❤️ 1
decentral1se marked this conversation as resolved
ammaratef45 commented 2025-11-06 01:06:14 +00:00
Owner
Copy Link

Can we use something like EXTRA_VOLUME https://git.coopcloud.tech/coop-cloud/jellyfin/src/branch/main/compose.yml#L14? we will need to have a second compose file to override the volume mounted to /music path (not even sure if that works) but that's what I would recommend to stay backward compatible

Happy to break backward compatibility eventually as long as it gets planned ahead of time and with engaging community members who utilize this recipe but let's try to compromise for now, wdyt @pharaohgraphy ?

Can we use something like `EXTRA_VOLUME` https://git.coopcloud.tech/coop-cloud/jellyfin/src/branch/main/compose.yml#L14? we will need to have a second compose file to override the volume mounted to /music path (not even sure if that works) but that's what I would recommend to stay backward compatible Happy to break backward compatibility eventually as long as it gets planned ahead of time and with engaging community members who utilize this recipe but let's try to compromise for now, wdyt @pharaohgraphy ?
❤️ 2
pharaohgraphy commented 2025-11-06 03:07:02 +00:00
Author
Owner
Copy Link

Can we use something like EXTRA_VOLUME https://git.coopcloud.tech/coop-cloud/jellyfin/src/branch/main/compose.yml#L14? we will need to have a second compose file to override the volume mounted to /music path (not even sure if that works) but that's what I would recommend to stay backward compatible

I considered that first, it's an easy copy-pasta pattern, no brainer, but was against it because I 'assumed' you can only mount to /music for Navidrome to detect your library.

That was a bad first take though 😅, cause I just had a look at the docs and it looks like you can just add more & point to any path, so I'll go with this approach instead 🙏

> Can we use something like `EXTRA_VOLUME` https://git.coopcloud.tech/coop-cloud/jellyfin/src/branch/main/compose.yml#L14? we will need to have a second compose file to override the volume mounted to /music path (not even sure if that works) but that's what I would recommend to stay backward compatible I considered that first, it's an easy copy-pasta pattern, no brainer, but was against it because I 'assumed' you can only mount to `/music` for Navidrome to detect your library. That was a bad first take though 😅, cause I just had a look at the docs and [it looks like you can just add more](https://www.navidrome.org/docs/usage/multi-library/#creating-additional-libraries) & point to any path, so I'll go with this approach instead 🙏
👍 1
pharaohgraphy force-pushed 0.2.0+0.58.0 from 12d7280f8d to 84d7fe43a7 2025-11-06 03:40:22 +00:00 Compare
decentral1se approved these changes 2025-11-06 09:18:19 +00:00
decentral1se left a comment
Owner
Copy Link

👏

👏
❤️ 1
pharaohgraphy force-pushed 0.2.0+0.58.0 from 84d7fe43a7 to ae8e17d4ce 2025-11-06 09:54:57 +00:00 Compare
pharaohgraphy merged commit 590fab5c57 into main 2025-11-06 09:55:28 +00:00
pharaohgraphy deleted branch 0.2.0+0.58.0 2025-11-06 09:55:28 +00:00
decentral1se commented 2025-11-06 10:08:48 +00:00
Owner
Copy Link

@ammaratef45 @pharaohgraphy i'm just reviewing to help things move along but I recommend you both check out coop-cloud/traefik#61 and implement a MAINTAINERS.md here also? Then we're building some maintainership over this recipe for long-term sustainability 🙏

@ammaratef45 @pharaohgraphy i'm just reviewing to help things move along but I recommend you both check out https://git.coopcloud.tech/coop-cloud/traefik/pulls/61 and implement a `MAINTAINERS.md` here also? Then we're building some maintainership over this recipe for long-term sustainability 🙏
❤️ 1
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se fauno flancian Frando iexos jade javielico jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie marlon mayel mirsal moritz nicksellen notplants p4u1 pau pharaohgraphy renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/navidrome#3
No description provided.
Delete Branch ":0.2.0+0.58.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?