Going from 34 to 35 #140

Closed
opened 2026-10-13 20:00:04 +00:00 by ineiti · 3 comments
Owner

"Oups, I did it again, I didn't follow MAINTENANCE.md and now it's a mess"

We discussed in #137 that I didn't follow MAINTENANCE.md wrt the release of v34: instead of first releasing the "rolling version" of 33, I started with releasing the new version 34. And now the problem is that it's very difficult to add the rolling version of 33 after, even though 34 is not abra recipe released yet. Instead of trying to fix this with force push and/or branches, I propose the following:

  1. abra recipe release of 15.2.0-34.0.2, instead of 15.0.0-34.0.2 because of my earlier mishaps with pushing a 15.1.0 tag, see #112
  2. creating a "rolling" release 15.3.0-34 - not sure if it can be named like that because of the missing minor and patch version
  3. creating a PR for a major update to 16.0.0-35.0.1, and release it once it has been tested by two maintainers

@moritz @dannygroenewegen - does that sound OK to you?

"Oups, I did it again, I didn't follow MAINTENANCE.md and now it's a mess" We discussed in #137 that I didn't follow `MAINTENANCE.md` wrt the release of v34: instead of _first_ releasing the "rolling version" of 33, I started with releasing the new version 34. And now the problem is that it's very difficult to add the rolling version of 33 _after_, even though 34 is not `abra recipe release`d yet. Instead of trying to fix this with force push and/or branches, I propose the following: 1. `abra recipe release` of `15.2.0-34.0.2`, instead of `15.0.0-34.0.2` because of my earlier mishaps with pushing a 15.1.0 tag, see #112 2. creating a "rolling" release `15.3.0-34` - not sure if it can be named like that because of the missing minor and patch version 3. creating a PR for a major update to `16.0.0-35.0.1`, and release it once it has been tested by two maintainers @moritz @dannygroenewegen - does that sound OK to you?
ineiti self-assigned this 2026-10-13 20:00:12 +00:00
Owner

Sorry I'm a bit confused. I think I still don't really understand what's your plan now. Before we're going from 34 to 35 we need to go from 33 to 34.

abra recipe release of 15.2.0-34.0.2, instead of 15.0.0-34.0.2 because of my earlier mishaps with pushing a 15.1.0 tag, see #112

There is no 15.x.y tag: https://git.coopcloud.tech/coop-cloud/nextcloud/tags

I would propose the following:

  1. Revert 9d25f7ee3c
  2. Change all nextcloud images to image: nextcloud:33-fpm and commit it
  3. publish the release 14.6.0+33-fpm
  4. Cherry-Pick 9d25f7ee3c
  5. Publish the next major release 15.0.0+34.0.4-fpm
Sorry I'm a bit confused. I think I still don't really understand what's your plan now. Before we're going from 34 to 35 we need to go from 33 to 34. > abra recipe release of 15.2.0-34.0.2, instead of 15.0.0-34.0.2 because of my earlier mishaps with pushing a 15.1.0 tag, see [#112](https://git.coopcloud.tech/coop-cloud/nextcloud/issues/112) There is no `15.x.y` tag: https://git.coopcloud.tech/coop-cloud/nextcloud/tags I would propose the following: 1. Revert https://git.coopcloud.tech/coop-cloud/nextcloud/commit/9d25f7ee3c5f23e4fcf7b4b603bd48a7b5207425 1. Change all nextcloud images to `image: nextcloud:33-fpm` and commit it 2. publish the release `14.6.0+33-fpm` 3. Cherry-Pick https://git.coopcloud.tech/coop-cloud/nextcloud/commit/9d25f7ee3c5f23e4fcf7b4b603bd48a7b5207425 4. Publish the next major release `15.0.0+34.0.4-fpm`
Owner

I would propose the following:

  1. Revert 9d25f7ee3c
  2. Change all nextcloud images to image: nextcloud:33-fpm and commit it
  3. publish the release 14.6.0+33-fpm
  4. Cherry-Pick 9d25f7ee3c
  5. Publish the next major release 15.0.0+34.0.4-fpm

Agree with this plan. I can probably do that this week, but if anyone else is earlier, that's also ok.

For context about the confusion, see #104 (comment). About two months ago, ineiti made a branch for a PR that already included the annotated tag for 15.x. This tag was added to the recipe catalogue, but abra appeared to only pick that up with abra app new and not on upgrades of existing deployments. So there were a couple of days where someone could have made a new deployment based on a version tag from a PR branch (while the main branch was still at 13.x). We decided to remove the 15.x tags from the branch PR. If someone deployed that, their local repo still kept the 15.x tags and abra simply doesn't see an upgrade until the main branch catches up to 15.x. Back then we thought about skipping the 15.0 and 15.1 tags on the main branch, but by now nextcloud is at 34.0.4 instead of 34.0.1 that was in the faulty branch. So there won't be a duplicate tag conflict anymore for anyone who still has the removed 15.x tag in their local repo.

> I would propose the following: > > 1. Revert https://git.coopcloud.tech/coop-cloud/nextcloud/commit/9d25f7ee3c5f23e4fcf7b4b603bd48a7b5207425 > 1. Change all nextcloud images to `image: nextcloud:33-fpm` and commit it > 2. publish the release `14.6.0+33-fpm` > 3. Cherry-Pick https://git.coopcloud.tech/coop-cloud/nextcloud/commit/9d25f7ee3c5f23e4fcf7b4b603bd48a7b5207425 > 4. Publish the next major release `15.0.0+34.0.4-fpm` Agree with this plan. I can probably do that this week, but if anyone else is earlier, that's also ok. For context about the confusion, see https://git.coopcloud.tech/coop-cloud/nextcloud/issues/104#issuecomment-37973. About two months ago, ineiti made a branch for a PR that already included the annotated tag for 15.x. This tag was added to the recipe catalogue, but abra appeared to only pick that up with `abra app new` and not on upgrades of existing deployments. So there were a couple of days where someone could have made a new deployment based on a version tag from a PR branch (while the main branch was still at 13.x). We decided to remove the 15.x tags from the branch PR. If someone deployed that, their local repo still kept the 15.x tags and abra simply doesn't see an upgrade until the main branch catches up to 15.x. Back then we thought about skipping the 15.0 and 15.1 tags on the main branch, but by now nextcloud is at 34.0.4 instead of 34.0.1 that was in the faulty branch. So there won't be a duplicate tag conflict anymore for anyone who still has the removed 15.x tag in their local repo.
Author
Owner

Here you go: #143

Here you go: #143
Sign in to join this conversation.
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/nextcloud#140