coop-cloud/nextcloud
9
6
Fork 12
Code Issues 23 Pull Requests 8 Releases Wiki Activity

healthchecks #32

Merged
moritz merged 8 commits from healthchecks into main 2023-01-12 21:16:32 +00:00
Conversation 4 Commits 8 Files Changed 3
+25
moritz commented 2023-01-10 16:47:14 +00:00
Member
Copy Link
Copy Source

Adding healthchecks for the container web (this is testing the whole chain nginx->php-fpm->nextcloud), mariadb, redis and php-fpm (Solving #22)

Adding healthchecks for the container web (this is testing the whole chain nginx->php-fpm->nextcloud), mariadb, redis and php-fpm (Solving https://git.coopcloud.tech/coop-cloud/nextcloud/issues/22)
moritz added 4 commits 2023-01-10 16:47:17 +00:00
web healthcheck 1d19ed8fd3
redis healthcheck cc62b00bbf
mariadb healthcheck 652f28155c
php-fpm healthcheck
continuous-integration/drone/pr Build is failing
Details
d98ca0ff02
moritz force-pushed healthchecks from d98ca0ff02 to 3f778ef1eb 2023-01-10 17:25:24 +00:00 Compare
moritz commented 2023-01-10 17:28:59 +00:00
Author
Member
Copy Link
Copy Source

Does anyone have any idea why the drone build fails with Error loading key "(stdin)": invalid format?

Does anyone have any idea why the drone build fails with `Error loading key "(stdin)": invalid format`?
moritz added 1 commit 2023-01-10 17:31:34 +00:00
fix CI deployment: set healthcheck version
continuous-integration/drone/pr Build is failing
Details
55866403ee
decentral1se reviewed 2023-01-11 10:03:10 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

Nice to have healthchecks but these seem brittle and prone to breaking. In my experiecne a broken healthcheck can be worse than no healthcheck because your container will fail in ways which can be very mysterious until you remember to check the healthcheck 😅 (abra could help more here too...) Is there any way to make these more future proof? Thanks!

Nice to have healthchecks but these seem brittle and prone to breaking. In my experiecne a broken healthcheck can be worse than no healthcheck because your container will fail in ways which can be very mysterious until you remember to check the healthcheck 😅 (`abra` could help more here too...) Is there any way to make these more future proof? Thanks!
compose.yml Outdated
@@ -36,0 +36,4 @@
secrets:
- admin_password
healthcheck:
test: ["CMD-SHELL", 'curl -s -N --user admin:$$(cat /run/secrets/admin_password) localhost/ocs/v2.php/apps/serverinfo/api/v1/info | grep "statuscode>200<"']
decentral1se commented 2023-01-11 10:01:26 +00:00
Owner
Copy Link
Copy Source

localhost/ocs/v2.php/apps/serverinfo/api/v1/info There's two version strings in this URI? I wonder if they'll change? Could be some breakages here... any other way to do it?

`localhost/ocs/v2.php/apps/serverinfo/api/v1/info` There's two version strings in this URI? I wonder if they'll change? Could be some breakages here... any other way to do it?
moritz commented 2023-01-11 14:50:31 +00:00
Author
Member
Copy Link
Copy Source

This uses the https://github.com/nextcloud/serverinfo app, which is installed per default. It is able to check the nextcloud health in more depth.
https://github.com/nextcloud/docker/issues/676
But I can't guarantee that this app won't change in future.
A more future prove approach is to use /status.php as for the php-fpm healthcheck.

This uses the https://github.com/nextcloud/serverinfo app, which is installed per default. It is able to check the nextcloud health in more depth. https://github.com/nextcloud/docker/issues/676 But I can't guarantee that this app won't change in future. A more future prove approach is to use /status.php as for the php-fpm healthcheck.
moritz marked this conversation as resolved
healthcheck.sh Outdated
@@ -0,0 +1,8 @@
#!/bin/bash
which cgi-fcgi > /dev/null || (apt-get update && apt-get install -y libfcgi-bin)
decentral1se commented 2023-01-11 10:02:07 +00:00
Owner
Copy Link
Copy Source

Seems like overkill having to install for a healthcheck + also confusing to do that installation inside the actual healthcheck logic. Can't you first open a ticket upstream (ideal to have the package in the image) or do it in the entrypoint?

Seems like overkill having to install for a healthcheck + also confusing to do that installation inside the actual healthcheck logic. Can't you first open a ticket upstream (ideal to have the package in the image) or do it in the entrypoint?
moritz commented 2023-01-11 14:56:05 +00:00
Author
Member
Copy Link
Copy Source

I put it in the entrypoint for now, but I try to get it upstream.

I put it in the entrypoint for now, but I try to get it upstream.
moritz marked this conversation as resolved
decentral1se commented 2023-01-11 10:16:20 +00:00
Owner
Copy Link
Copy Source

Does anyone have any idea why the drone build fails with Error loading key "(stdin)": invalid format?

I think that's a permission thing? It doesn't have access to the key it needs due to being a PR? In general, our CI for the recipes is a bit confusing, some do it, some don't. We could coordinate to figure out a way to make this work better.

> Does anyone have any idea why the drone build fails with Error loading key "(stdin)": invalid format? I think that's a permission thing? It doesn't have access to the key it needs due to being a PR? In general, our CI for the recipes is a bit confusing, some do it, some don't. We could coordinate to figure out a way to make this work better.
moritz added 2 commits 2023-01-11 14:39:41 +00:00
make web healthcheck more future prove d0f6ca27be
install cgi-fcgi via entrypoint
continuous-integration/drone/pr Build is failing
Details
dbe88a0eaa
moritz added 1 commit 2023-01-11 14:58:51 +00:00
remvove unnecessary admin_password from web container
continuous-integration/drone/pr Build is failing
Details
30ce2ba98e
decentral1se approved these changes 2023-01-12 20:17:08 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

Great work! LGTM!

Great work! LGTM!
moritz merged commit 19c260b8da into main 2023-01-12 21:16:32 +00:00
moritz referenced this issue from a commit 2023-01-12 21:16:37 +00:00
healthchecks (#32)
moritz deleted branch healthchecks 2023-01-12 21:16:44 +00:00
cgalo5758 referenced this issue from a commit 2023-08-08 08:30:09 +00:00
healthchecks (#32)
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
 documentation
For issues that are calling out documentation gap
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) BornDeleuze Brooke cas (Cassowary) coopcloud dannygroenewegen (Danny Groenewegen) decentral1se (d1) fauno (fauno) ineiti (Linus Gasser) javielico (Javielico) jjsfunhouse kawaiipunk (KawaiiPunk) knoflook moosemower notplants oxaliq (sorrel) p4u1 renovate-bot (Comrade Renovate Bot) stevensting trav (Trav Fryer) yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/nextcloud#32