coop-cloud/nextcloud
8
3
Fork 7
Code Issues 10 Pull Requests 1 Releases Wiki Activity

remove post_install_occ #55

Merged
ammaratef45 merged 1 commits from improve_readme into main 2025-10-30 17:38:15 +00:00
Conversation 5 Commits 1 Files Changed 3 +8 -21
ammaratef45 commented 2025-10-18 02:07:25 +00:00
Owner
Copy Link

post_install_occ is redundant with run_occ, keeping one only (run_occ seem to have broader application/purpose)

inspired by #54

`post_install_occ` is redundant with `run_occ`, keeping one only (`run_occ` seem to have broader application/purpose) inspired by #54
ammaratef45 added 1 commit 2025-10-18 02:07:26 +00:00
remove post_install_occ
Some checks failed
continuous-integration/drone/pr Build is failing
Details
dbdf6227e1
decentral1se commented 2025-10-18 13:29:19 +00:00
Owner
Copy Link

@moritz asked to wait for a review as this might have some importance for alakazam.

@moritz asked to wait for a review as this might have some importance for alakazam.
👍 1
3wordchant commented 2025-10-18 14:32:43 +00:00
Owner
Copy Link

@moritz gave this example: a3289ce056/alaka-defaults.yml (L43)

AFAICT it's using APPS but not OCC_CMDS.

I think another argument in favour of removing OCC_CMDS & post_install_occ is that POST_DEPLOY_CMDS exists in abra, so OCC_CMDS=app:disable dashboard could be replaced with POST_DEPLOY_CMDS=app run_occ app:disable dashboard and it would be even more automatic?

@moritz gave this example: https://git.local-it.org/local-it/kolli-config/src/commit/a3289ce056e33f66dccfda60d5aaa66ba89ee4a2/alaka-defaults.yml#L43 AFAICT it's using `APPS` but not `OCC_CMDS`. I think another argument in favour of removing `OCC_CMDS` & `post_install_occ` is that `POST_DEPLOY_CMDS` exists in `abra`, so `OCC_CMDS=app:disable dashboard` could be replaced with `POST_DEPLOY_CMDS=app run_occ app:disable dashboard` and it would be even more automatic?
👍 3
moritz commented 2025-10-20 11:41:45 +00:00
Owner
Copy Link

I originally added this to run multiple occ commands in one abra command:
3156757fee
We don't use it anymore.

I originally added this to run multiple occ commands in one abra command: https://git.coopcloud.tech/coop-cloud/nextcloud/commit/3156757feecc17c516161190117bdec582cdd513 We don't use it anymore.
ammaratef45 commented 2025-10-20 18:25:39 +00:00
Author
Owner
Copy Link

I originally added this to run multiple occ commands in one abra command:
3156757fee
We don't use it anymore.

Just to confirm, is that you clearing this PR for merge? 😆

> I originally added this to run multiple occ commands in one abra command: > https://git.coopcloud.tech/coop-cloud/nextcloud/commit/3156757feecc17c516161190117bdec582cdd513 > We don't use it anymore. Just to confirm, is that you clearing this PR for merge? 😆
👍 1
3wordchant commented 2025-10-30 13:37:01 +00:00
Owner
Copy Link

@ammaratef45 there was a 👍 from Moritz, sounds like you're clear for some righteous <del> energy

@ammaratef45 there was a 👍 from Moritz, sounds like you're clear for some righteous `<del>` energy
🎉 2
ammaratef45 merged commit aa3ab83a38 into main 2025-10-30 17:38:15 +00:00
ammaratef45 deleted branch improve_readme 2025-10-30 17:38:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
documentation
For issues that are calling out documentation gap
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se fauno flancian Frando iexos jade javielico jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie marlon mayel mirsal moritz nicksellen notplants p4u1 pau pharaohgraphy renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val vaznasty virtualboys wolcen wykwit xynosis yksflip
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/nextcloud#55
No description provided.
Delete Branch "improve_readme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?