feat: add check_major_upgrade abra.sh function to check readiness for the next major #105

Merged
dannygroenewegen merged 1 commits from feat/check-major-upgrade into main 2026-08-11 09:33:13 +00:00
Owner

Checks version skip, pending DB upgrade, occ update:check status, and
non-shipped app compatibility (with an apps.nextcloud.com fallback
lookup) to verify if it looks safe to upgrade to the next Nextcloud major
version.

Checks version skip, pending DB upgrade, occ update:check status, and non-shipped app compatibility (with an apps.nextcloud.com fallback lookup) to verify if it looks safe to upgrade to the next Nextcloud major version.
ineiti reviewed 2026-08-10 09:38:07 +00:00
ineiti left a comment
Owner

There definitely should be a standard way to do this with abra - I remember some discussion, but as far as I know, this is not done yet.

Did you create the script using any LLMs? Then I propose to add the disclaimer from https://git.coopcloud.tech/c4dt/ai-policy (self-promotion...)

There definitely should be a standard way to do this with abra - I remember some discussion, but as far as I know, this is not done yet. Did you create the script using any LLMs? Then I propose to add the disclaimer from https://git.coopcloud.tech/c4dt/ai-policy (self-promotion...)
abra.sh Outdated
@@ -196,0 +224,4 @@
return 1
fi
current_version=$(echo "$status_json" | php -r '$d=json_decode(stream_get_contents(STDIN),true); echo $d["versionstring"] ?? "";')
Owner

is jq available in the docker image? That would make this nicer...

current_version=$(echo "$status_json" | jq -r '.versionstring // ""')
is `jq` available in the docker image? That would make this nicer... ``` current_version=$(echo "$status_json" | jq -r '.versionstring // ""') ```
Author
Owner

Unfortunately, jq is not available.

Unfortunately, jq is not available.
@@ -1 +1,2 @@
Last release for nextcloud-32, pointing to the latest version of nextcloud-32.
Last release for nextcloud-32.
Owner

I'm not sure it makes sense to change the release-notes after the tag is created. Perhaps for later tags, but if somebody upgrades to tag 13.2.0, I think the release notes will not show.

I'm not sure it makes sense to change the release-notes after the tag is created. Perhaps for later tags, but if somebody upgrades to tag 13.2.0, I think the release notes will not show.
dannygroenewegen marked this conversation as resolved
Owner

And a minor nitpick: I like my .md files hard-wrapped and every new sentence on a new line. This makes later diffs more readable. Would you agree to run prettier on your changes?

And a minor nitpick: I like my `.md` files hard-wrapped and every new sentence on a new line. This makes later diffs more readable. Would you agree to run `prettier` on your changes?
Owner

Is this for 13.2.1 or 14.0.0? I propose the latter, so we can keep 13.2.0 finished. But I don't have any hard opinion on this one.

Is this for 13.2.1 or 14.0.0? I propose the latter, so we can keep 13.2.0 finished. But I don't have any hard opinion on this one.
dannygroenewegen added 1 commit 2026-08-10 13:29:38 +00:00
Checks version skip, pending DB upgrade, occ update:check status, and
non-shipped app compatibility (with an apps.nextcloud.com fallback
lookup) to verify if it looks safe to upgrade to the next Nextcloud major
version.
dannygroenewegen force-pushed feat/check-major-upgrade from f866496870 to 2fb279d96a 2026-08-10 13:29:38 +00:00 Compare
Author
Owner

Is this for 13.2.1 or 14.0.0? I propose the latter, so we can keep 13.2.0 finished. But I don't have any hard opinion on this one.

Agree, next release is fine. Doesn't need to be released on its own.

> Is this for 13.2.1 or 14.0.0? I propose the latter, so we can keep 13.2.0 finished. But I don't have any hard opinion on this one. Agree, next release is fine. Doesn't need to be released on its own.
dannygroenewegen requested review from ineiti 2026-08-10 13:31:21 +00:00
ineiti approved these changes 2026-08-11 04:38:00 +00:00
dannygroenewegen merged commit 2fb279d96a into main 2026-08-11 09:33:12 +00:00
dannygroenewegen deleted branch feat/check-major-upgrade 2026-08-11 09:33:13 +00:00
Sign in to join this conversation.