chore(deps): update pgautoupgrade/pgautoupgrade docker tag to v18 #85
Open
renovate-bot
wants to merge 1 commits from
renovate/pgautoupgrade-pgautoupgrade-18.x into main
pull from: renovate/pgautoupgrade-pgautoupgrade-18.x
merge into: :main
:main
:renovate/redis-8.x
:renovate/docker.elastic.co-elasticsearch-elasticsearch-9.x
:renovate/nginx-1.x
:update_33.0.8
:renovate/pgautoupgrade-pgautoupgrade-18.x
:pr-15.2.0+34.0.2-fpm
:pr-14.1.0+33.0.7-fpm
:pr-14.2.0+33-fpm
:pr-15.1.0+34.0.2-fpm
:pr-15.0.0+34.0.2-fpm
:pr-14.0.1+33.0.7-fpm
:feat/check-major-upgrade
:pr-14.0.0+33-fpm
:temp
:fix/nginx-conf-config-name
:pr-13.2.0+32-fpm
:upload-limit
:feature/imaginary
:kc_stable
:nextcloud-v28
:add-theming-v28.0.5
:add-theming
:update-nginx-conf
:split-bbb-onlyoffice-compos
:split-onlyoffice-bbb-config
:authentik_sso
:healthchecks
:occ_cmds
:auto_app_install
:embed_nextcloud_in_iframe
:auto_configure_sso
:add-postgres-db
No labels
help wanted
Milestone
No items
No Milestone
Assignees
3wordchant
aadil (Aadil Ayub)
abra-bot (Abra Bot)
ammaratef45
amras (Sarma)
BornDeleuze
Brooke
cas (Cassowary)
coopcloud
dannygroenewegen (Danny Groenewegen)
decentral1se (d1)
fauno (fauno)
ineiti (Linus Gasser)
javielico (Javielico)
jjsfunhouse
kawaiipunk (KawaiiPunk)
knoflook
moosemower
notplants
oxaliq (sorrel)
p4u1
renovate-bot (Comrade Renovate Bot)
stevensting
trav (Trav Fryer)
yksflip
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/nextcloud#85
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
This PR contains the following updates:
17-debian->18-debianConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.
Is anybody using postgresql and can test if this works?
We are using postgresql and have had some issues with the change that preceded this, from the upstream postgres image to the autoupgrade container. one thing that will certainly break here is that the mount path for the data volume changes in version 18, from /var/lib/postresql/data to var/lib/postgresql
this is also a sudden update across 4 major versions of postgres, which historically does not update across versions easily (which is what motivated the change to the autoupgrade container). i think it's too big of an update.
is there a precedent for other recipes when they update their database versions? we do need to update the postgres container, but i'd like to have more of a plan than just allowing renovated bot to bump us 4 versions.
07185ef4e9tod5e0064c74I'm planning (very soon, fingers crossed) to merge my draft I'm using in production for v34 to this repo, but in two steps: first v33, adding a v32 "use latest" version, then v34, adding a v33 "use latest" version.
I could either
or
But in the latter case we'd still be two versions behind. Do you have any preference? Would you be able to test this out on a production system?
i've confirmed that upgrade from 14 to 17 works. i would ask that the upgrade from 17 to 18 be a different release as this is the upgrade that changes the mount point and i ran into issues with it on testing
@@ -23,5 +23,5 @@- db_passwordhealthcheck:test: ["CMD-SHELL", "pg_isready", "-U", "nextcloud"]interval: 10stimeout: 5sthis will need to be updated. i haven't looked into why, but the healthcheck is not being parsed correctly in list form and is trying to run as the "root" role in postgres.
changing to this resolves the issue:
test: ["CMD-SHELL", "pg_isready -U nextcloud -d nextcloud"]@ineiti i'm at the same co-op as @maren and she's out of office, so i can speak to our preference being:
Here is the documentation for
healthcheck:https://docs.docker.com/reference/compose-file/services/#healthcheck
So the question is more "why did it work before?". To me it looks like with the full arguments it only ran
pg_isready...I hope I can create a first PR this evening and ask @dannygroenewegen to test it, too.
I would also go for releasing v33. Then release a recipe for PG upgrade to v17.
I saw another approach for the "use latest" we discussed in MAINTENANCE.MD. See Bonfire recipe compose.yml:
We could add a commented-out env for
nc_version_overridethat overrides the image tag. Then we don't have to do a "use latest" release for every major. And it allows for setting this env to v32 while still getting other recipe updates. What do you think?I thought of doing both at the same time: a PR which updates to v33 and PG to v17 at the same time. But I'm not sure how people usually update their services.
What would be the advantage over having a specific tag for the "use latest" v32? To me this looks too error-prone, specifically if people start to change the versions in their .env files by themselves, and then file a bug... But perhaps I'm missing something?
Can't quickly find a source, but I thought the experience was not to do two major updates in one release if it can be avoided. If something breaks during the upgrade, you have two places to look.
It's indeed more error-prone. The advantage would be that we don't have to release a "use latest" for every vX. And it would allow people to stay on v32 while still using the latest recipe release, which could include other updates.
So you propose to create a:
?
Now we need to find a consensus :) If you feel that would be really good, let's do it. A middle-way would be to keep the current fixed-versions for 'normal' releases, and then only do the variables in
13.1.5+32.0.13-fpm.I'm really scared of bug reports from the tag
13.1.5+32.0.13-fpmpointing to another version... Also, if you doabra app ls -S, you can see the versions, but with the variables, you're not sure anymore what the versions are!I'm not so scared of bug reports, but the visibility of what's running is a good point. Let's stick to a use latest release.
Almost. Nextcloud V33 and PG17 are major releases so the recipe version should also follow that:
Oups - bad copy/paste in my head. Of course!
(probably) last question: is it 15.0.0 for pg17, or 14.1.0? I'd tend to use the latter, and only increase the major version of the recipe for new major versions of the package itself.
From the handbook:
so it's probably not backwards compatible and we should use the major? Or how do you interpret this?
Yes, 14.1.0 for pg17 is maybe better. Agree to take the perspective of Nextcloud here. Upgrading pg14 to pg17 works fine with pgautoupgrade, so this can be a minor recipe update. But pg18 has a change in the data volume mount path, so that might need a major recipe version if that's indeed a harder pgupgrade.
Let's continue the discussion in #102 and keep this around for a 15.2.0 or so.
d5e0064c74to75fa0f6c50View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.