coop-cloud/nocodb
coop-cloud/nocodb
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

upgrade #1

Merged
fauno merged 3 commits from upgrade into main 2024-12-30 14:57:01 +00:00
Conversation 4 Commits 3 Files Changed 2 +4 -4
fauno commented 2024-12-27 20:17:51 +00:00
Owner
Copy Link

i also see FATAL: role "-d" does not exist messages on logs and i'm not sure it's known error, the recipe seems to work correctly

i also see `FATAL: role "-d" does not exist` messages on logs and i'm not sure it's known error, the recipe seems to work correctly
fauno added 2 commits 2024-12-27 20:17:52 +00:00
decentral1se reviewed 2024-12-27 22:13:08 +00:00
decentral1se left a comment
Owner
Copy Link

Just passing by, LGTM!

The error in the logs is probably the -d of the healthcheck command?

compose.yml Lines 45 to 49 in 172e8aac65
healthcheck:
test: pg_isready -U ${DATABASE_USER} -d ${DATABASE_NAME}
interval: 10s
timeout: 2s
retries: 10

Just passing by, LGTM! The error in the logs is probably the `-d` of the `healthcheck` command? https://git.coopcloud.tech/coop-cloud/nocodb/src/commit/172e8aac650bd777caa3e111963b3097985ca825/compose.yml#L45-L49
fauno added 1 commit 2024-12-27 22:49:48 +00:00
fauno commented 2024-12-27 22:51:02 +00:00
Author
Owner
Copy Link

The error in the logs is probably the -d of the healthcheck command?

By looking at other recipes, the variables should be escaped, but they're not needed anyway because both user and db are hardcoded, so I changed it to that!

> The error in the logs is probably the `-d` of the `healthcheck` command? By looking at other recipes, the variables should be escaped, but they're not needed anyway because both user and db are hardcoded, so I changed it to that!
decentral1se commented 2024-12-28 09:44:56 +00:00
Owner
Copy Link

Does that work @fauno? Merge away if so!

I checked the other recipes, not sure what works 😂

grep -iR "pg_isready" .
./onlyoffice/compose.yml:      test: ["CMD", "pg_isready"]
./redmine/compose.yml:      test: ["CMD", "pg_isready", "-U", "redmine"]
./levelfly/compose.yml:      test: ["CMD", "pg_isready", "-U", "levelfly"]
./peertube/compose.yml:      test: pg_isready -U peertube
./matrix-synapse/compose.discord.yml:      test: ["CMD", "pg_isready", "-U", "$POSTGRES_USER" ]
./matrix-synapse/compose.yml:      test: ["CMD", "pg_isready", "-U", "synapse"]
./matrix-synapse/compose.telegram.yml:      test: ["CMD", "pg_isready", "-U", "$POSTGRES_USER" ]
./matrix-synapse/compose.signal.yml:      test: ["CMD", "pg_isready", "-U", "$POSTGRES_USER" ]
./nocodb/compose.yml:      test: pg_isready -U ${DATABASE_USER} -d ${DATABASE_NAME}
./hedgedoc/compose.yml:      test: "pg_isready"
./authentik/compose.yml:      test: ["CMD", "pg_isready", "-U", "authentik"]
./vikunja/compose.yml:      test: [ "CMD", "pg_isready", "-U", "vikunja" ]
./listmonk/compose.yml:      test: ["CMD-SHELL", "pg_isready -U listmonk"]
./etherpad/compose.yml:      test: ["CMD", "pg_isready", "-U", "etherpad"]
./rallly/compose.yml:      test: ["CMD-SHELL", "pg_isready -U postgres"]
./kanboard/compose.yml:      test: ["CMD", "pg_isready", "-U", "kanboard"]
./n8n/compose.yml:      test: ["CMD", "pg_isready", "-U", "root", "-d", "n8n"]
./nextcloud/compose.postgres.yml:      test: ["CMD-SHELL", "pg_isready", "-U", "nextcloud"]
./karrot/compose.yml:      test: ["CMD-SHELL", "pg_isready -U karrot"]
./invidious/compose.yml:      test: ["CMD-SHELL", "pg_isready -U $$POSTGRES_USER -d $$POSTGRES_DB"]
Does that work @fauno? Merge away if so! I checked the other recipes, not sure what works 😂 ``` grep -iR "pg_isready" . ./onlyoffice/compose.yml: test: ["CMD", "pg_isready"] ./redmine/compose.yml: test: ["CMD", "pg_isready", "-U", "redmine"] ./levelfly/compose.yml: test: ["CMD", "pg_isready", "-U", "levelfly"] ./peertube/compose.yml: test: pg_isready -U peertube ./matrix-synapse/compose.discord.yml: test: ["CMD", "pg_isready", "-U", "$POSTGRES_USER" ] ./matrix-synapse/compose.yml: test: ["CMD", "pg_isready", "-U", "synapse"] ./matrix-synapse/compose.telegram.yml: test: ["CMD", "pg_isready", "-U", "$POSTGRES_USER" ] ./matrix-synapse/compose.signal.yml: test: ["CMD", "pg_isready", "-U", "$POSTGRES_USER" ] ./nocodb/compose.yml: test: pg_isready -U ${DATABASE_USER} -d ${DATABASE_NAME} ./hedgedoc/compose.yml: test: "pg_isready" ./authentik/compose.yml: test: ["CMD", "pg_isready", "-U", "authentik"] ./vikunja/compose.yml: test: [ "CMD", "pg_isready", "-U", "vikunja" ] ./listmonk/compose.yml: test: ["CMD-SHELL", "pg_isready -U listmonk"] ./etherpad/compose.yml: test: ["CMD", "pg_isready", "-U", "etherpad"] ./rallly/compose.yml: test: ["CMD-SHELL", "pg_isready -U postgres"] ./kanboard/compose.yml: test: ["CMD", "pg_isready", "-U", "kanboard"] ./n8n/compose.yml: test: ["CMD", "pg_isready", "-U", "root", "-d", "n8n"] ./nextcloud/compose.postgres.yml: test: ["CMD-SHELL", "pg_isready", "-U", "nextcloud"] ./karrot/compose.yml: test: ["CMD-SHELL", "pg_isready -U karrot"] ./invidious/compose.yml: test: ["CMD-SHELL", "pg_isready -U $$POSTGRES_USER -d $$POSTGRES_DB"] ```
fauno commented 2024-12-30 14:56:51 +00:00
Author
Owner
Copy Link

It does!

It does!
🎉 1
fauno merged commit aac74b1ebb into main 2024-12-30 14:57:01 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud decentral1se fauno flancian Frando iexos javielico kawaiipunk knoflook lambdabundesverband mac-chaffee marlon mayel mirsal moritz nicksellen notplants p4u1 pau renovate-bot rix sef simon stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/nocodb#1
No description provided.
Delete Branch "upgrade"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?