allow abra to disable lint checks for service apps like backupbot #319
Labels
No Label
abra
abra-gandi
awaiting-feedback
backups
bug
build
ci/cd
community organising
contributing
coopcloud.tech
democracy
design
documentation
duplicate
enhancement
finance
funding
good first issue
help wanted
installer
kadabra
performance
proposal
question
recipes.coopcloud.tech
security
test
wontfix
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/organising#319
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
there might be apps like backupbot that don't need traefik ingress routing, still abra checks them for traefik labels. I think it would be useful to disable the lint checks or some other way to deploy apps that violate the default linting...
@yksflip oh i see, do you have a proposal for the command line interface for this?
I was also thinking, maybe, since we tend to use the
proxy
network as a naming convention for service which should have public internet access, we could just skip any service that doesn't have this network attached?Or potentially, only scan the
app
service & turn this error into a warning. Which would just mean you see a warning & can continue to run stuff.Maybe like this?
Scanning for the
proxy
network is also a great idea!I think as long as it's possible to override checks manually I like them to fail. I tend to ignore warnings :D
Hey, newbie here. I'm currently adding the flag as an option. I am assuming you only want to pass this flag when you're deploying new apps, or is there another situation(s) where you would like the linter to be disabled? (UPDATE: I'm realizing the linter logic is scoped more accurately to recipes. I'll hold off from asking more questions until I've made it through this part of the codebase.)
Following chat in #354, seems like "no DOMAIN" could also be a decent heuristic for disabling this check.
Any preferences between that, and checking for
proxy
network?#354 also revealed this is affecting
swarm-cronjob
, so some kinda fix could be handy 🤔@3wordchant I think the domain check is best as there are often times when you route with the proxy network but you don't have a domain attached ("headless traefik" installs)?
Adding a check in the
LintFunction
might be simplest. Idk if it will complicate the code much. Alternatively, we could add aCondition
to14187449a5/pkg/lint/recipe.go (L22-L28)
which checks for some stuff and then does or does not run the linting rule?