toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

fix!: disable traefik linting when DOMAIN isn't present #257

Merged
decentral1se merged 1 commits from no-domain-disable-linting into main 2023-01-23 08:31:23 +00:00
Conversation 0 Commits 1 Files Changed 2 +107 -28
decentral1se commented 2023-01-22 11:28:42 +00:00
Owner
Copy Link

Also reformats the linting output to be more readable. Does the following:

  • Traefik label linting is disabled if no DOMAIN=... is found in the recipe .env.sample
  • Reformatting of "yes"/"NO" to use "-" when skipping linting (more readable imho, see below)
  • "Severity" now comes first in the list and is easier to visually filter what is relevant?
  • Docs & some refactoring

Needs some further manual testing...

image

image

Closes coop-cloud/organising#319.

Also reformats the linting output to be more readable. Does the following: - [x] Traefik label linting is disabled if no `DOMAIN=...` is found in the recipe `.env.sample` - [x] Reformatting of "yes"/"NO" to use "-" when skipping linting (more readable imho, see below) - [x] "Severity" now comes first in the list and is easier to visually filter what is relevant? - [x] Docs & some refactoring Needs some further manual testing... ![image](/attachments/00ebe575-bd27-491e-8579-734786471511) ![image](/attachments/4069e117-0e46-405b-8510-9b834cd31eea) Closes https://git.coopcloud.tech/coop-cloud/organising/issues/319.
image.png
151 KiB
image.png
53 KiB
❤️ 1
decentral1se added 1 commit 2023-01-22 11:29:03 +00:00
fix!: disable traefik linting when DOMAIN isn't present
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
fb58e7ab5e 
Also reformats the linting output to be more readable.

Closes coop-cloud/organising#319.
decentral1se requested review from 3wordchant 2023-01-22 14:22:01 +00:00
decentral1se requested review from yksflip 2023-01-22 14:22:02 +00:00
decentral1se merged commit 54646650c7 into main 2023-01-23 08:31:22 +00:00
decentral1se deleted branch no-domain-disable-linting 2023-01-23 08:31:52 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
3wordchant
yksflip
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#257
No description provided.
Delete Branch "no-domain-disable-linting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?