app cmd argument parsing broken in latest #336

New Issue

decentral1se · 2022-08-03T11:32:59Z

decentral1se commented

2022-08-03 11:32:59 +00:00

With:

test(){
  echo "1: $1"
  echo "2: $2"
  echo "all: $@"
}

Now:

❯ ./abra app cmd panduan.lumbung.space app test -- foo bar baz
1: 
2: 
all:

And with:

diff --git a/go.mod b/go.mod
index 9a99dee..721abbb 100644
--- a/go.mod
+++ b/go.mod
@@ -46,7 +46,7 @@ require (
        github.com/sergi/go-diff v1.2.0 // indirect
        github.com/spf13/cobra v1.3.0 // indirect
        github.com/theupdateframework/notary v0.7.0 // indirect
-       github.com/urfave/cli v1.22.9
+       github.com/urfave/cli v1.22.5
        github.com/xanzy/ssh-agent v0.3.1 // indirect
        github.com/xeipuuv/gojsonpointer v0.0.0-20190809123943-df4f5c81cb3b // indirect
        golang.org/x/crypto v0.0.0-20220131195533-30dcbda58838
diff --git a/go.sum b/go.sum
index df1feba..cbcffb6 100644
--- a/go.sum
+++ b/go.sum
@@ -982,8 +982,8 @@ github.com/urfave/cli v1.20.0/go.mod h1:70zkFmudgCuE/ngEzBv17Jvp/497gISqfk5gWijb
 github.com/urfave/cli v1.22.1/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0=
 github.com/urfave/cli v1.22.2/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0=
 github.com/urfave/cli v1.22.4/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0=
-github.com/urfave/cli v1.22.9 h1:cv3/KhXGBGjEXLC4bH0sLuJ9BewaAbpk5oyMOveu4pw=
-github.com/urfave/cli v1.22.9/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0=
+github.com/urfave/cli v1.22.5 h1:lNq9sAHXK2qfdI8W+GRItjCEkI+2oR4d+MEHy1CKXoU=
+github.com/urfave/cli v1.22.5/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0=
 github.com/vbatts/tar-split v0.11.2/go.mod h1:vV3ZuO2yWSVsz+pfFzDG/upWH1JhjOiEaWq6kXyQ3VI=
 github.com/vishvananda/netlink v0.0.0-20181108222139-023a6dafdcdf/go.mod h1:+SR5DhBJrl6ZM7CoCKvpw5BKroDKQ+PJqOg65H/2ktk=
 github.com/vishvananda/netlink v1.1.0/go.mod h1:cTgwzPIzzgDAYoQrMm0EdrjRUBkTqKYppBueQtXaqoE=

It works:

❯ ./abra app cmd panduan.lumbung.space app test -- foo bar baz
1: foo
2: bar
all: foo bar baz

With: ```bash test(){ echo "1: $1" echo "2: $2" echo "all: $@" } ``` Now: ``` ❯ ./abra app cmd panduan.lumbung.space app test -- foo bar baz 1: 2: all: ``` And with: ```diff diff --git a/go.mod b/go.mod index 9a99dee..721abbb 100644 --- a/go.mod +++ b/go.mod @@ -46,7 +46,7 @@ require ( github.com/sergi/go-diff v1.2.0 // indirect github.com/spf13/cobra v1.3.0 // indirect github.com/theupdateframework/notary v0.7.0 // indirect - github.com/urfave/cli v1.22.9 + github.com/urfave/cli v1.22.5 github.com/xanzy/ssh-agent v0.3.1 // indirect github.com/xeipuuv/gojsonpointer v0.0.0-20190809123943-df4f5c81cb3b // indirect golang.org/x/crypto v0.0.0-20220131195533-30dcbda58838 diff --git a/go.sum b/go.sum index df1feba..cbcffb6 100644 --- a/go.sum +++ b/go.sum @@ -982,8 +982,8 @@ github.com/urfave/cli v1.20.0/go.mod h1:70zkFmudgCuE/ngEzBv17Jvp/497gISqfk5gWijb github.com/urfave/cli v1.22.1/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0= github.com/urfave/cli v1.22.2/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0= github.com/urfave/cli v1.22.4/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0= -github.com/urfave/cli v1.22.9 h1:cv3/KhXGBGjEXLC4bH0sLuJ9BewaAbpk5oyMOveu4pw= -github.com/urfave/cli v1.22.9/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0= +github.com/urfave/cli v1.22.5 h1:lNq9sAHXK2qfdI8W+GRItjCEkI+2oR4d+MEHy1CKXoU= +github.com/urfave/cli v1.22.5/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0= github.com/vbatts/tar-split v0.11.2/go.mod h1:vV3ZuO2yWSVsz+pfFzDG/upWH1JhjOiEaWq6kXyQ3VI= github.com/vishvananda/netlink v0.0.0-20181108222139-023a6dafdcdf/go.mod h1:+SR5DhBJrl6ZM7CoCKvpw5BKroDKQ+PJqOg65H/2ktk= github.com/vishvananda/netlink v1.1.0/go.mod h1:cTgwzPIzzgDAYoQrMm0EdrjRUBkTqKYppBueQtXaqoE= ``` It works: ``` ❯ ./abra app cmd panduan.lumbung.space app test -- foo bar baz 1: foo 2: bar all: foo bar baz ```

decentral1se added the

bug

abra

labels 2022-08-03 11:32:59 +00:00

decentral1se added this to the (deleted) project 2022-08-03 11:33:00 +00:00

decentral1se commented

2022-08-03 11:39:27 +00:00

Reported in https://github.com/urfave/cli/issues/1447.

decentral1se referenced this issue from a commit

2022-08-03 11:40:44 +00:00

fix: drop back to urfave@v1.22.5 for parsing fix

~~decentral1se referenced this issue from coop-cloud/abra 2022-08-04 09:34:25 +00:00~~