Run abra.sh commands with /bin/bash if available. #357

New Issue

moritz · 2022-11-08T13:11:40Z

moritz commented

2022-11-08 13:11:40 +00:00

Commands run by abra.sh are always executed using /bin/sh.
Writing sophisticated functions in /bin/sh can get quite complicated.
Choosing /bin/bash to run commands if it is available would be very convenient.

Related to coop-cloud/nextcloud#29 (comment)

Commands run by abra.sh are always executed using `/bin/sh`. Writing sophisticated functions in `/bin/sh` can get quite complicated. Choosing `/bin/bash` to run commands if it is available would be very convenient. Related to https://git.coopcloud.tech/coop-cloud/nextcloud/pulls/29#issuecomment-14305_

moritz added the

enhancement

abra

labels 2022-11-08 13:11:40 +00:00

decentral1se commented

2022-11-09 09:52:30 +00:00

Nice yep, some conditional logic to which /bin/bash in the remote should suffice. Then determining the shell from there? If one ctrl-f's in https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/cli/app/cmd.go for /bin/sh, it's the place to start.

Nice yep, some conditional logic to `which /bin/bash` in the remote should suffice. Then determining the shell from there? If one `ctrl-f`'s in https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/cli/app/cmd.go for `/bin/sh`, it's the place to start.

moritz self-assigned this 2022-11-11 08:52:04 +00:00

moritz referenced this issue from coop-cloud/abra

2022-11-15 13:19:24 +00:00

feat(cmd)!: run abra.sh commands with /bin/bash if available. #229

decentral1se referenced this issue from a commit

2022-11-15 22:02:17 +00:00

feat(cmd)!: run abra.sh commands with /bin/bash if available.

decentral1se closed this issue

2022-11-15 22:02:18 +00:00

Sign in to join this conversation.