abra recipe release - show diff / don't git add .
#466
Labels
No Label
abra
abra-gandi
awaiting-feedback
backups
bug
build
ci/cd
community organising
contributing
coopcloud.tech
democracy
design
documentation
duplicate
enhancement
finance
funding
good first issue
help wanted
installer
kadabra
performance
proposal
question
recipes.coopcloud.tech
security
test
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/organising#466
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I've heard that one could easily add unwanted files to a recipe in the process of recipe upgrade:
e.g.
I guess that
abra recipe release
executes agit add .
at this point?I'd suggest to rather do smth like
git add compose.yml
(or is it possible that.overwrite.yml
files have updated labels?!) or show agit diff
before.Maybe this is also a good point to review the upgrade and write last-minute upgrade notes :D
Yeh right, good to address this.
Yep 🙃
a7ce71d6cf/cli/recipe/release.go (L247)
Hmmm it's hard to know what is and isn't being hacked on at commit time. But perhaps we could filter on only "dirty" files, meaning, stuff Git already knows about? And you choose to commit new files yourself, e.g. a new
releases
directory? That might leave people wondering why some stuff gets committed and other stuff not... so could be a documentation issue also.Looking at this again, I think
git diff
ouput would be ideal for this!