coop-cloud/abra
coop-cloud
/
abra
5
2
Fork 15
Code Issues Pull Requests 4 Packages Releases 36 Activity

feat: diff on release flow #375

Merged
decentral1se merged 1 commits from diffing-release into main 2023-10-16 16:33:43 +00:00
Conversation 0 Commits 1 Files Changed 8 +107 -38
decentral1se commented 2023-10-15 11:43:25 +00:00
Owner
Copy Link

See coop-cloud/organising#466.

Needs tests.

Also, @yksflip (feedback welcome from all!) what do you think of this:

  • abra recipe upgrade <recipe> now shows a diff at the end
  • abra recipe sync <recipe> now shows a diff at the end
  • abra recipe release <recipe> shows diff before prompting if new version is correct

Is the recipe release diff overkill now? I'm unsure. Seems fine.

I've found an option that removes unstaged files from being counted in the new commit as per coop-cloud/organising#466 (comment) so we don't need to worry about rogue blabla.txt ending up in a release.

See https://git.coopcloud.tech/coop-cloud/organising/issues/466. ~~Needs tests.~~ Also, @yksflip (feedback welcome from all!) what do you think of this: * `abra recipe upgrade <recipe>` now shows a diff at the end * `abra recipe sync <recipe>` now shows a diff at the end * `abra recipe release <recipe>` shows diff before prompting if new version is correct ~~Is the `recipe release` diff overkill now? I'm unsure.~~ Seems fine. I've found an option that removes unstaged files from being counted in the new commit as per https://git.coopcloud.tech/coop-cloud/organising/issues/466#issuecomment-17231 so we don't need to worry about rogue `blabla.txt` ending up in a release.
decentral1se added 1 commit 2023-10-15 11:43:25 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
bdb27bcd9e
feat: diff on release flow 
Also, don't commit unstaged files.
decentral1se force-pushed diffing-release from bdb27bcd9e to 608a52ada9 2023-10-15 17:30:25 +00:00 Compare
decentral1se force-pushed diffing-release from 608a52ada9 to 7f7f7224c6 2023-10-16 16:31:32 +00:00 Compare
decentral1se changed title from WIP: feat: diff on release flow to feat: diff on release flow 2023-10-16 16:33:24 +00:00
decentral1se merged commit 7f7f7224c6 into main 2023-10-16 16:33:43 +00:00
decentral1se deleted branch diffing-release 2023-10-16 16:33:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
build

go build related issues

  
ci/cd

Building things with CI/CD

  
contributing

Dealing with contributing

  
design

UI/UX

  
documentation

Documenting all the things

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

relating to the project or repo itself

  
question

More information is needed

  
security

Security related

  
wontfix

This won't be fixed

No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#375
No description provided.
Delete Branch "diffing-release"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?