Offline support needs more work #471

New Issue

decentral1se · 2023-07-25T15:00:42Z

decentral1se commented

2023-07-25 15:00:42 +00:00

Finally got to the core of #432 and it's related to the changes around trying to make abra more resilient to git.coopcloud.tech downtime. I'm reverting parts of the original implementation now to get back abra ops to their original state.

Reviewing the code, there are actually very few cases when offline is possible considering our reliance on collective operations from several co-operatives. Sometimes you only want to fallback to offline when the network is not up and try to salvage something if possible. The code tries to make that decision for us currently but it needs to be refined.

I think perhaps a --offline flag would be a better approach, to trigger it. Then it is more explicit. For the clear cut cases where git.coopcloud.tech is not needed, i.e. streaming logs, those can do "offline" by default still.

Finally got to the core of https://git.coopcloud.tech/coop-cloud/organising/issues/432 and it's related to the changes around trying to make `abra` more resilient to git.coopcloud.tech downtime. I'm reverting parts of the original implementation now to get back `abra` ops to their original state. Reviewing the code, there are actually very few cases when offline is possible considering our reliance on collective operations from several co-operatives. Sometimes you only want to fallback to offline when the network is not up and try to salvage something if possible. The code tries to make that decision for us currently but it needs to be refined. I think perhaps a `--offline` flag would be a better approach, to trigger it. Then it is more explicit. For the clear cut cases where git.coopcloud.tech is not needed, i.e. streaming logs, those can do "offline" by default still.

decentral1se added the

bug

label 2023-07-25 15:00:42 +00:00

decentral1se added the

abra

label 2023-07-25 15:02:13 +00:00

decentral1se referenced this issue from a commit

2023-07-25 15:03:16 +00:00

revert: always clone latest recipe changes

decentral1se referenced this issue from coop-cloud/abra

2023-07-25 15:03:49 +00:00

revert: always clone latest recipe changes #330

decentral1se referenced this issue from a commit

2023-07-25 15:05:04 +00:00

revert: always clone latest recipe changes

decentral1se commented

2023-07-25 15:09:12 +00:00

Previous discussion: #292

We're still resilient to the catalogue going offline, that is unrelated to these changes.

Previous discussion: https://git.coopcloud.tech/coop-cloud/organising/issues/292 We're still resilient to the catalogue going offline, that is unrelated to these changes.

decentral1se self-assigned this 2023-07-25 20:06:08 +00:00

decentral1se referenced this issue from a commit

2023-07-26 06:18:06 +00:00

fix: improved offline support

decentral1se closed this issue

2023-07-26 06:18:08 +00:00

Sign in to join this conversation.

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/organising#471