toolshed/organising
toolshed/organising
8
1
Fork 0
Code Issues 120 Pull Requests Releases Activity

Offline support needs more work #471

New Issue
Closed
opened 2023-07-25 15:00:42 +00:00 by decentral1se · 1 comment
decentral1se commented 2023-07-25 15:00:42 +00:00
Owner
Copy Link

Finally got to the core of coop-cloud/organising#432 and it's related to the changes around trying to make abra more resilient to git.coopcloud.tech downtime. I'm reverting parts of the original implementation now to get back abra ops to their original state.

Reviewing the code, there are actually very few cases when offline is possible considering our reliance on collective operations from several co-operatives. Sometimes you only want to fallback to offline when the network is not up and try to salvage something if possible. The code tries to make that decision for us currently but it needs to be refined.

I think perhaps a --offline flag would be a better approach, to trigger it. Then it is more explicit. For the clear cut cases where git.coopcloud.tech is not needed, i.e. streaming logs, those can do "offline" by default still.

Finally got to the core of https://git.coopcloud.tech/coop-cloud/organising/issues/432 and it's related to the changes around trying to make `abra` more resilient to git.coopcloud.tech downtime. I'm reverting parts of the original implementation now to get back `abra` ops to their original state. Reviewing the code, there are actually very few cases when offline is possible considering our reliance on collective operations from several co-operatives. Sometimes you only want to fallback to offline when the network is not up and try to salvage something if possible. The code tries to make that decision for us currently but it needs to be refined. I think perhaps a `--offline` flag would be a better approach, to trigger it. Then it is more explicit. For the clear cut cases where git.coopcloud.tech is not needed, i.e. streaming logs, those can do "offline" by default still.
decentral1se added the
bug
 label 2023-07-25 15:00:42 +00:00
decentral1se added the
abra
 label 2023-07-25 15:02:13 +00:00
decentral1se commented 2023-07-25 15:09:12 +00:00
Author
Owner
Copy Link

Previous discussion: coop-cloud/organising#292

We're still resilient to the catalogue going offline, that is unrelated to these changes.

Previous discussion: https://git.coopcloud.tech/coop-cloud/organising/issues/292 We're still resilient to the catalogue going offline, that is unrelated to these changes.
decentral1se self-assigned this 2023-07-25 20:06:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abra
Everything to do with abra
abra-gandi
Abra Gandi plugin
awaiting-feedback
Ping/pong on comms
backups
bug
Something is not working
build
Go build related issues
ci/cd
Getting the robots into the mix
community organising
Opening this thing up
contributing
Contributors stuff
coopcloud.tech
Our main website
democracy
Democratic decision making
design
Design thinking required
documentation
Let's write things together
duplicate
This issue or pull request already exists
enhancement
New feature
finance
Money things
funding
Anything related to grant funding
good first issue
Easy start with development
help wanted
Need some help
installer
Installation related issues
kadabra
performance
Performance related
proposal
Large change which requires feedback & decisin making
question
More information is needed
recipes.coopcloud.tech
Our recipes catalogue
security
Securing our shit
test
Unit or integration test suite
wontfix
This won't be fixed
No Label
abra
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees decentral1se
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/organising#471
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?