Abra fails to deploy recipes with no published versions #476

New Issue

decentral1se · 2023-07-31T18:06:16Z

decentral1se commented

2023-07-31 18:06:16 +00:00

(EDIT: asking fedi friends if this can be moved to the critical fixes budget)

![image](/attachments/e251e558-4af5-4186-b535-3a277e53b154) (EDIT: asking fedi friends if this can be moved to the [critical fixes budget](https://git.coopcloud.tech/coop-cloud/organising/projects/24))

image.png

35 KiB

decentral1se added the

bug

label 2023-07-31 18:06:16 +00:00

decentral1se added the

abra

label 2023-08-01 17:45:42 +00:00

decentral1se commented

2023-08-01 19:47:21 +00:00

I managed to track this down to e76ed771df @moritz which I then later tried to tweak with 0582147874 due to the number of issues people were running into re: coop-cloud/organising#432. However, I realise that < 0.7.x abra used to do this for deploying a new recipe with no released versions:

WARN[0007] no versions detected, using latest commit
WARN[0007] no published release discovered for bonfire
... deploy overview...
...deploy...

But now it errors out when there are missing tags even when the version is the latest hash (fresh recipe). It used to be a Warn but now it is an Error... I could change this back to a warning but then I perhaps break kadabra 😬 Do you know if you need this to definitely be an error?

I have a diff that preserves the current erroring functionality and allows deploying a fresh recipe. Let me know if this works? I'm hesitant to make the change (risk of more regressions...) but we can try to do more manual testing? (automated test suite One Day ™️)

coop-cloud/abra#335

I managed to track this down to https://git.coopcloud.tech/coop-cloud/abra/commit/e76ed771df45cad6c095d3f319ae2acbf04b3165 @moritz which I then later tried to tweak with https://git.coopcloud.tech/coop-cloud/abra/commit/0582147874efe82e3609bc2786b3ea2d68a6a8ff due to the number of issues people were running into re: https://git.coopcloud.tech/coop-cloud/organising/issues/432. However, I realise that < 0.7.x `abra` used to do this for deploying a new recipe with no released versions: ``` WARN[0007] no versions detected, using latest commit WARN[0007] no published release discovered for bonfire ... deploy overview... ...deploy... ``` But now it errors out when there are missing tags even when the version is the latest hash (fresh recipe). It used to be a `Warn` but now it is an `Error`... I could change this back to a warning but then I perhaps break `kadabra` 😬 Do you know if you need this to definitely be an error? I have a diff that preserves the current erroring functionality and allows deploying a fresh recipe. Let me know if this works? I'm hesitant to make the change (risk of more regressions...) but we can try to do more manual testing? (automated test suite One Day ™️) https://git.coopcloud.tech/coop-cloud/abra/pulls/335

decentral1se referenced this issue from a commit

2023-08-01 19:48:22 +00:00

fix: deploy fresh recipe without versions

decentral1se referenced this issue from toolshed/abra

2023-08-01 19:50:45 +00:00

fix: deploy fresh recipe without versions #335

decentral1se referenced this issue from toolshed/abra

2023-08-02 08:50:54 +00:00

WIP: automated integration tests #338

decentral1se added this to the (deleted) project 2023-08-02 15:57:22 +00:00

decentral1se commented

2023-08-26 08:03:58 +00:00