export entries inside abra.sh are loaded into container environment, even those in abra cmd commands #498

New Issue

3wordchant · 2023-10-03T22:32:58Z

3wordchant commented

2023-10-03 22:32:58 +00:00

Steps to reproduce:

add some functions to a recipe's abra.sh which run export FOO=bar inside them
deploy the recipe
abra app run <domain> app env | grep FOO

Expected:

does not show any results

Actual:

FOO=bar output

Seems to be because of this parsing, which doesn't take into account whether an export is inside a function: https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/pkg/config/env.go#L154-L165

Steps to reproduce: 1. add some functions to a recipe's `abra.sh` which run `export FOO=bar` inside them 2. deploy the recipe 3. `abra app run <domain> app env | grep FOO` Expected: - does not show any results Actual: - `FOO=bar` output Seems to be because of this parsing, which doesn't take into account whether an `export` is inside a function: https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/pkg/config/env.go#L154-L165

3wordchant added the

bug

label 2023-10-03 22:32:58 +00:00

3wordchant commented

2023-10-03 22:33:37 +00:00

Dirty workaround for now is to change export to setenv -x in abra.sh functions 😈 (gj @cas )

Dirty workaround for now is to change `export` to `setenv -x` in `abra.sh` functions 😈 (gj @cas )

decentral1se referenced this issue from a commit

2023-10-04 00:37:44 +00:00

fix: don't export from within function

decentral1se referenced this issue from toolshed/abra

2023-10-04 00:40:11 +00:00