toolshed/abra
4
3
Fork 21
Code Issues 40 Pull Requests 5 Packages Releases 42 Activity

Fix #498 #363

Merged
decentral1se merged 2 commits from fix-498 into main 2023-10-04 09:24:41 +00:00
Conversation 1 Commits 2 Files Changed 4 +102 -52
decentral1se commented 2023-10-04 00:40:11 +00:00
Owner
Copy Link

See coop-cloud/organising#498. Maybe not robust enough but now avoids borking when export is in the actual name of the function (🙄) and skips any indented line which has export ... in it. Which seems to most likely mean it's defined in a function. Hackity hack hack 🛠️ Uses regex, should be more stable!

379915587c is the main change. The rest is shuffling code to allow for testing.

See https://git.coopcloud.tech/coop-cloud/organising/issues/498. ~~Maybe not robust enough but now avoids borking when `export` is in the actual name of the function (🙄) and skips any indented line which has `export ...` in it. Which seems to most likely mean it's defined in a function. Hackity hack hack 🛠️~~ Uses regex, should be more stable! https://git.coopcloud.tech/coop-cloud/abra/commit/379915587c249da3b2cc1473f5c406dadc9d068f is the main change. The rest is shuffling code to allow for testing.
👀 1
decentral1se added 1 commit 2023-10-04 00:40:12 +00:00
test: use _test to avoid cyclic imports 970ae0fc4e
decentral1se force-pushed fix-498 from bad686f715 to 2fcebe8309 2023-10-04 00:42:22 +00:00 Compare
decentral1se changed title from Fix #498 to WIP: fix #498 2023-10-04 00:55:56 +00:00
3wordchant commented 2023-10-04 08:30:13 +00:00
Owner
Copy Link

Looks good to me, thanks so much! 🙏

Looks good to me, thanks so much! 🙏
decentral1se force-pushed fix-498 from 2fcebe8309 to 379915587c 2023-10-04 09:21:30 +00:00 Compare
decentral1se changed title from WIP: fix #498 to Fix #498 2023-10-04 09:22:59 +00:00
decentral1se merged commit 379915587c into main 2023-10-04 09:24:41 +00:00
decentral1se deleted branch fix-498 2023-10-04 09:24:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#363
No description provided.
Delete Branch "fix-498"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?