Abra should warn if an environment variable value has a # in it #505

New Issue

2023-10-08T18:40:14Z

cas commented

2023-10-08 18:40:14 +00:00

A bunch of recipes, due to historical cruft do things like

MY_ENVIRONMENT=whatever  # comment about it

Which makes the environment variable value something like whatever # comment about it which is not ideal!

This has lead to a number of difficult and confusing issues with for example the hometown recipe and others (it's bit me at least 3 times in the last week). It'd be cool to have a lint test at deploy that checks for a # in the value, and warns if one is present (so if it's intentional, you can ignore the warning, but it'll catch this issues earlier than having spent hours trying to debug why something is happening just to have it be that an environment has a weird value in it).

A bunch of recipes, due to historical cruft do things like ``` MY_ENVIRONMENT=whatever # comment about it ``` Which makes the environment variable value something like `whatever # comment about it` which is not ideal! This has lead to a number of difficult and confusing issues with for example the `hometown` recipe and others (it's bit me at least 3 times in the last week). It'd be cool to have a lint test at deploy that checks for a # in the value, and warns if one is present (so if it's intentional, you can ignore the warning, but it'll catch this issues earlier than having spent hours trying to debug why something is happening just to have it be that an environment has a weird value in it).

👍 1

cas added the bug enhancement labels 2023-10-08 18:40:14 +00:00

cas changed title from ~~Abra should warn if an environment variable has a `#` in it~~ to Abra should warn if an environment variable value has a `#` in it

2023-10-08 18:40:33 +00:00

decentral1se self-assigned this 2023-10-08 19:44:18 +00:00

decentral1se referenced this issue from a commit

2023-10-08 20:43:09 +00:00

fix: trim comments that are not modifers

decentral1se referenced this issue from toolshed/abra

2023-10-08 20:44:49 +00:00

fix: trim comments that are not modifers #371

decentral1se added this to the (deleted) project 2023-10-09 12:35:11 +00:00

decentral1se referenced this issue from a commit

2023-10-09 12:37:43 +00:00

fix: fix: trim comments that are not modifers