toolshed/organising
toolshed/organising
8
1
Fork 0
Code Issues 120 Pull Requests Releases Activity

Use of --debug not rendering line breaks correctly #567

New Issue
Open
opened 2024-02-06 10:58:14 +00:00 by basebuilder · 3 comments
basebuilder commented 2024-02-06 10:58:14 +00:00
Copy Link

In debugging #566 I noticed the stacktraces are not properly rendering \n as line breaks. Below is output

$ abra server add eotl-sites --debug
DEBU[0000] validated eotl-sites as domain argument  caller="/home/decentral1se/work/coop-cloud/abra/cli/internal/validate.go:116 ValidateDomain"
FATA[0007] lookup eotl-sites on 127.0.0.53:53: server misbehaving  caller="/home/decentral1se/work/coop-cloud/abra/cli/server/add.go:154 glob..func1" stack="/home/decentral1se/work/coop-cloud/abra/cli/server/add.go:154              glob..func1\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/app.go:524     HandleAction\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/command.go:173 Command.Run\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/app.go:405     (*App).RunAsSubcommand\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/command.go:378 Command.startApp\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/command.go:102 Command.Run\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/app.go:277     (*App).Run\n/home/decentral1se/work/coop-cloud/abra/cli/cli.go:203                     RunApp\n/home/decentral1se/work/coop-cloud/abra/cmd/abra/main.go:22                main\n/usr/local/go/src/runtime/internal/atomic/types.go:194                     (*Uint32).Load\n/usr/local/go/src/runtime/asm_amd64.s:1650                                 goexit"
In debugging #566 I noticed the stacktraces are not properly rendering `\n` as line breaks. Below is output ``` $ abra server add eotl-sites --debug DEBU[0000] validated eotl-sites as domain argument caller="/home/decentral1se/work/coop-cloud/abra/cli/internal/validate.go:116 ValidateDomain" FATA[0007] lookup eotl-sites on 127.0.0.53:53: server misbehaving caller="/home/decentral1se/work/coop-cloud/abra/cli/server/add.go:154 glob..func1" stack="/home/decentral1se/work/coop-cloud/abra/cli/server/add.go:154 glob..func1\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/app.go:524 HandleAction\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/command.go:173 Command.Run\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/app.go:405 (*App).RunAsSubcommand\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/command.go:378 Command.startApp\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/command.go:102 Command.Run\n/home/decentral1se/go/pkg/mod/github.com/urfave/cli@v1.22.9/app.go:277 (*App).Run\n/home/decentral1se/work/coop-cloud/abra/cli/cli.go:203 RunApp\n/home/decentral1se/work/coop-cloud/abra/cmd/abra/main.go:22 main\n/usr/local/go/src/runtime/internal/atomic/types.go:194 (*Uint32).Load\n/usr/local/go/src/runtime/asm_amd64.s:1650 goexit" ```
👍 3
basebuilder added the
bug
abra
 labels 2024-02-06 10:58:14 +00:00
3wordchant commented 2024-02-10 20:26:50 +00:00
Owner
Copy Link

this would be a great usability improvement I think

this would be a great usability improvement I think
decentral1se commented 2024-03-12 22:58:40 +00:00
Owner
Copy Link

Seems doable via https://stackoverflow.com/a/74851093 We just need to refactor the logger to be loaded from a single package in which this formatter is set. Could be a pretty huge diff but probably best if we centralise it. Would help any possible logging changes in the future, e.g. coop-cloud/organising#422

Seems doable via https://stackoverflow.com/a/74851093 We just need to refactor the logger to be loaded from a single package in which this formatter is set. Could be a pretty huge diff but probably best if we centralise it. Would help any possible logging changes in the future, e.g. https://git.coopcloud.tech/coop-cloud/organising/issues/422
👍 1
decentral1se changed title from Abra: use of --debug not rendering line breaks correctly to Use of --debug not rendering line breaks correctly 2024-03-27 06:18:06 +00:00
decentral1se added
enhancement
 and removed
bug
 labels 2024-03-27 06:18:18 +00:00
decentral1se commented 2024-07-07 22:14:44 +00:00
Owner
Copy Link

Awaits https://github.com/charmbracelet/log/issues/118

Awaits https://github.com/charmbracelet/log/issues/118
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abra
Everything to do with abra
abra-gandi
Abra Gandi plugin
awaiting-feedback
Ping/pong on comms
backups
bug
Something is not working
build
Go build related issues
ci/cd
Getting the robots into the mix
community organising
Opening this thing up
contributing
Contributors stuff
coopcloud.tech
Our main website
democracy
Democratic decision making
design
Design thinking required
documentation
Let's write things together
duplicate
This issue or pull request already exists
enhancement
New feature
finance
Money things
funding
Anything related to grant funding
good first issue
Easy start with development
help wanted
Need some help
installer
Installation related issues
kadabra
performance
Performance related
proposal
Large change which requires feedback & decisin making
question
More information is needed
recipes.coopcloud.tech
Our recipes catalogue
security
Securing our shit
test
Unit or integration test suite
wontfix
This won't be fixed
No Label
abra
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/organising#567
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?