coop-cloud/outline
1
0
Fork 2
generated from coop-cloud/example
Code Issues 8 Pull Requests Projects Releases Wiki Activity

Update to postgres 15 and run pg_upgrade automatically #15

Merged
iexos merged 3 commits from :pg15 into main 2023-06-19 11:32:40 +00:00
Conversation 3 Commits 3 Files Changed 3 +53 -1
iexos commented 2023-06-15 14:18:10 +00:00
Owner
Copy Link

created an entryscript that check for incorrect PG_VERSION. if so, it downloads the old binaries and performs an update via pg_upgrade

inspired by:

works well for migrating from postgres 11 as well as deploying a fresh instance

created an entryscript that check for incorrect `PG_VERSION`. if so, it downloads the old binaries and performs an update via `pg_upgrade` inspired by: - https://github.com/docker-library/postgres/issues/37 - https://github.com/tianon/docker-postgres-upgrade/tree/master/11-to-15 - https://github.com/bwbroersma/docker-postgres-upgrade/blob/cf5c8609a70952f01681d7fc4e55ed676bcd5faf/upgrade/docker-upgrade-entrypoint-wrapper.sh works well for migrating from postgres 11 as well as deploying a fresh instance
iexos added 1 commit 2023-06-15 14:18:12 +00:00
use postgres 15 and add entrypoint.sh for pg_upgrade 5e3e8a655b
decentral1se reviewed 2023-06-15 14:55:26 +00:00
decentral1se left a comment
Owner
Copy Link

Great stuff!

Great stuff!
entrypoint.postgres.sh.tmpl
@ -0,0 +5,4 @@
NEWDATA=$PGDATA/new_data
if [ -e $MIGRATION_MARKER ]; then
echo "FATAL: previous migration not completed. manual restore necessary"
decentral1se commented 2023-06-15 14:52:59 +00:00
Owner
Copy Link

Can we help with a from which version to which we need to handle the manual restore with?

Can we help with a from which version to which we need to handle the manual restore with?
iexos commented 2023-06-15 17:00:35 +00:00
Author
Owner
Copy Link

I don't know in which state the migration did not complete, its just a safety mechanism to stop interrupted migrations that are in an unclear state. With restore I mean to restore the hopefully made backup. Does this make it more clear?

I don't know in which state the migration did not complete, its just a safety mechanism to stop interrupted migrations that are in an unclear state. With restore I mean to restore the hopefully made backup. Does this make it more clear?
👍 1
decentral1se marked this conversation as resolved
entrypoint.postgres.sh.tmpl
@ -0,0 +19,4 @@
postgresql-$DATA_VERSION \
&& rm -rf /var/lib/apt/lists/*
echo "shuffling around"
gosu postgres mkdir $OLDDATA $NEWDATA
decentral1se commented 2023-06-15 14:53:45 +00:00
Owner
Copy Link

Is gosu definitely already installed? I guess it could be included in the apt-install stuff above to help make it more portable. Just noting this thought in case it's useful.

Is `gosu` definitely already installed? I guess it could be included in the `apt-install` stuff above to help make it more portable. Just noting this thought in case it's useful.
iexos commented 2023-06-15 17:02:58 +00:00
Author
Owner
Copy Link

gosu is used in the vendor docker-entrypoint.sh. Its not portable to -alpine, but wouldn't be with apt-install either

`gosu` is used in the vendor `docker-entrypoint.sh`. Its not portable to `-alpine`, but wouldn't be with `apt-install` either
👍 1
decentral1se marked this conversation as resolved
iexos added 1 commit 2023-06-15 16:54:04 +00:00
make pg upgrade more safe e0cc0ff9af
decentral1se commented 2023-06-16 16:12:15 +00:00
Owner
Copy Link

LGTM @iexos! Perhaps some Autonomicz have some thoughts on this as they maintain Outline stuff too /cc @3wordchant @cas @knoflook Not sure who else to ping atm, feel free to merge from my side

LGTM @iexos! Perhaps some Autonomicz have some thoughts on this as they maintain Outline stuff too /cc @3wordchant @cas @knoflook Not sure who else to ping atm, feel free to merge from my side
cas commented 2023-06-18 15:56:08 +00:00
Owner
Copy Link

We hot tested this on our outline and it worked, modulo a tiny change without which it fails in a most alarming manner, see inline.

We hot tested this on our outline and it worked, modulo a tiny change without which it fails in a most alarming manner, see inline.
iexos added 1 commit 2023-06-18 21:04:09 +00:00
pg_upgrade: catch intentionally failing cmd 53913b92cd
iexos merged commit 7d2f35277b into main 2023-06-19 11:32:40 +00:00
iexos deleted branch pg15 2023-06-19 11:32:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se fauno flancian Frando iexos jade javielico jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie marlon mayel mirsal moritz nicksellen notplants p4u1 pau pharaohgraphy renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/outline#15
No description provided.
Delete Branch ":pg15"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?