Update to postgres 15 and run pg_upgrade automatically #15

iexos · 2023-06-15T14:18:10Z

iexos commented

2023-06-15 14:18:10 +00:00

created an entryscript that check for incorrect PG_VERSION. if so, it downloads the old binaries and performs an update via pg_upgrade

inspired by:

works well for migrating from postgres 11 as well as deploying a fresh instance

created an entryscript that check for incorrect `PG_VERSION`. if so, it downloads the old binaries and performs an update via `pg_upgrade` inspired by: - https://github.com/docker-library/postgres/issues/37 - https://github.com/tianon/docker-postgres-upgrade/tree/master/11-to-15 - https://github.com/bwbroersma/docker-postgres-upgrade/blob/cf5c8609a70952f01681d7fc4e55ed676bcd5faf/upgrade/docker-upgrade-entrypoint-wrapper.sh works well for migrating from postgres 11 as well as deploying a fresh instance

iexos added 1 commit 2023-06-15 14:18:12 +00:00

5e3e8a655b use postgres 15 and add entrypoint.sh for pg_upgrade

decentral1se reviewed 2023-06-15 14:55:26 +00:00

decentral1se left a comment

Great stuff!

entrypoint.postgres.sh.tmpl

						
				@ -0,0 +5,4 @@

				NEWDATA=$PGDATA/new_data

				if [ -e $MIGRATION_MARKER ]; then

				  echo "FATAL: previous migration not completed. manual restore necessary"

decentral1se commented

2023-06-15 14:52:59 +00:00

Can we help with a from which version to which we need to handle the manual restore with?

iexos commented

2023-06-15 17:00:35 +00:00

I don't know in which state the migration did not complete, its just a safety mechanism to stop interrupted migrations that are in an unclear state. With restore I mean to restore the hopefully made backup. Does this make it more clear?

👍 1

decentral1se marked this conversation as resolved

entrypoint.postgres.sh.tmpl

						
				@ -0,0 +19,4 @@

				    postgresql-$DATA_VERSION \

				    && rm -rf /var/lib/apt/lists/*

				  echo "shuffling around"

				  gosu postgres mkdir $OLDDATA $NEWDATA

decentral1se commented

2023-06-15 14:53:45 +00:00

Is gosu definitely already installed? I guess it could be included in the apt-install stuff above to help make it more portable. Just noting this thought in case it's useful.

Is `gosu` definitely already installed? I guess it could be included in the `apt-install` stuff above to help make it more portable. Just noting this thought in case it's useful.

iexos commented

2023-06-15 17:02:58 +00:00

gosu is used in the vendor docker-entrypoint.sh. Its not portable to -alpine, but wouldn't be with apt-install either

`gosu` is used in the vendor `docker-entrypoint.sh`. Its not portable to `-alpine`, but wouldn't be with `apt-install` either

👍 1

decentral1se marked this conversation as resolved

iexos added 1 commit 2023-06-15 16:54:04 +00:00

e0cc0ff9af make pg upgrade more safe

decentral1se commented

2023-06-16 16:12:15 +00:00

LGTM @iexos! Perhaps some Autonomicz have some thoughts on this as they maintain Outline stuff too /cc @3wordchant @cas @knoflook Not sure who else to ping atm, feel free to merge from my side