coop-cloud/outline
2
0
Fork 3
generated from coop-cloud/example
Code Issues 8 Pull Requests 1 Projects Releases Wiki Activity

Update to postgres 15 and run pg_upgrade automatically #15

Merged
iexos merged 3 commits from (deleted):pg15 into main 2023-06-19 11:32:40 +00:00
Conversation 3 Commits 3 Files Changed 3
+53 -1
iexos commented 2023-06-15 14:18:10 +00:00
Owner
Copy Link
Copy Source

created an entryscript that check for incorrect PG_VERSION. if so, it downloads the old binaries and performs an update via pg_upgrade

inspired by:

works well for migrating from postgres 11 as well as deploying a fresh instance

created an entryscript that check for incorrect `PG_VERSION`. if so, it downloads the old binaries and performs an update via `pg_upgrade` inspired by: - https://github.com/docker-library/postgres/issues/37 - https://github.com/tianon/docker-postgres-upgrade/tree/master/11-to-15 - https://github.com/bwbroersma/docker-postgres-upgrade/blob/cf5c8609a70952f01681d7fc4e55ed676bcd5faf/upgrade/docker-upgrade-entrypoint-wrapper.sh works well for migrating from postgres 11 as well as deploying a fresh instance
iexos added 1 commit 2023-06-15 14:18:12 +00:00
use postgres 15 and add entrypoint.sh for pg_upgrade 5e3e8a655b
decentral1se reviewed 2023-06-15 14:55:26 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

Great stuff!

Great stuff!
entrypoint.postgres.sh.tmpl
@@ -0,0 +5,4 @@
NEWDATA=$PGDATA/new_data
if [ -e $MIGRATION_MARKER ]; then
echo "FATAL: previous migration not completed. manual restore necessary"
decentral1se commented 2023-06-15 14:52:59 +00:00
Owner
Copy Link
Copy Source

Can we help with a from which version to which we need to handle the manual restore with?

Can we help with a from which version to which we need to handle the manual restore with?
iexos commented 2023-06-15 17:00:35 +00:00
Author
Owner
Copy Link
Copy Source

I don't know in which state the migration did not complete, its just a safety mechanism to stop interrupted migrations that are in an unclear state. With restore I mean to restore the hopefully made backup. Does this make it more clear?

I don't know in which state the migration did not complete, its just a safety mechanism to stop interrupted migrations that are in an unclear state. With restore I mean to restore the hopefully made backup. Does this make it more clear?
👍 1
decentral1se marked this conversation as resolved
entrypoint.postgres.sh.tmpl
@@ -0,0 +19,4 @@
postgresql-$DATA_VERSION \
&& rm -rf /var/lib/apt/lists/*
echo "shuffling around"
gosu postgres mkdir $OLDDATA $NEWDATA
decentral1se commented 2023-06-15 14:53:45 +00:00
Owner
Copy Link
Copy Source

Is gosu definitely already installed? I guess it could be included in the apt-install stuff above to help make it more portable. Just noting this thought in case it's useful.

Is `gosu` definitely already installed? I guess it could be included in the `apt-install` stuff above to help make it more portable. Just noting this thought in case it's useful.
iexos commented 2023-06-15 17:02:58 +00:00
Author
Owner
Copy Link
Copy Source

gosu is used in the vendor docker-entrypoint.sh. Its not portable to -alpine, but wouldn't be with apt-install either

`gosu` is used in the vendor `docker-entrypoint.sh`. Its not portable to `-alpine`, but wouldn't be with `apt-install` either
👍 1
decentral1se marked this conversation as resolved
iexos added 1 commit 2023-06-15 16:54:04 +00:00
make pg upgrade more safe e0cc0ff9af
decentral1se commented 2023-06-16 16:12:15 +00:00
Owner
Copy Link
Copy Source

LGTM @iexos! Perhaps some Autonomicz have some thoughts on this as they maintain Outline stuff too /cc @3wordchant @cas @knoflook Not sure who else to ping atm, feel free to merge from my side

LGTM @iexos! Perhaps some Autonomicz have some thoughts on this as they maintain Outline stuff too /cc @3wordchant @cas @knoflook Not sure who else to ping atm, feel free to merge from my side
cas commented 2023-06-18 15:56:08 +00:00
Owner
Copy Link
Copy Source

We hot tested this on our outline and it worked, modulo a tiny change without which it fails in a most alarming manner, see inline.

We hot tested this on our outline and it worked, modulo a tiny change without which it fails in a most alarming manner, see inline.
iexos added 1 commit 2023-06-18 21:04:09 +00:00
pg_upgrade: catch intentionally failing cmd 53913b92cd
iexos merged commit 7d2f35277b into main 2023-06-19 11:32:40 +00:00
iexos deleted branch pg15 2023-06-19 11:32:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm appletalk arjan basebuilder BornDeleuze Brooke carla cas (Cassowary) codegod100 coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) flancian Frando iexos jade (Jade Ambrose) javielico (Javielico) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) marlon (marlon) mayel mirsal moosemower moritz nicksellen (Nick Sellen) notplants oxaliq (sorrel) p4u1 pau pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) PhiNatalie renovate-bot (Comrade Renovate Bot) ripclap rix rscmbbng sef (sef) simon sixsmith (Sixsmith) stevensting tobias trav (Trav Fryer) val (val (he/him)) vaznasty virtualboys wolcen (Chris Thompson) wykwit xynosis yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/outline#15