coop-cloud/peertube
coop-cloud
/
peertube
generated from coop-cloud/example
1
0
Fork 1
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Re-enable healthcheck when we get the curl package in upstream #1

New Issue
Closed
opened 2021-05-06 11:10:12 +00:00 by decentral1se · 6 comments
decentral1se commented 2021-05-06 11:10:12 +00:00
Owner
Copy Link

https://github.com/Chocobozzz/PeerTube/issues/4045

> https://github.com/Chocobozzz/PeerTube/issues/4045
decentral1se commented 2021-05-06 11:15:36 +00:00
Author
Owner
Copy Link

Dropped https://github.com/Chocobozzz/PeerTube/pull/4046

Dropped https://github.com/Chocobozzz/PeerTube/pull/4046
decentral1se commented 2021-05-06 13:41:01 +00:00
Author
Owner
Copy Link

Moving fast but also need to take a look at 0609cf8662.

Moving fast but also need to take a look at https://git.autonomic.zone/coop-cloud/peertube/commit/0609cf8662af4618acaf274113291f110eec7119.
decentral1se commented 2021-05-06 14:37:10 +00:00
Author
Owner
Copy Link

/api/v1/ping is available for peertube healthchecking!

`/api/v1/ping` is available for peertube healthchecking!
decentral1se commented 2021-06-23 11:06:49 +00:00
Author
Owner
Copy Link

It should be available now with the latest release 👍

It should be available now with the latest release 👍
3wordchant commented 2021-06-24 10:02:26 +00:00
Owner
Copy Link

We could also do this (right now!) using a native healthcheck, which is apparently preferable in general?

e.g. see coop-cloud/rocketchat, https://git.autonomic.zone/coop-cloud/rocketchat/src/branch/main/compose.yml#L735-L740

Although ideally that would be upstream too, it doesn't seem amazing to be maintaining our own code-in-compose-files 🤔🤔

We could also do this (right now!) using [a native healthcheck](https://ryaneschinger.com/blog/using-docker-native-health-checks/), which is apparently preferable in general? e.g. see coop-cloud/rocketchat, https://git.autonomic.zone/coop-cloud/rocketchat/src/branch/main/compose.yml#L735-L740 Although ideally that would be upstream too, it doesn't seem amazing to be maintaining our own code-in-compose-files 🤔🤔
👍 1
mirsal commented 2021-07-15 15:54:05 +00:00
Member
Copy Link

@3wordchant that's a very good idea, PR incoming :3

Also, I'll look into getting it upstream.

@3wordchant that's a very good idea, PR incoming :3 Also, I'll look into getting it upstream.
❤️ 2
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
dev
4.0.0+v5.0.1-bullseye
3.0.0+v4.3.0-bullseye
2.2.0+v4.2.2-bullseye
2.1.1+v4.1.1-bullseye
2.1.0+v4.1.0-bullseye
2.0.0+v4.0.0-bullseye
1.0.0+v3.4.1-buster
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/peertube#1
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?