line 40: mapping key "restart_policy" already defined at line 33 #15

New Issue

2025-08-12T21:24:25Z

decentral1se commented

2025-08-12 21:24:25 +00:00

> ./abra recipe versions peertube -d                                                
DEBU <cli/run.go:65> abra version dev, commit 952d768ab0dec10b91355783e05f5c2c4612b228
DEBU <git/read.go:149> read global ignore paths: .TODO .envrc .ignore .ipy .ipython.ipy .passwds .python-version .testmondata .venv /.cache/ /.mypy_cache/ /__pycache__/ /node_modules/ /pip-wheel-metadata/ package-lock.json tags
DEBU <git/read.go:52> git status: /home/decentral1se/.abra_test/recipes/peertube: clean
FATA <internal/validate.go:77> unable to validate recipe: yaml: unmarshal errors:
  line 40: mapping key "restart_policy" already defined at line 33

``` > ./abra recipe versions peertube -d DEBU <cli/run.go:65> abra version dev, commit 952d768ab0dec10b91355783e05f5c2c4612b228 DEBU <git/read.go:149> read global ignore paths: .TODO .envrc .ignore .ipy .ipython.ipy .passwds .python-version .testmondata .venv /.cache/ /.mypy_cache/ /__pycache__/ /node_modules/ /pip-wheel-metadata/ package-lock.json tags DEBU <git/read.go:52> git status: /home/decentral1se/.abra_test/recipes/peertube: clean FATA <internal/validate.go:77> unable to validate recipe: yaml: unmarshal errors: line 40: mapping key "restart_policy" already defined at line 33 ```

decentral1se commented

2025-08-12 21:27:43 +00:00

I actually don't even know what is causing this 😭

abra catalogue generate peertube does output the error but as a warning and continues 🤔

I imagine we want versions to not dissapear from the catalogue silently in the future... in lieu of more coordinated recipe release CI (see here), do we have some small steps we could take to make this issue more visible?

I actually don't even know what is causing this 😭 `abra catalogue generate peertube` does output the error but as a warning and continues 🤔 I imagine we want versions to not dissapear from the catalogue silently in the future... in lieu of more coordinated recipe release CI (see [here](https://git.coopcloud.tech/toolshed/-/projects/31)), do we have some small steps we could take to make this issue more visible?

decentral1se commented

2025-08-12 21:33:50 +00:00

Ah, found the error... the v4 config is borked:

		peertube/compose.yml
		Lines 32 to 41 in 716ea6b19a
	
				    deploy:

				      restart_policy:

				        condition: on-failure

				      update_config:

				        failure_action: rollback

				        order: start-first

				      rollback_config:

				        order: start-first

				      restart_policy:

				        max_attempts: 10

Ah, found the error... the v4 config is borked: https://git.coopcloud.tech/coop-cloud/peertube/src/commit/716ea6b19ac3cff2f8b36cee218e26e4513f64c2/compose.yml#L32-L41

👍 1

decentral1se referenced this issue from toolshed/organising

2025-08-12 21:34:41 +00:00

Test suite for recipes? #514

3wordchant referenced this issue from toolshed/abra

2025-08-12 21:56:10 +00:00

Errors during `abra catalogue generate <recipe>` are not shown consistently #593

3wordchant referenced this issue from toolshed/abra

2025-08-12 22:01:14 +00:00

Warnings during catalogue generation should be more visible #594

3wordchant commented

2025-08-12 22:06:35 +00:00

I can't even see the warning during abra catalogue generate peertube -d, see toolshed/abra#593.

I imagine we want versions to not dissapear from the catalogue silently in the future... in lieu of more coordinated recipe release CI (see here), do we have some small steps we could take to make this issue more visible?

I opened toolshed/abra#594 about this.

Ah, found the error... the v4 config is borked

Yeah indeed.

Should we just delete the tag? It's a very old version which by definition nobody is probably running because abra can't deploy it 😬

Safer option would be a giant history rewrite to fix up that commit and rerelease under the same tag, I guess? And pray nobody runs git push -f?

I can't even see the warning during `abra catalogue generate peertube -d`, see toolshed/abra#593. > I imagine we want versions to not dissapear from the catalogue silently in the future... in lieu of more coordinated recipe release CI (see [here](https://git.coopcloud.tech/toolshed/-/projects/31)), do we have some small steps we could take to make this issue more visible? I opened toolshed/abra#594 about this. --- > Ah, found the error... the v4 config is borked Yeah indeed. Should we just delete the tag? It's a very old version which by definition nobody is probably running because abra can't deploy it 😬 Safer option would be a giant history rewrite to fix up that commit and rerelease under the same tag, I guess? And pray nobody runs `git push -f`?

decentral1se commented

2025-08-13 09:21:37 +00:00

@3wordchant oof pretty gnarly. perhaps delete all the tags that were never deployed and cut a new release with an appropriate bump (which is > the latest "never deployed" tag so as to hopefully avoid any other abra chaos, e.g. v3 -> v6) on the current HEAD? then no rewrite gymnastics and the new version just deploys for the rest? the release note could say these previous releases were sacrificed?

@3wordchant oof pretty gnarly. perhaps delete all the tags that were never deployed and cut a new release with an appropriate bump (which is > the latest "never deployed" tag so as to hopefully avoid any other `abra` chaos, e.g. v3 -> v6) on the current HEAD? then no rewrite gymnastics and the new version just deploys for the rest? the release note could say these previous releases were sacrificed?

👍 1

3wordchant commented

2025-08-13 10:22:47 +00:00

OK I did step 1 of deleting the broken tags:

3.0.0+v4.3.0-bullseye
4.0.0+v5.0.1-bullseye
4.1.0+v5.2.1-bullseye
5.0.0+v5.2.1-bullseye

And regenerated recipe catalogue, working now.

Gonna roll a new upgrade ASAP.

OK I did step 1 of deleting the broken tags: * 3.0.0+v4.3.0-bullseye * 4.0.0+v5.0.1-bullseye * 4.1.0+v5.2.1-bullseye * 5.0.0+v5.2.1-bullseye And regenerated recipe catalogue, working now. Gonna roll a new upgrade ASAP.

🎉 2

decentral1se commented

2025-09-29 06:54:02 +00:00

I believe this was resolved successfully ✅

decentral1se closed this issue

2025-09-29 06:54:02 +00:00

3wordchant commented

2026-01-09 04:11:16 +00:00

It came back somehow, deleted the tags again, fixed again, bracing for it come back yet more

😕 1

decentral1se commented

2026-01-09 09:09:26 +00:00

Maximum sadness. I think priority to set up maintainers here would solve it so that not everyone has push / sync access and keeps re-uploading this borked tag. @rscmbbng @3wordchant @cas https://docs.coopcloud.tech/maintainers/maintain/ 🙏

👍 1

3wordchant commented

2026-01-10 07:10:13 +00:00

Maximum sadness. I think priority to set up maintainers here would solve it so that not everyone has push / sync access and keeps re-uploading this borked tag. @rscmbbng @3wordchant @cas https://docs.coopcloud.tech/maintainers/maintain/ 🙏

Amen, thanks for the suggestion.

I'll also ask in Coopcloud Tech.

> Maximum sadness. I think priority to set up maintainers here would solve it so that not everyone has push / sync access and keeps re-uploading this borked tag. @rscmbbng @3wordchant @cas https://docs.coopcloud.tech/maintainers/maintain/ 🙏 Amen, thanks for the suggestion. I'll also ask in `Coopcloud Tech`.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/peertube#15