toolshed/abra
4
2
Fork 18
Code Issues 19 Pull Requests 2 Packages Releases 40 Activity

Warnings during catalogue generation should be more visible #594

New Issue
Open
opened 2025-08-12 22:01:14 +00:00 by 3wordchant · 2 comments
3wordchant commented 2025-08-12 22:01:14 +00:00
Owner
Copy Link

More findings from coop-cloud/peertube#15

abra catalogue generate peertube does output the error but as a warning and continues 🤔

I imagine we want versions to not dissapear from the catalogue silently in the future.

To which, huge agree.

I'm not sure the best solution.

More findings from coop-cloud/peertube#15 > `abra catalogue generate peertube` does output the error but as a warning and continues 🤔 > > I imagine we want versions to not dissapear from the catalogue silently in the future. To which, huge agree. I'm not sure the best solution.
3wordchant commented 2025-08-12 22:03:17 +00:00
Author
Owner
Copy Link

Having abra catalogue generate give a non-0 exit code might at least make the toolshed/auto-recipes-catalogue-json build fail. This could be behind a --fail-on-warnings option or something, if we think anyone is relying on the current behaviour.

But currently, with no build fail notifications for that repo going anywhere, this would possibly even be worse than now, because then we'd probably only notice this when the entire recipe catalogue stopped auto-updating.

This would probably be a frustrating experience for whoever randomly ran into it first, and probably wouldn't do good things for people feeling like the recipe catalogue is stable.

Adding it to Abra integration tests would at least be seen by people, but feels a bit tangential to include there? Idk

Having `abra catalogue generate` give a non-0 exit code might at least make the toolshed/auto-recipes-catalogue-json build fail. This could be behind a `--fail-on-warnings` option or something, if we think anyone is relying on the current behaviour. But currently, with no build fail notifications for that repo going anywhere, this would possibly even be worse than now, because then we'd probably only notice this when the entire recipe catalogue stopped auto-updating. This would probably be a frustrating experience for whoever randomly ran into it first, and probably wouldn't do good things for people feeling like the recipe catalogue is stable. Adding it to Abra integration tests would at least be seen by people, but feels a bit tangential to include there? Idk
decentral1se commented 2025-08-13 09:33:02 +00:00
Owner
Copy Link

Judging from the sheer amount of WARN ... in the latest catalogue generate CI job logs, I guess we would have a huge recipe gardening job to get the generation free of warnings for any "fail on WARN" approach 😭

Perhaps we need to differentiate between which errors are WARN and which should be FATAL? I think there might be some code for this already lying around. It might be possible to match on the type with errors.Is, otherwise, using a string comparison (🙈).

I'm also not sure.

Seems like we're running up against several issues with having overview of the process of release and publishing with recipes and the catalogue. I keep coming back to thinking about how we can make a holistic plan for in this project but there are other hills to die on atm...

Judging from the sheer amount of `WARN ...` in the [latest catalogue generate CI job logs](https://build.coopcloud.tech/toolshed/auto-recipes-catalogue-json/1815/1/2), I guess we would have a huge recipe gardening job to get the generation free of warnings for any "fail on `WARN`" approach 😭 Perhaps we need to differentiate between which errors are `WARN` and which should be `FATAL`? I think there might be some code for this already lying around. It might be possible to match on the type with `errors.Is`, otherwise, using a string comparison (🙈). I'm also not sure. Seems like we're running up against several issues with having overview of the process of release and publishing with recipes and the catalogue. I keep coming back to thinking about how we can make a holistic plan for in [this project](https://git.coopcloud.tech/toolshed/-/projects/31) but there are other hills to die on atm...
decentral1se added the
bug
 label 2025-08-13 11:42:47 +00:00
decentral1se added this to the Recipe release stability project 2025-08-25 10:55:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
red abya yala
Work funded by Calyx institute for Red Abya Yala
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project Recipe release stability
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas coopcloud decentral1se fauno jmakdah2 kawaiipunk knoflook lambdabundesverband moritz p4u1 ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#594
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?