Warnings during catalogue generation should be more visible #594

New Issue

2025-08-12T22:01:14Z

3wordchant commented

2025-08-12 22:01:14 +00:00

More findings from coop-cloud/peertube#15

abra catalogue generate peertube does output the error but as a warning and continues 🤔

I imagine we want versions to not dissapear from the catalogue silently in the future.

To which, huge agree.

I'm not sure the best solution.

More findings from coop-cloud/peertube#15 > `abra catalogue generate peertube` does output the error but as a warning and continues 🤔 > > I imagine we want versions to not dissapear from the catalogue silently in the future. To which, huge agree. I'm not sure the best solution.

3wordchant commented

2025-08-12 22:03:17 +00:00

Having abra catalogue generate give a non-0 exit code might at least make the toolshed/auto-recipes-catalogue-json build fail. This could be behind a --fail-on-warnings option or something, if we think anyone is relying on the current behaviour.

But currently, with no build fail notifications for that repo going anywhere, this would possibly even be worse than now, because then we'd probably only notice this when the entire recipe catalogue stopped auto-updating.

This would probably be a frustrating experience for whoever randomly ran into it first, and probably wouldn't do good things for people feeling like the recipe catalogue is stable.

Adding it to Abra integration tests would at least be seen by people, but feels a bit tangential to include there? Idk

Having `abra catalogue generate` give a non-0 exit code might at least make the toolshed/auto-recipes-catalogue-json build fail. This could be behind a `--fail-on-warnings` option or something, if we think anyone is relying on the current behaviour. But currently, with no build fail notifications for that repo going anywhere, this would possibly even be worse than now, because then we'd probably only notice this when the entire recipe catalogue stopped auto-updating. This would probably be a frustrating experience for whoever randomly ran into it first, and probably wouldn't do good things for people feeling like the recipe catalogue is stable. Adding it to Abra integration tests would at least be seen by people, but feels a bit tangential to include there? Idk

3wordchant referenced this issue from coop-cloud/peertube

2025-08-12 22:06:35 +00:00

line 40: mapping key "restart_policy" already defined at line 33 #15

decentral1se commented

2025-08-13 09:33:02 +00:00

Judging from the sheer amount of WARN ... in the latest catalogue generate CI job logs, I guess we would have a huge recipe gardening job to get the generation free of warnings for any "fail on WARN" approach 😭

Perhaps we need to differentiate between which errors are WARN and which should be FATAL? I think there might be some code for this already lying around. It might be possible to match on the type with errors.Is, otherwise, using a string comparison (🙈).

I'm also not sure.

Seems like we're running up against several issues with having overview of the process of release and publishing with recipes and the catalogue. I keep coming back to thinking about how we can make a holistic plan for in this project but there are other hills to die on atm...

Judging from the sheer amount of `WARN ...` in the [latest catalogue generate CI job logs](https://build.coopcloud.tech/toolshed/auto-recipes-catalogue-json/1815/1/2), I guess we would have a huge recipe gardening job to get the generation free of warnings for any "fail on `WARN`" approach 😭 Perhaps we need to differentiate between which errors are `WARN` and which should be `FATAL`? I think there might be some code for this already lying around. It might be possible to match on the type with `errors.Is`, otherwise, using a string comparison (🙈). I'm also not sure. Seems like we're running up against several issues with having overview of the process of release and publishing with recipes and the catalogue. I keep coming back to thinking about how we can make a holistic plan for in [this project](https://git.coopcloud.tech/toolshed/-/projects/31) but there are other hills to die on atm...

decentral1se added the bug label 2025-08-13 11:42:47 +00:00

decentral1se added this to the (deleted) project 2025-08-25 10:55:42 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#594