feat!: add metadata to Tag object and update Parse(), Equals() and String() #7

knoflook · 2021-10-07T10:28:10Z

knoflook commented

2021-10-07 10:28:10 +00:00

now we can parse tags such as
1.3.1+5.9.6-alpine
this will parse to

type Tag struct {
	Major        "1"
	Minor        "3"
	MissingMinor false
	Patch        "1" 
	MissingPatch false 
	Suffix       ""
	UsesV        false
	Metadata     "5.9.6-alpine"
}

it's parsed according to semver specification, so -alpine isn't split from the rest

<valid semver> ::= <version core>
                 | <version core> "-" <pre-release>
                 | <version core> "+" <build>
                 | <version core> "-" <pre-release> "+" <build>

but if we have 2.0.0-rc1+6.0.2-alpine it should be parsed to:

type Tag struct {
	Major        "2"
	Minor        "0"
	MissingMinor false
	Patch        "0" 
	MissingPatch false 
	Suffix       "rc1"
	UsesV        false
	Metadata     "6.0.2-alpine"
}

now we can parse tags such as `1.3.1+5.9.6-alpine` this will parse to ``` type Tag struct { Major "1" Minor "3" MissingMinor false Patch "1" MissingPatch false Suffix "" UsesV false Metadata "5.9.6-alpine" } ``` it's parsed according to semver specification, so `-alpine` isn't split from the rest ``` <valid semver> ::= <version core> | <version core> "-" <pre-release> | <version core> "+" <build> | <version core> "-" <pre-release> "+" <build> ``` but if we have `2.0.0-rc1+6.0.2-alpine` it should be parsed to: ``` type Tag struct { Major "2" Minor "0" MissingMinor false Patch "0" MissingPatch false Suffix "rc1" UsesV false Metadata "6.0.2-alpine" } ```

knoflook added 1 commit 2021-10-07 10:28:11 +00:00

continuous-integration/drone/pr Build is passing Details

63ec2c5ff3

feat!: add metadata to Tag object and update Parse(), Equals() and String()

knoflook added 1 commit 2021-10-07 12:29:34 +00:00

continuous-integration/drone/pr Build is passing Details

continuous-integration/drone/push Build is passing Details

aa7b4ff851

fix: get patternCounts to recognise tags with metadata correctly

decentral1se commented

2021-10-07 12:34:29 +00:00

Wonderful @knoflook! Would you mind writing a few test for this in the test_... file which should be handy since there are a bunch of examples. Handier to maintain this going forward 🙏

Wonderful @knoflook! Would you mind writing a few test for this in the `test_...` file which should be handy since there are a bunch of examples. Handier to maintain this going forward 🙏

decentral1se merged commit aa7b4ff851 into main

2021-10-07 13:03:38 +00:00

decentral1se referenced this pull request

2021-10-07 13:03:54 +00:00

Tests for #7 #9

Sign in to join this conversation.

No reviewers