coop-cloud/traefik
6
2
Fork 19
Code Issues 14 Pull Requests 7 Releases Wiki Activity

Expose max log retention in traefik.yml #51

Merged
marlon merged 1 commits from sixsmith/traefik:master into master 2025-02-19 22:15:04 +00:00
Conversation 6 Commits 1 Files Changed 3
+4
sixsmith commented 2025-02-19 21:11:35 +00:00
Member
Copy Link
Copy Source

And set the sample maxAge to 1 day.

And set the sample [maxAge](https://doc.traefik.io/traefik/observability/logs/#maxage) to 1 day.
sixsmith added 1 commit 2025-02-19 21:11:35 +00:00
Configure max log retention 7185e6ab43
marlon approved these changes 2025-02-19 22:14:39 +00:00
marlon left a comment
Member
Copy Link
Copy Source

Looks goot to me

Looks goot to me
marlon merged commit 14d5d79520 into master 2025-02-19 22:15:04 +00:00
decentral1se reviewed 2025-02-20 08:30:32 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

@sixsmith @marlon nice one, would you mind handling these comments also? thanks!

Also, does this change any default behaviour for others? This is one of the most central recipes used by all operators, so it's good to clear what is changing.

@sixsmith @marlon nice one, would you mind handling these comments also? thanks! Also, does this change any default behaviour for others? This is one of the most central recipes used by all operators, so it's good to clear what is changing.
.env.sample
@@ -10,6 +10,7 @@ LETS_ENCRYPT_EMAIL=certs@example.com
# DASHBOARD_ENABLED=true
# WARN, INFO etc.
LOG_LEVEL=WARN
LOG_MAX_AGE=1
decentral1se commented 2025-02-20 08:28:49 +00:00
Owner
Copy Link
Copy Source

This has no default set for new operators. So, if they miss adding this to their .env file, they are passing an empty value into the config which might have weird effects. A common approach is to thread a default in on the compose.yml env stanza ala https://git.coopcloud.tech/coop-cloud/gitea/pulls/42/files#diff-31039bcded788fa49a167378a8b1ee509c366f91

This has no default set for new operators. So, if they miss adding this to their `.env` file, they are passing an empty value into the config which might have weird effects. A common approach is to thread a default in on the `compose.yml` `env` stanza ala https://git.coopcloud.tech/coop-cloud/gitea/pulls/42/files#diff-31039bcded788fa49a167378a8b1ee509c366f91
traefik.yml.tmpl
@@ -1,6 +1,8 @@
---
decentral1se commented 2025-02-20 08:29:43 +00:00
Owner
Copy Link
Copy Source

You also need to bump the version of the config or all upgrades will fail:

https://git.coopcloud.tech/coop-cloud/traefik/src/branch/master/abra.sh#L1

You also need to bump the version of the config or all upgrades will fail: https://git.coopcloud.tech/coop-cloud/traefik/src/branch/master/abra.sh#L1
marlon commented 2025-02-20 19:44:50 +00:00
Member
Copy Link
Copy Source

Thanks for the review, I hadn't been thinking about the defaults! fixed those issues in a new commit 👍

Thanks for the review, I hadn't been thinking about the defaults! fixed those issues in a new commit 👍
❤️ 1
p4u1 commented 2025-02-21 17:26:09 +00:00
Owner
Copy Link
Copy Source

Is maxAge introduced in traefik v3? I get the following error: error: field not found, node: maxAge. We might need to revert this change until we update traefik to v3

Is maxAge introduced in traefik v3? I get the following error: `error: field not found, node: maxAge`. We might need to revert this change until we update traefik to v3
marlon commented 2025-02-21 17:29:00 +00:00
Member
Copy Link
Copy Source

Yes, I think you're right. I deleted the release flag for this change and unless @sixsmith has a fix we should probably just revert the change. Or actually just revert until a fix can be researched.

Yes, I think you're right. I deleted the release flag for this change and unless @sixsmith has a fix we should probably just revert the change. Or actually just revert until a fix can be researched.
👍 1
p4u1 commented 2025-02-21 17:36:12 +00:00
Owner
Copy Link
Copy Source

Ok, I will revert it then for now

Ok, I will revert it then for now
🎉 1
Sign in to join this conversation.
Reviewers
No Reviewers
marlon
decentral1se
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) BornDeleuze Brooke carla cas (Cassowary) coopcloud decentral1se (d1) fauno (fauno) javielico (Javielico) jjsfunhouse kawaiipunk (KawaiiPunk) knoflook moosemower moritz notplants oxaliq (sorrel) p4u1 renovate-bot (Comrade Renovate Bot) simon stevensting trav (Trav Fryer) yksflip
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/traefik#51