coop-cloud/traefik
7
2
Fork 19
Code Issues 16 Pull Requests 4 Releases Wiki Activity

versioning mistake when recipe was upgraded to traefik's 3.x branch #57

New Issue
Closed
opened 2025-08-14 09:45:15 +00:00 by knoflook · 6 comments
knoflook commented 2025-08-14 09:45:15 +00:00
Owner
Copy Link
Copy Source

3.3.0+v2.11.26 should've been the last release in the 3.x branch for this recipe, instead the next release was 3.4.0+v3.4.4 - which should've been 4.0.0+v3.4.4. But then we just rolled with it. What is the canonical way of fixing versioning mistakes? Should we double-tag the same commits with the correct versions? traefik v3 has introduced breaking changes to the config files so it's pretty important for our versioning to reflect that. paging @ripclap @sixsmith @marlon @p4u1 as active contributors

`3.3.0+v2.11.26` should've been the last release in the 3.x branch for this recipe, instead the next release was ` 3.4.0+v3.4.4` - which should've been `4.0.0+v3.4.4`. But then we just rolled with it. What is the canonical way of fixing versioning mistakes? Should we double-tag the same commits with the correct versions? traefik v3 has introduced breaking changes to the config files so it's pretty important for our versioning to reflect that. paging @ripclap @sixsmith @marlon @p4u1 as active contributors
p4u1 commented 2025-08-14 10:25:19 +00:00
Owner
Copy Link
Copy Source

Oh, i thought we found a way to make it backwards compatible for us?

Oh, i thought we found a way to make it backwards compatible for us?
👍 1
decentral1se commented 2025-08-16 07:17:15 +00:00
Owner
Copy Link
Copy Source

oh, which breaking changes did you run into @knoflook? i saw none on the upgrade...

i understood this was the backwards compat change:

traefik/traefik.yml.tmpl Lines 2 to 3 in a3ab012d55
core:
defaultRuleSyntax: v2

oh, which breaking changes did you run into @knoflook? i saw none on the upgrade... i understood this was the backwards compat change: https://git.coopcloud.tech/coop-cloud/traefik/src/commit/a3ab012d55b6397030fc5e605a434db07de4ee44/traefik.yml.tmpl#L2-L3
👍 1
knoflook commented 2025-08-16 10:40:30 +00:00
Author
Owner
Copy Link
Copy Source

oh ur right this is not a breaking change 🤦 but we should've still bumped our version to follow upstream versioning no? https://docs.coopcloud.tech/maintainers/handbook/#how-are-recipes-versioned

oh ur right this is not a breaking change 🤦 but we should've still bumped our version to follow upstream versioning no? https://docs.coopcloud.tech/maintainers/handbook/#how-are-recipes-versioned
decentral1se commented 2025-08-16 13:41:59 +00:00
Owner
Copy Link
Copy Source

uhm not sure which version you mean specifically? afaict our version follows upstream? https://git.coopcloud.tech/coop-cloud/traefik/tags. there have been releases in the meantime, so things got bumped further.

uhm not sure which version you mean specifically? afaict our version follows upstream? https://git.coopcloud.tech/coop-cloud/traefik/tags. there have been releases in the meantime, so things got bumped further.
knoflook commented 2025-08-19 12:28:23 +00:00
Author
Owner
Copy Link
Copy Source

I mean we're going from traefik 2.x to traefik 3.x and usually that is enough to increase the version number in the co-op cloud recipe but it didn't happen this time

I mean we're going from traefik 2.x to traefik 3.x and usually that is enough to increase the version number in the co-op cloud recipe but it didn't happen this time
decentral1se commented 2025-08-19 16:28:50 +00:00
Owner
Copy Link
Copy Source

Usually bumping 2.x to 3.x causes backwards incompatible changes but this time it didnt!

See more on reasoning here: #54

Shall we close this?

Usually bumping 2.x to 3.x causes backwards incompatible changes but this time it didnt! See more on reasoning here: https://git.coopcloud.tech/coop-cloud/traefik/pulls/54 Shall we close this?
👍 2
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) BornDeleuze (Born Deleuze) Brooke carla cas (Cassowary) coopcloud dannygroenewegen (Danny Groenewegen) decentral1se (d1) devydave fauno (fauno) hex (Josh Dukes) javielico (Javielico) jjsfunhouse kawaiipunk (KawaiiPunk) knoflook moosemower moritz notplants oxaliq (sorrel) p4u1 (p4u1) renovate-bot (Comrade Renovate Bot) simon stevensting (stevensting) trav (Trav Fryer) yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/traefik#57