coop-cloud/traefik
6
1
Fork 12
Code Issues 9 Pull Requests Releases Wiki Activity

versioning mistake when recipe was upgraded to traefik's 3.x branch #57

New Issue
Closed
opened 2025-08-14 09:45:15 +00:00 by knoflook · 6 comments
knoflook commented 2025-08-14 09:45:15 +00:00
Owner
Copy Link

3.3.0+v2.11.26 should've been the last release in the 3.x branch for this recipe, instead the next release was 3.4.0+v3.4.4 - which should've been 4.0.0+v3.4.4. But then we just rolled with it. What is the canonical way of fixing versioning mistakes? Should we double-tag the same commits with the correct versions? traefik v3 has introduced breaking changes to the config files so it's pretty important for our versioning to reflect that. paging @ripclap @sixsmith @marlon @p4u1 as active contributors

`3.3.0+v2.11.26` should've been the last release in the 3.x branch for this recipe, instead the next release was ` 3.4.0+v3.4.4` - which should've been `4.0.0+v3.4.4`. But then we just rolled with it. What is the canonical way of fixing versioning mistakes? Should we double-tag the same commits with the correct versions? traefik v3 has introduced breaking changes to the config files so it's pretty important for our versioning to reflect that. paging @ripclap @sixsmith @marlon @p4u1 as active contributors
p4u1 commented 2025-08-14 10:25:19 +00:00
Owner
Copy Link

Oh, i thought we found a way to make it backwards compatible for us?

Oh, i thought we found a way to make it backwards compatible for us?
👍 1
decentral1se commented 2025-08-16 07:17:15 +00:00
Owner
Copy Link

oh, which breaking changes did you run into @knoflook? i saw none on the upgrade...

i understood this was the backwards compat change:

traefik.yml.tmpl Lines 2 to 3 in a3ab012d55
core:
defaultRuleSyntax: v2

oh, which breaking changes did you run into @knoflook? i saw none on the upgrade... i understood this was the backwards compat change: https://git.coopcloud.tech/coop-cloud/traefik/src/commit/a3ab012d55b6397030fc5e605a434db07de4ee44/traefik.yml.tmpl#L2-L3
👍 1
knoflook commented 2025-08-16 10:40:30 +00:00
Author
Owner
Copy Link

oh ur right this is not a breaking change 🤦 but we should've still bumped our version to follow upstream versioning no? https://docs.coopcloud.tech/maintainers/handbook/#how-are-recipes-versioned

oh ur right this is not a breaking change 🤦 but we should've still bumped our version to follow upstream versioning no? https://docs.coopcloud.tech/maintainers/handbook/#how-are-recipes-versioned
decentral1se commented 2025-08-16 13:41:59 +00:00
Owner
Copy Link

uhm not sure which version you mean specifically? afaict our version follows upstream? https://git.coopcloud.tech/coop-cloud/traefik/tags. there have been releases in the meantime, so things got bumped further.

uhm not sure which version you mean specifically? afaict our version follows upstream? https://git.coopcloud.tech/coop-cloud/traefik/tags. there have been releases in the meantime, so things got bumped further.
knoflook commented 2025-08-19 12:28:23 +00:00
Author
Owner
Copy Link

I mean we're going from traefik 2.x to traefik 3.x and usually that is enough to increase the version number in the co-op cloud recipe but it didn't happen this time

I mean we're going from traefik 2.x to traefik 3.x and usually that is enough to increase the version number in the co-op cloud recipe but it didn't happen this time
decentral1se commented 2025-08-19 16:28:50 +00:00
Owner
Copy Link

Usually bumping 2.x to 3.x causes backwards incompatible changes but this time it didnt!

See more on reasoning here: #54

Shall we close this?

Usually bumping 2.x to 3.x causes backwards incompatible changes but this time it didnt! See more on reasoning here: https://git.coopcloud.tech/coop-cloud/traefik/pulls/54 Shall we close this?
👍 2
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se fauno flancian Frando iexos javielico jmakdah2 kawaiipunk knoflook kolaente lambdabundesverband marlon mayel mirsal moritz nicksellen notplants p4u1 pau renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/traefik#57
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?