coop-cloud/traefik
6
2
Fork 19
Code Issues 14 Pull Requests 7 Releases Wiki Activity

Add support for porkbun #91

Merged
decentral1se merged 2 commits from moosemower/traefik:porkbun into master 2026-02-17 08:56:08 +00:00
Conversation 6 Commits 2 Files Changed 3
+35 -4
moosemower commented 2026-02-16 02:01:06 +00:00
Owner
Copy Link
Copy Source

This is my first coopcloud PR, lmk if there is something glaring :)

* [x] I have deployed and tested my changes LetsEncrypt challenges pass successfully, wildcard cert retrieved * [x] I have [updated relevant versions in `abra.sh`](https://docs.coopcloud.tech/maintainers/upgrade/#updating-versions-in-the-abrash) No relevant versions to update * [x] I have made my environment variable changes [backwards compatible](https://docs.coopcloud.tech/maintainers/upgrade/#backwards-compatible-environment-variable-changes) Only added new env vars * [ ] I have added a [release note entry](https://docs.coopcloud.tech/maintainers/upgrade/#creating-new-release-notes) The guide does not say how to do this This is my first coopcloud PR, lmk if there is something glaring :)
moosemower added 1 commit 2026-02-16 02:01:07 +00:00
Add support for porkbun
continuous-integration/drone/pr Build is failing
Details
1d2de06d5c
moosemower requested review from ammaratef45 2026-02-16 02:01:26 +00:00
ammaratef45 reviewed 2026-02-16 08:02:07 +00:00
compose.porkbun.yml Outdated
@@ -0,0 +6,4 @@
- PORKBUN_API_KEY_FILE=/run/secrets/porkbun_api_key
- PORKBUN_SECRET_API_KEY_FILE=/run/secrets/porkbun_secret_api_key
- LETS_ENCRYPT_DNS_CHALLENGE_ENABLED
- LETS_ENCRYPT_DNS_CHALLENGE_PROVIDER
ammaratef45 commented 2026-02-16 08:02:07 +00:00
Owner
Copy Link
Copy Source

is this supposed to be ovh or something else? (when uncommented from the env file)

is this supposed to be ovh or something else? (when uncommented from the env file)
moosemower commented 2026-02-16 22:01:05 +00:00
Author
Owner
Copy Link
Copy Source

Ah, I think the LETS_ENCRYPT_DNS_CHALLENGE_* env vars are not needed here actually.

, yes, when using the .env.sample, the way to use porkbun is to

  1. uncomment these two env vars, and put in porkbun in the _PROVIDER var
  2. fill in the porkbun api key, and include the compose.porkbun.yml file

similar to ovh, azure, digitalocean etc.

I copied compose.porkbun.yml from compose.digitalocean.yml which does provide these env vars in the services.app.environment section, but I'm not sure what effect that has. So I'll remove them, to be consistent at least with the ovh compose file.

Ah, I think the LETS_ENCRYPT_DNS_CHALLENGE_* env vars are not needed here actually. , yes, when using the .env.sample, the way to use porkbun is to 1. uncomment these two env vars, and put in `porkbun` in the _PROVIDER var 2. fill in the porkbun api key, and include the compose.porkbun.yml file similar to ovh, azure, digitalocean etc. I copied `compose.porkbun.yml` from `compose.digitalocean.yml` which _does_ provide these env vars in the services.app.environment section, but I'm not sure what effect that has. So I'll remove them, to be consistent at least with the ovh compose file.
decentral1se marked this conversation as resolved
ammaratef45 approved these changes 2026-02-16 08:03:25 +00:00
ammaratef45 left a comment
Owner
Copy Link
Copy Source

lgtm but I would wait for the recipe maintainers to take a look before merging

lgtm but I would wait for the recipe maintainers to take a look before merging
decentral1se reviewed 2026-02-16 15:06:52 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

Looking good @moosemower, thanks for the work! And welcome!

Looking good @moosemower, thanks for the work! And welcome!
compose.porkbun.yml Outdated
@@ -0,0 +13,4 @@
secrets:
porkbun_api_key:
name: ${STACK_NAME}_porkbun_api_key_${SECRET_PORKBUN_API_KEY_VERSION}
decentral1se commented 2026-02-16 15:06:25 +00:00
Owner
Copy Link
Copy Source

The only thing I'd worry about here is 👇

https://docs.coopcloud.tech/maintainers/handbook/#r015-long-secret-names

The only thing I'd worry about here is 👇 > https://docs.coopcloud.tech/maintainers/handbook/#r015-long-secret-names
moosemower commented 2026-02-16 22:54:38 +00:00
Author
Owner
Copy Link
Copy Source

ah, noted. Renamed secrets to be `pb_(s_)?_api

image.png

tested, redeployed with the new secret names and letdebug.net shows green

ah, noted. Renamed secrets to be `pb_(s_)?_api ![image.png](/attachments/ffda5533-0d19-4756-9833-fc9c6ca2c10f) tested, redeployed with the new secret names and letdebug.net shows green
image.png
46 KiB
decentral1se marked this conversation as resolved
moosemower force-pushed porkbun from 1d2de06d5c to 39a83bc125 2026-02-16 22:45:28 +00:00 Compare
moosemower force-pushed porkbun from 39a83bc125 to c6bfe41c94 2026-02-16 22:55:16 +00:00 Compare
decentral1se approved these changes 2026-02-16 23:02:47 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

LGTM!

LGTM!
decentral1se requested review from p4u1 2026-02-16 23:02:55 +00:00
p4u1 reviewed 2026-02-16 23:17:35 +00:00
.env.sample Outdated
@@ -77,2 +77,4 @@
#SECRET_AZURE_SECRET_VERSION=v1
## Porkbun, https://porkbun.com
## To insert your secrets:
p4u1 commented 2026-02-16 23:17:35 +00:00
Owner
Copy Link
Copy Source

Can you add a section to the README.md about how to integrate porkbun.com? You could then document there how go insert the secrets

Can you add a section to the README.md about how to integrate porkbun.com? You could then document there how go insert the secrets
moosemower commented 2026-02-16 23:38:50 +00:00
Author
Owner
Copy Link
Copy Source

i opted to re-use the existing instructions for how to integrate with providers, and made it a bit clearer how setting LETS_ENCRYPT_DNS_CHALLENGE_PROVIDER works, Hope that addresses the concern :)

i opted to re-use the existing instructions for how to integrate with providers, and made it a bit clearer how setting LETS_ENCRYPT_DNS_CHALLENGE_PROVIDER works, Hope that addresses the concern :)
decentral1se marked this conversation as resolved
moosemower added 1 commit 2026-02-16 23:37:10 +00:00
slightly improve DNS provider integration docs
continuous-integration/drone/pr Build is failing
Details
4e7ed0fcee
p4u1 approved these changes 2026-02-17 07:01:19 +00:00
decentral1se merged commit d164d2870e into master 2026-02-17 08:56:08 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
ammaratef45
decentral1se
p4u1
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) BornDeleuze Brooke carla cas (Cassowary) coopcloud decentral1se (d1) fauno (fauno) javielico (Javielico) jjsfunhouse kawaiipunk (KawaiiPunk) knoflook moosemower moritz notplants oxaliq (sorrel) p4u1 renovate-bot (Comrade Renovate Bot) simon stevensting trav (Trav Fryer) yksflip
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/traefik#91