coop-cloud/traefik
coop-cloud/traefik
6
1
Fork 11
Code Issues 8 Pull Requests Releases Wiki Activity

Expose max log retention in traefik.yml #51

Merged
marlon merged 1 commits from sixsmith/traefik:master into master 2025-02-19 22:15:04 +00:00
Conversation 6 Commits 1 Files Changed 3 +4
3 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.env.sample
View File

@ -10,6 +10,7 @@ LETS_ENCRYPT_EMAIL=certs@example.com
# DASHBOARD_ENABLED=true # DASHBOARD_ENABLED=true
# WARN, INFO etc. # WARN, INFO etc.
LOG_LEVEL=WARN LOG_LEVEL=WARN
LOG_MAX_AGE=1
decentral1se commented 2025-02-20 08:28:49 +00:00
Review
Copy Link

This has no default set for new operators. So, if they miss adding this to their .env file, they are passing an empty value into the config which might have weird effects. A common approach is to thread a default in on the compose.yml env stanza ala https://git.coopcloud.tech/coop-cloud/gitea/pulls/42/files#diff-31039bcded788fa49a167378a8b1ee509c366f91

This has no default set for new operators. So, if they miss adding this to their `.env` file, they are passing an empty value into the config which might have weird effects. A common approach is to thread a default in on the `compose.yml` `env` stanza ala https://git.coopcloud.tech/coop-cloud/gitea/pulls/42/files#diff-31039bcded788fa49a167378a8b1ee509c366f91
# This is here so later lines can extend it; you likely don't wanna edit # This is here so later lines can extend it; you likely don't wanna edit
COMPOSE_FILE="compose.yml" COMPOSE_FILE="compose.yml"

1
compose.yml
View File

@ -27,6 +27,7 @@ services:
environment: environment:
- DASHBOARD_ENABLED - DASHBOARD_ENABLED
- LOG_LEVEL - LOG_LEVEL
- LOG_MAX_AGE
healthcheck: healthcheck:
test: ["CMD", "traefik", "healthcheck"] test: ["CMD", "traefik", "healthcheck"]
interval: 30s interval: 30s

2
traefik.yml.tmpl
View File

@ -1,6 +1,8 @@
--- ---
decentral1se commented 2025-02-20 08:29:43 +00:00
Review
Copy Link

You also need to bump the version of the config or all upgrades will fail:

https://git.coopcloud.tech/coop-cloud/traefik/src/branch/master/abra.sh#L1

You also need to bump the version of the config or all upgrades will fail: https://git.coopcloud.tech/coop-cloud/traefik/src/branch/master/abra.sh#L1
log: log:
level: {{ env "LOG_LEVEL" }} level: {{ env "LOG_LEVEL" }}
maxAge: {{ env "LOG_MAX_AGE" }}
providers: providers:
docker: docker: