coop-cloud/vaultwarden
2
1
Fork 4
Code Issues 2 Pull Requests 1 Projects Releases Wiki Activity

fix: set umask closes #6 #7

Merged
fauno merged 2 commits from issue-6 into main 2025-04-23 19:21:17 +00:00
Conversation 7 Commits 2 Files Changed 2
+5 -1
fauno commented 2025-03-31 18:46:11 +00:00
Owner
Copy Link
Copy Source
No description provided.
❤️ 1
fauno added 1 commit 2025-03-31 18:46:12 +00:00
fix: set umask closes #6 938e4671b4
fauno added spent time 5 minutes 2025-03-31 18:46:32 +00:00
fauno commented 2025-03-31 18:47:34 +00:00
Author
Owner
Copy Link
Copy Source

the umask prevents volume files to be world-readable

before:

sutty:/var/lib/docker/volumes# ls vaultwarden_sutty_comun_vaultwarden_data/_data/ -hal
total 284K                                                          
drwxr-xr-x 1 root root  186 Mar 31 18:41 .             
drwx-----x 1 root root   10 Mar 31 18:41 ..        
drwxr-xr-x 1 root root    0 Mar 31 18:41 attachments
-rw-r--r-- 1 root root 244K Mar 31 18:41 db.sqlite3
-rw-r--r-- 1 root root  32K Mar 31 18:41 db.sqlite3-shm
-rw-r--r-- 1 root root    0 Mar 31 18:41 db.sqlite3-wal 
drwxr-xr-x 1 root root    0 Mar 31 18:41 icon_cache                                                                                     
-rw-r--r-- 1 root root 1.7K Mar 31 18:41 rsa_key.pem
drwxr-xr-x 1 root root    0 Mar 31 18:41 sends
drwxr-xr-x 1 root root    0 Mar 31 18:41 tmp
-rw-r--r-- 1 root root    0 Mar 31 18:41 vaultwarden.log

after:

sutty:/var/lib/docker/volumes# ls vaultwarden_sutty_comun_vaultwarden_data/_data/ -hal
total 284K
drwxr-xr-x 1 root root  186 Mar 31 18:44 .
drwx-----x 1 root root   10 Mar 31 18:44 ..
drwxr-x--- 1 root root    0 Mar 31 18:44 attachments
-rw-r----- 1 root root 244K Mar 31 18:44 db.sqlite3
-rw-r----- 1 root root  32K Mar 31 18:44 db.sqlite3-shm
-rw-r----- 1 root root    0 Mar 31 18:44 db.sqlite3-wal
drwxr-x--- 1 root root    0 Mar 31 18:44 icon_cache
-rw-r----- 1 root root 1.7K Mar 31 18:44 rsa_key.pem
drwxr-x--- 1 root root    0 Mar 31 18:44 sends
drwxr-x--- 1 root root    0 Mar 31 18:44 tmp
-rw-r----- 1 root root    0 Mar 31 18:44 vaultwarden.log
the umask prevents volume files to be world-readable before: ``` sutty:/var/lib/docker/volumes# ls vaultwarden_sutty_comun_vaultwarden_data/_data/ -hal total 284K drwxr-xr-x 1 root root 186 Mar 31 18:41 . drwx-----x 1 root root 10 Mar 31 18:41 .. drwxr-xr-x 1 root root 0 Mar 31 18:41 attachments -rw-r--r-- 1 root root 244K Mar 31 18:41 db.sqlite3 -rw-r--r-- 1 root root 32K Mar 31 18:41 db.sqlite3-shm -rw-r--r-- 1 root root 0 Mar 31 18:41 db.sqlite3-wal drwxr-xr-x 1 root root 0 Mar 31 18:41 icon_cache -rw-r--r-- 1 root root 1.7K Mar 31 18:41 rsa_key.pem drwxr-xr-x 1 root root 0 Mar 31 18:41 sends drwxr-xr-x 1 root root 0 Mar 31 18:41 tmp -rw-r--r-- 1 root root 0 Mar 31 18:41 vaultwarden.log ``` after: ``` sutty:/var/lib/docker/volumes# ls vaultwarden_sutty_comun_vaultwarden_data/_data/ -hal total 284K drwxr-xr-x 1 root root 186 Mar 31 18:44 . drwx-----x 1 root root 10 Mar 31 18:44 .. drwxr-x--- 1 root root 0 Mar 31 18:44 attachments -rw-r----- 1 root root 244K Mar 31 18:44 db.sqlite3 -rw-r----- 1 root root 32K Mar 31 18:44 db.sqlite3-shm -rw-r----- 1 root root 0 Mar 31 18:44 db.sqlite3-wal drwxr-x--- 1 root root 0 Mar 31 18:44 icon_cache -rw-r----- 1 root root 1.7K Mar 31 18:44 rsa_key.pem drwxr-x--- 1 root root 0 Mar 31 18:44 sends drwxr-x--- 1 root root 0 Mar 31 18:44 tmp -rw-r----- 1 root root 0 Mar 31 18:44 vaultwarden.log ```
fauno commented 2025-03-31 18:48:22 +00:00
Author
Owner
Copy Link
Copy Source

i don't know how to provide a migration, running a chmod on the entrypoint would be ok?

i don't know how to provide a migration, running a chmod on the entrypoint would be ok?
👍 1
fauno added spent time 3 minutes 2025-03-31 18:49:07 +00:00
decentral1se reviewed 2025-03-31 21:41:53 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

Epic! Yeh, add a note about the migration step and keep moving?

Epic! Yeh, add a note about the migration step and keep moving?
fauno added 1 commit 2025-04-03 20:07:07 +00:00
fix: remove world access to existing data cab11b0e2a
fauno commented 2025-04-03 20:07:15 +00:00
Author
Owner
Copy Link
Copy Source

i don't know how to provide a migration, running a chmod on the entrypoint would be ok?

i did this

> i don't know how to provide a migration, running a chmod on the entrypoint would be ok? i did this
👍 1
decentral1se approved these changes 2025-04-05 05:45:09 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

LGTM

Do you also want to add a release note to signal what's going on for upgraders?

LGTM Do you also want to add a release note to signal what's going on for upgraders?
fauno commented 2025-04-05 16:32:30 +00:00
Author
Owner
Copy Link
Copy Source

Do you also want to add a release note to signal what's going on for upgraders?

this is done after merging to main right?

> Do you also want to add a release note to signal what's going on for upgraders? this is done after merging to main right?
decentral1se commented 2025-04-05 20:11:12 +00:00
Owner
Copy Link
Copy Source

@fauno up to you! we fixed a bug in RC2 of abra that you can do it whenever now 🙃

(Feel free to merge anyway!)

@fauno up to you! we fixed a bug in RC2 of `abra` that you can do it whenever now 🙃 (Feel free to merge anyway!)
fauno merged commit 0c8a4ddc50 into main 2025-04-23 19:21:17 +00:00
fauno deleted branch issue-6 2025-04-23 19:21:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm appletalk arjan basebuilder BornDeleuze Brooke carla cas (Cassowary) codegod100 coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) flancian Frando iexos jade (Jade Ambrose) javielico (Javielico) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) marlon (marlon) mayel mirsal moosemower moritz nicksellen (Nick Sellen) notplants oxaliq (sorrel) p4u1 pau pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) PhiNatalie renovate-bot (Comrade Renovate Bot) ripclap rix rscmbbng sef (sef) simon sixsmith (Sixsmith) stevensting tobias trav (Trav Fryer) val (val (he/him)) vaznasty virtualboys wolcen (Chris Thompson) wykwit xynosis yksflip
No Assignees
2 Participants
Notifications
Total Time Spent: 8 minutes
fauno
8 minutes
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/vaultwarden#7