coop-cloud/vaultwarden
coop-cloud/vaultwarden
2
0
Fork 4
Code Issues 1 Pull Requests Projects Releases 1 Wiki Activity

fix: don't enable SMTP by default #9

Merged
decentral1se merged 1 commits from smtp-not-enabled-by-default into main 2025-04-24 08:11:44 +00:00
Conversation 3 Commits 1 Files Changed 5 +21 -1
decentral1se commented 2025-04-22 21:49:41 +00:00
Owner
Copy Link

See #8.

Otherwise, deployments are currently forced to configure SMTP even if they don't include compose.smtp.yml.

https://github.com/dani-garcia/vaultwarden/discussions/4866

See https://git.coopcloud.tech/coop-cloud/vaultwarden/issues/8. Otherwise, deployments are currently forced to configure SMTP even if they don't include `compose.smtp.yml`. https://github.com/dani-garcia/vaultwarden/discussions/4866
decentral1se added 1 commit 2025-04-22 21:49:41 +00:00 
See #8
decentral1se force-pushed smtp-not-enabled-by-default from 01fdacae52 to 84c88473d9 2025-04-22 22:14:09 +00:00 Compare
fauno commented 2025-04-23 19:20:47 +00:00
Owner
Copy Link

👍

👍
fauno reviewed 2025-04-23 19:25:46 +00:00
release/1.2.0+1.33.2 Outdated
@ -0,0 +1 @@
Please add `SMTP_ENABLED=1` to your .env if you're using SMTP.
fauno commented 2025-04-23 19:25:46 +00:00
Owner
Copy Link

when you merge, and before tagging, could you add something like this to the release note?

Previously, the data directory including the main private key had read permissions enabled for all host users. This release fixes that. Please review your Vaultwarden keys if other users on your Coopcloud host may have had access to these files.
when you merge, and before tagging, could you add something like this to the release note? ``` Previously, the data directory including the main private key had read permissions enabled for all host users. This release fixes that. Please review your Vaultwarden keys if other users on your Coopcloud host may have had access to these files. ```
👍 1
decentral1se marked this conversation as resolved
decentral1se commented 2025-04-24 06:36:21 +00:00
Author
Owner
Copy Link

In the spirit of coop-cloud/wallabag#4 (comment) I think this should probably be a major release. People using SMTP will have to add this env var or else their SMTP setup will be disabled 😱 I'll fix this PR up and add the release note also, thanks @fauno.

In the spirit of https://git.coopcloud.tech/coop-cloud/wallabag/pulls/4#issuecomment-24072 I think this should probably be a major release. People using SMTP will have to add this env var or else their SMTP setup will be disabled 😱 I'll fix this PR up and add the release note also, thanks @fauno.
decentral1se force-pushed smtp-not-enabled-by-default from 84c88473d9 to 426c0c026f 2025-04-24 07:50:57 +00:00 Compare
decentral1se merged commit 681d84009e into main 2025-04-24 08:11:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud decentral1se fauno flancian Frando iexos javielico kawaiipunk knoflook lambdabundesverband mac-chaffee marlon mayel mirsal moritz nicksellen notplants p4u1 pau renovate-bot rix sef simon stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/vaultwarden#9
No description provided.
Delete Branch "smtp-not-enabled-by-default"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?