Multisite with sufolders #35

2023-11-08T17:09:13Z

p4u1 commented

2023-11-08 17:09:13 +00:00

Hi,
this adds two commits:

The first commit adds a new template for the .htaccess which gets controlled by a new MULTISITE environment variable (either subdomain or subfolder). The content of the .htaccess is taken from the wordpress documentation.

The second commit simpifies the multisite deployment by adding a new value enable to the MULTISITE environment variable. Depending on its value WORDPRESS_CONFIG_EXTRA gets set in the entrypoint.

Closes #34

I am still new to coopcloud and welcome feedback on my approach. The second commit is not required for #34 so I can remove it again.

Hi, this adds two commits: The first commit adds a new template for the `.htaccess` which gets controlled by a new `MULTISITE` environment variable (either `subdomain` or `subfolder`). The content of the `.htaccess` is taken from [the wordpress documentation](https://wordpress.org/documentation/article/htaccess/). The second commit simpifies the multisite deployment by adding a new value `enable` to the `MULTISITE` environment variable. Depending on its value `WORDPRESS_CONFIG_EXTRA` gets set in the entrypoint. Closes #34 I am still new to coopcloud and welcome feedback on my approach. The second commit is not required for #34 so I can remove it again.

p4u1 added 2 commits 2023-11-08 17:09:14 +00:00

introduce MULTISITE env variable to change .htaccess ef65157cbf

use one env variable to controll the multisite feature

continuous-integration/drone/pr Build encountered an error

Details

4c64892354

p4u1 closed this pull request

2023-11-22 15:57:03 +00:00

p4u1 reopened this pull request

2023-11-22 15:57:08 +00:00

decentral1se requested review from 3wordchant 2023-11-27 10:31:08 +00:00

decentral1se requested review from aadil 2023-11-27 10:31:08 +00:00

3wordchant commented

2023-12-02 15:33:16 +00:00

Sorry not to have had time to look at this yet @p4u1, will do ASAP – but also happy to optimistically merge, if you wouldn't mind adding a release note about the required settings change? Otherwise I can do that when I review.

Sorry not to have had time to look at this yet @p4u1, will do ASAP – but also happy to optimistically merge, if you wouldn't mind adding a `release` note about the required settings change? Otherwise I can do that when I review.

p4u1 added 1 commit 2023-12-04 08:41:38 +00:00

add release note

continuous-integration/drone/pr Build is failing

Details

d278f885e6

p4u1 commented

2023-12-04 08:43:18 +00:00

@3wordchant I added a release note (was my first release not, so not sure if I did this correctly). And I don't mind waiting some more for you to review it :)

p4u1 force-pushed multisite-htaccess from d278f885e6 to e29109d081

2023-12-15 15:08:44 +00:00

Compare

p4u1 force-pushed multisite-htaccess from e29109d081 to 015c7d6f0c

2023-12-15 15:09:36 +00:00

Compare

p4u1 merged commit 1a6b11c95b into master

2023-12-22 12:35:10 +00:00

p4u1 deleted branch multisite-htaccess

2023-12-22 12:35:11 +00:00

p4u1 referenced this issue from a commit

2023-12-22 12:35:11 +00:00

feat: multisite with sufolders (#35)

p4u1 commented

2023-12-22 12:35:34 +00:00

@3wordchant I merged this now :) Hope everything is good.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/wordpress#35

Allow edits from maintainers