Site editor duplicates templates/template-parts on editing them #43
Closed
opened 2024-05-11 16:09:30 +00:00 by aadil
·
5 comments
No Branch/Tag Specified
main
renovate/wordpress-7.x
kc_stable
kc-stable
backup
anubis
fix/3wc/wp-cli
ftp
ssh
service-rename
drone
3.0.6+7.0.4
3.0.5+7.0.4
3.0.4+7.0.3
3.0.3+7.0.2
3.0.2+7.0.2
3.0.1+7.0.2
2.19.4+6.9.4
2.19.3+6.9.4
3.0.0+7.0.0
2.19.2+6.9.4
2.19.1+6.9.4
2.19.0+6.9.4
2.18.0+6.9.1
2.17.1+6.9.0
2.17.0+6.9.0
2.16.2+6.8.3
2.16.1+6.8.1
2.16.0+6.8.1
2.15.0+6.8.0
2.14.0+6.7.2
2.13.3+6.7.1
2.13.2+6.7.1
2.13.1+6.7.1
2.13.0+6.7.1
2.12.2+6.6.2
2.12.1+6.6.1
2.12.0+6.6.1
2.11.0+6.6.0
2.10.0+6.5.5
2.9.1+6.5.3
2.9.0+6.5.2
2.8.0+6.5.0
2.7.3+6.4.3
2.5.2+6.3.0
2.7.2+6.4.2
2.7.1+6.4.2
2.7.0+6.4.2
2.6.3+6.4.2
2.6.1+6.4.0
2.6.0+6.4.0
2.5.1+6.3.0
2.5.0+6.3.0
2.4.3+6.3.0
2.4.2+6.3.0
2.4.1+6.3.0
2.4.0+6.3.0
2.3.0+6.2.0
2.2.1+6.1.1
2.3.3+6.2.2
2.3.2+6.2.0
2.3.1+6.2.0
2.2.0+6.1.1
2.1.0+6.1.1
2.0.1+6.0.1
2.0.0+6.0.0
1.1.2+5.9.3
1.1.1+5.9.2
1.1.0+5.9.0
1.0.2+5.8.3
1.0.1+5.8.2
1.0.0+5.8.1
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
3wordchant
aadil (Aadil Ayub)
abra-bot (Abra Bot)
ammaratef45
amras (Sarma)
Apfelwurm
appletalk
arjan
basebuilder
BornDeleuze
Brooke
carla
cas (Cassowary)
codegod100
coopcloud
cyrnel
decentral1se (d1)
dede
devydave
fauno (fauno)
flancian
Frando
iexos
jade (Jade Ambrose)
javielico (Javielico)
jjsfunhouse
jmakdah2 (Jackie Makdah)
joe-irving (Joe Irving)
kawaiipunk (KawaiiPunk)
knoflook
kolaente
lambdabundesverband
linnealovespie (April)
marlon (marlon)
mayel
mirsal
moosemower
moritz
nicksellen (Nick Sellen)
notplants
oxaliq (sorrel)
p4u1
pau
pharaohgraphy (Andrew 🐦🔥❤️🔥✴️)
PhiNatalie
renovate-bot (Comrade Renovate Bot)
ripclap
rix
rscmbbng
sef (sef)
simon
sixsmith (Sixsmith)
stevensting
tobias
trav (Trav Fryer)
val (val (he/him))
vaznasty
virtualboys
wolcen (Chris Thompson)
wykwit
xynosis
yksflip
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/wordpress#43
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Copied from https://github.com/WordPress/gutenberg/issues/50816. I'm posting this here because I've only experienced this bug on wordpress sites running on co-op cloud (specifically, aadils.computer and autonomic.zone). When I imported the same site into Local, the issue disappeared. It seems to happen independent of what version of WordPress/Gutenberg I'm running.
Description
I've been experiencing this bug for a long time (I think since 6.0?) where editing any template or template part in the site editor causes WordPress to create a new template/template-part of the same name instead of updating the existing one.
This new template (or template-part), containing all modifications, is created under the current WordPress user, and the default one which is actually being used by theme is cleared of all customizations and is what shows up on the front-end.
(See screen recording for context)
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
Video of me breaking the site with a simple edit to the home template:
gutenberg-template-editing-bug.webm
Video of me restoring the home template:
Kooha-2023-05-20-19-04-56.webm
Anyone else seeing this?
Here is the upstream Gutenberg bug @aadil posted https://github.com/WordPress/gutenberg/issues/50816 which they closed due to not being able to replicate.
I found the issues
Look at the permissions on our theme @aadil
Ok I tested it and it fixed it with a chown:
Doesnt' seem to be any issue with our theme repo: https://git.autonomic.zone/autonomic-cooperative/autonomic-block-theme
Could possibly just be something we did. Maybe even keyboard to chair? Unless anyone can recreate, suggest we close @aadil
hmm I think we have to do another patch to https://git.coopcloud.tech/coop-cloud/wordpress/src/branch/main/entrypoint.sh.tmpl
And we
chown -R www-data:www-data /var/www/html/wp-content/uploads/tochown -R www-data:www-data /var/www/html/wp-content/to cover all the files that need to be patched.PR: #60