coop-cloud/wordpress
coop-cloud/wordpress
10
0
Fork 2
Code Issues 10 Pull Requests Releases Wiki Activity

add some more wordpress options for file uploads #44

Merged
stevensting merged 5 commits from stevensting/wordpress:main into main 2024-12-09 14:59:58 +00:00
Conversation 9 Commits 5 Files Changed 5 +17 -5
stevensting commented 2024-08-23 15:33:11 +00:00
Owner
Copy Link
No description provided.
stevensting added 1 commit 2024-08-23 15:33:11 +00:00
add some more wordpress options for file uploads
Some checks failed
continuous-integration/drone/pr Build is failing
Details
73efb584db
stevensting commented 2024-08-23 15:35:01 +00:00
Author
Owner
Copy Link

it was necessary to enhance these settings for importing large existing websites

it was necessary to enhance these settings for importing large existing websites
decentral1se approved these changes 2024-08-25 14:36:03 +00:00
Dismissed
decentral1se left a comment
Owner
Copy Link

Thanks for this! LGTM but I'll wait for some recipe maintainer to weigh in before merging.

Thanks for this! LGTM but I'll wait for some recipe maintainer to weigh in before merging.
p4u1 commented 2024-08-28 07:25:13 +00:00
Owner
Copy Link

It might be worth changing the uploads.ini to uploads.ini.tpl and then adding two env vars: UPLOAD_MAX_SIZE and UPLOAD_MAX_TIME

It might be worth changing the uploads.ini to uploads.ini.tpl and then adding two env vars: UPLOAD_MAX_SIZE and UPLOAD_MAX_TIME
🎉 1
3wordchant commented 2024-11-23 02:12:03 +00:00
Owner
Copy Link

I agree with @p4u1 but I'm also happy merging this to improve the defaults. @p4u1 are you also OK with this being merged?

I agree with @p4u1 but I'm also happy merging this to improve the defaults. @p4u1 are you also OK with this being merged?
stevensting added 1 commit 2024-12-01 12:06:18 +00:00
review findings
Some checks failed
continuous-integration/drone/pr Build is failing
Details
faf7335719
stevensting commented 2024-12-01 12:09:15 +00:00
Author
Owner
Copy Link

@3wordchant @p4u1 Like this?

@3wordchant @p4u1 Like this?
p4u1 commented 2024-12-01 15:38:13 +00:00
Owner
Copy Link

This looks almost good! It would be nice to have default value for both env variables. Otherwise it would be a breaking change

This looks almost good! It would be nice to have default value for both env variables. Otherwise it would be a breaking change
👍 1
stevensting added 1 commit 2024-12-01 17:46:46 +00:00
add default values for env vars
Some checks failed
continuous-integration/drone/pr Build is failing
Details
1f91caf0fb
decentral1se reviewed 2024-12-02 00:01:45 +00:00
decentral1se left a comment
Owner
Copy Link

Cool! Annnnd, you'll need to update the name in the compose.yml file also:

# ...
php_uploads_conf:
  name: ${STACK_NAME}_php_uploads_conf_${PHP_UPLOADS_CONF_VERSION}
  file: uploads.ini
# ...

Also, it's usually .tmpl, not .tpl, seems like a typo?

Cool! Annnnd, you'll need to update the name in the `compose.yml` file also: ```yaml # ... php_uploads_conf: name: ${STACK_NAME}_php_uploads_conf_${PHP_UPLOADS_CONF_VERSION} file: uploads.ini # ... ``` Also, it's usually `.tmpl`, not `.tpl`, seems like a typo?
👍 1
stevensting added 1 commit 2024-12-02 09:24:23 +00:00
rename template file
Some checks failed
continuous-integration/drone/pr Build is failing
Details
7a03867e2f
stevensting added 1 commit 2024-12-02 09:27:50 +00:00
reflect rename in compose
Some checks failed
continuous-integration/drone/pr Build is failing
Details
0e9997a03e
decentral1se approved these changes 2024-12-02 22:51:53 +00:00
decentral1se left a comment
Owner
Copy Link

🤘

🤘
decentral1se commented 2024-12-02 22:52:33 +00:00
Owner
Copy Link

@stevensting gave you the commit bit, you have read/write on all the repos, welcome welcome 🎉

Click the green button as you see fit!

@stevensting gave you the commit bit, you have read/write on all the repos, welcome welcome 🎉 Click the green button as you see fit!
🎉 1
stevensting merged commit f49fa05ded into main 2024-12-09 14:59:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud decentral1se fauno flancian Frando iexos javielico kawaiipunk knoflook lambdabundesverband mac-chaffee marlon mayel mirsal moritz nicksellen notplants p4u1 pau renovate-bot rix sef simon stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/wordpress#44
No description provided.
Delete Branch "stevensting/wordpress:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?