Issue with auto update option #45

Open
opened 2024-09-04 06:05:08 +00:00 by dwaxweiler · 3 comments

I successfully deployed a WordPress site without changing the default option ENABLE_AUTO_UPDATE=true but WordPress' site health tool displays the errors that the WP_AUTO_UPDATE_CORE constant is defined as false and that WordPress security and maintenance releases are blocked by define( 'WP_AUTO_UPDATE_CORE', false );.

I successfully deployed a WordPress site without changing the default option `ENABLE_AUTO_UPDATE=true` but WordPress' site health tool displays the errors that the `WP_AUTO_UPDATE_CORE` constant is defined as `false` and that WordPress security and maintenance releases are blocked by `define( 'WP_AUTO_UPDATE_CORE', false );`.
Owner

@dwaxweiler hey 👋 (and welcome? 🎉) I believe the ENABLE_AUTO_UPDATE=true is not related to define( 'WP_AUTO_UPDATE_CORE', false );. The ENABLE_AUTO_UPDATE deals with kadabra, our prototype auto-upgrade tool: https://docs.coopcloud.tech/operators/tutorial/#automatic-upgrades

So, I maybe you need to look at another env var (maybe one of the recipe maintainers will know?) or you need to adjust the recipe to be able to configure this value.

@dwaxweiler hey 👋 (and welcome? 🎉) I believe the `ENABLE_AUTO_UPDATE=true` is not related to `define( 'WP_AUTO_UPDATE_CORE', false );`. The `ENABLE_AUTO_UPDATE` deals with `kadabra`, our prototype auto-upgrade tool: https://docs.coopcloud.tech/operators/tutorial/#automatic-upgrades So, I maybe you need to look at another env var (maybe one of the recipe maintainers will know?) or you need to adjust the recipe to be able to configure this value.
Author

Ah, thanks for your clarification! Then, this recipe sets WP_AUTO_UPDATE_CORE to false. Could you set it to minor or expose it via the config file please? In the past, WordPress fixed important vulnerabilities using this automatic update process.

Ah, thanks for your clarification! Then, this recipe sets `WP_AUTO_UPDATE_CORE` to `false`. Could you set it to `minor` or expose it via the config file please? In the past, WordPress fixed important vulnerabilities using this automatic update process.
Owner

@dwaxweiler thanks for the report (and likewise, welcome!).

I have mixed feelings about apps self-updating; I assume the reason that @moritz set WP_AUTO_UPDATE_CORE=false (back in 55f00a4) was that it's confusing if the version reported by abra is different to the actual version running – and the version will be (probably-unexpectedly) reset after an undeploy / deploy – and I would agree with that rationale.

I think project-wide the expectation is that folks will be staying on top of recipe updates by e.g. configuring renovate, or running abra app ls -S periodically. Otherwise, folks might be getting Wordpress security updates but missing out on security updates for other apps they're running (including, at minimum, Traefik or Caddy).

All of that said, I would support making this configurable, as long as the default remains false. I can make this change myself eventually, but very happy for you to make a pull request if you're able.

@dwaxweiler thanks for the report (and likewise, welcome!). I have mixed feelings about apps self-updating; I assume the reason that @moritz set `WP_AUTO_UPDATE_CORE=false` (back in 55f00a4) was that it's confusing if the version reported by `abra` is different to the actual version running – and the version will be (probably-unexpectedly) reset after an `undeploy` / `deploy` – and I would agree with that rationale. I think project-wide the expectation is that folks will be staying on top of recipe updates by e.g. configuring [`renovate`](https://git.coopcloud.tech/coop-cloud/renovate/), or running `abra app ls -S` periodically. Otherwise, folks might be getting Wordpress security updates but missing out on security updates for other apps they're running (including, at minimum, Traefik or Caddy). All of that said, I would support making this configurable, as long as the default remains `false`. I can make this change myself eventually, but very happy for you to make a pull request if you're able.
Sign in to join this conversation.
No Label
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/wordpress#45
No description provided.