Issue with auto update option #45
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I successfully deployed a WordPress site without changing the default option
ENABLE_AUTO_UPDATE=truebut WordPress' site health tool displays the errors that theWP_AUTO_UPDATE_COREconstant is defined asfalseand that WordPress security and maintenance releases are blocked bydefine( 'WP_AUTO_UPDATE_CORE', false );.@dwaxweiler hey 👋 (and welcome? 🎉) I believe the
ENABLE_AUTO_UPDATE=trueis not related todefine( 'WP_AUTO_UPDATE_CORE', false );. TheENABLE_AUTO_UPDATEdeals withkadabra, our prototype auto-upgrade tool: https://docs.coopcloud.tech/operators/tutorial/#automatic-upgradesSo, I maybe you need to look at another env var (maybe one of the recipe maintainers will know?) or you need to adjust the recipe to be able to configure this value.
Ah, thanks for your clarification! Then, this recipe sets
WP_AUTO_UPDATE_COREtofalse. Could you set it tominoror expose it via the config file please? In the past, WordPress fixed important vulnerabilities using this automatic update process.@dwaxweiler thanks for the report (and likewise, welcome!).
I have mixed feelings about apps self-updating; I assume the reason that @moritz set
WP_AUTO_UPDATE_CORE=false(back in55f00a4) was that it's confusing if the version reported byabrais different to the actual version running – and the version will be (probably-unexpectedly) reset after anundeploy/deploy– and I would agree with that rationale.I think project-wide the expectation is that folks will be staying on top of recipe updates by e.g. configuring
renovate, or runningabra app ls -Speriodically. Otherwise, folks might be getting Wordpress security updates but missing out on security updates for other apps they're running (including, at minimum, Traefik or Caddy).All of that said, I would support making this configurable, as long as the default remains
false. I can make this change myself eventually, but very happy for you to make a pull request if you're able.