Issue with auto update option #45
Open
opened 2024-09-04 06:05:08 +00:00 by dwaxweiler
·
6 comments
No Branch/Tag Specified
main
renovate/wordpress-7.x
kc_stable
kc-stable
backup
anubis
fix/3wc/wp-cli
ftp
ssh
service-rename
drone
3.0.6+7.0.4
3.0.5+7.0.4
3.0.4+7.0.3
3.0.3+7.0.2
3.0.2+7.0.2
3.0.1+7.0.2
2.19.4+6.9.4
2.19.3+6.9.4
3.0.0+7.0.0
2.19.2+6.9.4
2.19.1+6.9.4
2.19.0+6.9.4
2.18.0+6.9.1
2.17.1+6.9.0
2.17.0+6.9.0
2.16.2+6.8.3
2.16.1+6.8.1
2.16.0+6.8.1
2.15.0+6.8.0
2.14.0+6.7.2
2.13.3+6.7.1
2.13.2+6.7.1
2.13.1+6.7.1
2.13.0+6.7.1
2.12.2+6.6.2
2.12.1+6.6.1
2.12.0+6.6.1
2.11.0+6.6.0
2.10.0+6.5.5
2.9.1+6.5.3
2.9.0+6.5.2
2.8.0+6.5.0
2.7.3+6.4.3
2.5.2+6.3.0
2.7.2+6.4.2
2.7.1+6.4.2
2.7.0+6.4.2
2.6.3+6.4.2
2.6.1+6.4.0
2.6.0+6.4.0
2.5.1+6.3.0
2.5.0+6.3.0
2.4.3+6.3.0
2.4.2+6.3.0
2.4.1+6.3.0
2.4.0+6.3.0
2.3.0+6.2.0
2.2.1+6.1.1
2.3.3+6.2.2
2.3.2+6.2.0
2.3.1+6.2.0
2.2.0+6.1.1
2.1.0+6.1.1
2.0.1+6.0.1
2.0.0+6.0.0
1.1.2+5.9.3
1.1.1+5.9.2
1.1.0+5.9.0
1.0.2+5.8.3
1.0.1+5.8.2
1.0.0+5.8.1
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
3wordchant
aadil (Aadil Ayub)
abra-bot (Abra Bot)
ammaratef45
amras (Sarma)
Apfelwurm
appletalk
arjan
basebuilder
BornDeleuze
Brooke
carla
cas (Cassowary)
codegod100
coopcloud
cyrnel
decentral1se (d1)
dede
devydave
fauno (fauno)
flancian
Frando
iexos
jade (Jade Ambrose)
javielico (Javielico)
jjsfunhouse
jmakdah2 (Jackie Makdah)
joe-irving (Joe Irving)
kawaiipunk (KawaiiPunk)
knoflook
kolaente
lambdabundesverband
linnealovespie (April)
marlon (marlon)
mayel
mirsal
moosemower
moritz
nicksellen (Nick Sellen)
notplants
oxaliq (sorrel)
p4u1
pau
pharaohgraphy (Andrew 🐦🔥❤️🔥✴️)
PhiNatalie
renovate-bot (Comrade Renovate Bot)
ripclap
rix
rscmbbng
sef (sef)
simon
sixsmith (Sixsmith)
stevensting
tobias
trav (Trav Fryer)
val (val (he/him))
vaznasty
virtualboys
wolcen (Chris Thompson)
wykwit
xynosis
yksflip
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/wordpress#45
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
I successfully deployed a WordPress site without changing the default option
ENABLE_AUTO_UPDATE=truebut WordPress' site health tool displays the errors that theWP_AUTO_UPDATE_COREconstant is defined asfalseand that WordPress security and maintenance releases are blocked bydefine( 'WP_AUTO_UPDATE_CORE', false );.@dwaxweiler hey 👋 (and welcome? 🎉) I believe the
ENABLE_AUTO_UPDATE=trueis not related todefine( 'WP_AUTO_UPDATE_CORE', false );. TheENABLE_AUTO_UPDATEdeals withkadabra, our prototype auto-upgrade tool: https://docs.coopcloud.tech/operators/tutorial/#automatic-upgradesSo, I maybe you need to look at another env var (maybe one of the recipe maintainers will know?) or you need to adjust the recipe to be able to configure this value.
Ah, thanks for your clarification! Then, this recipe sets
WP_AUTO_UPDATE_COREtofalse. Could you set it tominoror expose it via the config file please? In the past, WordPress fixed important vulnerabilities using this automatic update process.@dwaxweiler thanks for the report (and likewise, welcome!).
I have mixed feelings about apps self-updating; I assume the reason that @moritz set
WP_AUTO_UPDATE_CORE=false(back in55f00a4) was that it's confusing if the version reported byabrais different to the actual version running – and the version will be (probably-unexpectedly) reset after anundeploy/deploy– and I would agree with that rationale.I think project-wide the expectation is that folks will be staying on top of recipe updates by e.g. configuring
renovate, or runningabra app ls -Speriodically. Otherwise, folks might be getting Wordpress security updates but missing out on security updates for other apps they're running (including, at minimum, Traefik or Caddy).All of that said, I would support making this configurable, as long as the default remains
false. I can make this change myself eventually, but very happy for you to make a pull request if you're able.@dwaxweiler are you still interested in this? If so, does the self managed version meet your needs?
I have an early MVP that is relevant:
bb63db7d2dI'm not really sure it will work thought because of how
wpworks in the container. I might need to modify it a bit.However it doesn't include core updates which I believe should be done using abra in the managed version.
@3wordchant I can totally follow the abra rationale!
@kawaiipunk thanks for adding this self-managed version! After reading the rationale behind, I would only set
WP_AUTO_UPDATE_COREtominorto let WordPress do small updates. Your MVP looks also good because outdated plugins even pose the bigger risk to a WordPress site.