endpoint: add option WithSecretKey #30

digest := sha256.Sum256([]byte(stringVar))
secretBytes := digest[:] // copy out bytes from strict [32]byte type to []byte used by everything else + iroh
ep, err := endpoint.New(WithSecretKey(secretBytes))

i wonder, should we create a util package for standalone useful snippets like the above? e.g:

func SecretBytesFromString(str string) []byte {
    // TODO (2026-11-09): securely clear all arrays to the extent possible
    digest := sha256.Sum256([]byte(str))
    return digest[:] // copy out bytes from strict [32]byte type to []byte used by everything else + iroh
}

what i normally do for this is actually a bit more specific, but i don't think it fits as an endpoint option: ```golang digest := sha256.Sum256([]byte(stringVar)) secretBytes := digest[:] // copy out bytes from strict [32]byte type to []byte used by everything else + iroh ep, err := endpoint.New(WithSecretKey(secretBytes)) ``` i wonder, should we create a util package for standalone useful snippets like the above? e.g: ```golang func SecretBytesFromString(str string) []byte { // TODO (2026-11-09): securely clear all arrays to the extent possible digest := sha256.Sum256([]byte(str)) return digest[:] // copy out bytes from strict [32]byte type to []byte used by everything else + iroh }

cblgh commented

2026-11-09 13:58:41 +00:00

ping @decentral1se with comment above, you were fast! XD

😆 1

decentral1se commented

2026-11-09 14:02:02 +00:00

Nice, yeh, whatever you want to upstream, go for it ⏫ I generally skirt around a vague utils package and just make tiny specific ones (e.g. a keys/keys.go for a keys.SecretBytesFromString API) but I've not got strong feelings about this!

Nice, yeh, whatever you want to upstream, go for it ⏫ I generally skirt around a vague `utils` package and just make tiny specific ones (e.g. a `keys/keys.go` for a `keys.SecretBytesFromString` API) but I've not got strong feelings about this!

cblgh commented

2026-11-09 14:06:19 +00:00

haha INTERESTING, i usually love a big chunky util and toss everything in there XD then refactor into e.g. your keys/keys.go if need be. case in point https://github.com/cblgh/cerca/blob/main/util/eout/eout.go)

imma go with my approach then since you have no super strong opinion 🐶

haha INTERESTING, i usually love a big chunky util and toss everything in there XD then refactor into e.g. your `keys/keys.go` if need be. case in point https://github.com/cblgh/cerca/blob/main/util/eout/eout.go) imma go with my approach then since you have no super strong opinion 🐶

😆 1

cblgh referenced this pull request

2026-11-09 14:08:15 +00:00

add(util.go): util method SecretBytesFromString #31

cblgh deleted branch OptionWithSecretKey

2026-11-09 14:14:05 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: decentral1se/iroh-go#30