Reverse subscription flow #2

2022-08-22T15:25:53Z

glyph commented

2022-08-22 15:25:53 +00:00

Previously we added a peer to the database before successfully completing an sbot follow and removed a peer from the database before successfully completing an unfollow.

This PR reverses the order:

When a subscription event is received via the UI:

Check the follow status
Follow if not following
Add peer to database

When an unsubscription event is received via the UI:

Check the follow status
Unfollow if following
Remove peer from database

Both follow_if_not_following() and unfollow_if_following() now return Result<(), String> so we can match on the result in src/routes.rs.

Previously we added a peer to the database before successfully completing an sbot follow and removed a peer from the database before successfully completing an unfollow. This PR reverses the order: When a subscription event is received via the UI: 1. Check the follow status 2. Follow if not following 3. Add peer to database When an unsubscription event is received via the UI: 1. Check the follow status 2. Unfollow if following 3. Remove peer from database Both `follow_if_not_following()` and `unfollow_if_following()` now return `Result<(), String>` so we can match on the result in `src/routes.rs`.

glyph added 2 commits 2022-08-22 15:25:53 +00:00

only add peer to db if following f5b91c70b5

move unfollow ahead of db removal of peer 459c2e13bd

glyph merged commit fcce647711 into main

2022-08-22 15:25:59 +00:00

glyph referenced this issue from a commit

2022-08-22 15:25:59 +00:00

Merge pull request 'Reverse subscription flow' (#2) from reverse_subscription_flow into main

glyph deleted branch reverse_subscription_flow

2022-08-22 15:25:59 +00:00

Sign in to join this conversation.