glyph/lykin
0
1
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Reverse subscription flow #2

Merged
glyph merged 2 commits from reverse_subscription_flow into main 2022-08-22 15:25:59 +00:00
Conversation 0 Commits 2 Files Changed 2 +74 -35
glyph commented 2022-08-22 15:25:53 +00:00
Owner
Copy Link

Previously we added a peer to the database before successfully completing an sbot follow and removed a peer from the database before successfully completing an unfollow.

This PR reverses the order:

When a subscription event is received via the UI:

  1. Check the follow status
  2. Follow if not following
  3. Add peer to database

When an unsubscription event is received via the UI:

  1. Check the follow status
  2. Unfollow if following
  3. Remove peer from database

Both follow_if_not_following() and unfollow_if_following() now return Result<(), String> so we can match on the result in src/routes.rs.

Previously we added a peer to the database before successfully completing an sbot follow and removed a peer from the database before successfully completing an unfollow. This PR reverses the order: When a subscription event is received via the UI: 1. Check the follow status 2. Follow if not following 3. Add peer to database When an unsubscription event is received via the UI: 1. Check the follow status 2. Unfollow if following 3. Remove peer from database Both `follow_if_not_following()` and `unfollow_if_following()` now return `Result<(), String>` so we can match on the result in `src/routes.rs`.
glyph added 2 commits 2022-08-22 15:25:53 +00:00
only add peer to db if following f5b91c70b5
move unfollow ahead of db removal of peer 459c2e13bd
glyph merged commit fcce647711 into main 2022-08-22 15:25:59 +00:00
glyph deleted branch reverse_subscription_flow 2022-08-22 15:25:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
glyph
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: glyph/lykin#2
No description provided.
Delete Branch "reverse_subscription_flow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?