Pass complete args struct to create_history_stream #56
Loading…
Reference in New Issue
No description provided.
Delete Branch "create_history_stream_opts"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Addresses #55
The relevant changes here are in
src/api/history_stream.rs
andexamples/streams.rs
.Previously we were simply passing the
ssb_id
intocreate_history_stream()
. This PR publically exports the CreateHistoryStreamIn type from kuska and renames it asCreateHistoryStream
.create_history_stream()
now expects a single argument in the form ofCreateHistoryStream
(this is similar to howSubsetQuery
is passed toget_subset_stream()
).This change allows a library user to set additional options for the
create_history_stream
call, including the minimum sequence number and a limit on returned messages.One question I have for @notplants: do you think
CreateHistoryStream
is consistent with the naming in the rest of golgi? I'm not entirely happy with it...perhapsHistoryStreamArgs
is better?Example usage: