Add get_profile_info function #13

notplants · 2022-01-12T20:30:52Z

notplants commented

2022-01-12 20:30:52 +00:00

This PR might be an unnecessary optimization, but its pretty cool that it works.

It adds a function get_profile_info, which returns a HashMap<String, String> of keys to values, for the about information needed for a profile (currently with keys 'name', 'description' and 'image').

Whats interesting about it is it does this with one stream. It creates an about stream for that user, and then iterates through the messages from most recent to least recent.

When it has found values for all the keys its search for, or it reaches the end of the stream, whichever happens first, it exits.

Instead of making a different get_subset call to go-sbot for each value needed, it makes one call, with just one iteration through that stream, and gets all the info it needs.

This PR might be an unnecessary optimization, but its pretty cool that it works. It adds a function get_profile_info, which returns a HashMap<String, String> of keys to values, for the about information needed for a profile (currently with keys 'name', 'description' and 'image'). Whats interesting about it is it does this with one stream. It creates an about stream for that user, and then iterates through the messages from most recent to least recent. When it has found values for all the keys its search for, or it reaches the end of the stream, whichever happens first, it exits. Instead of making a different get_subset call to go-sbot for each value needed, it makes one call, with just one iteration through that stream, and gets all the info it needs.

❤️ 1

notplants added 3 commits 2022-01-12 20:30:52 +00:00

ccc4a3371b Working on profile info

0055a1ed65 Merge branch 'about-stream2' into get_profile_info

8620e17810 Add get_profile_info which gets name, description and image

notplants requested review from glyph 2022-01-12 20:30:58 +00:00

glyph approved these changes 2022-01-13 14:59:01 +00:00

glyph left a comment

This is awesome. I appreciate the thorough code comments and the elegance of using a single stream.

Good to merge 🟢

This is awesome. I appreciate the thorough code comments and the elegance of using a single stream. Good to merge 🟢

notplants changed target branch from about-stream to main