Create sbot connection for every query #16

notplants · 2022-01-14T17:45:37Z

notplants commented

2022-01-14 17:45:37 +00:00

Unfortunately I don't understand the RPC reader code well enough (yet) to say exactly why this fixes the issue, but in the interest of pragmatism, this code does fix the issue.

The issue was:

calling publish after creating a stream creates the error Application error: SSB RPC failure: i/o

In this PR, I change publish to create its own sbot_connection, instead of using the sbot_connection created during sbot initialization.

Since we are now creating a new sbot_connection for each query, I removed sbot_connection as a field of Sbot.

This may have some overhead, but for all I know its negligible, and still seems to run instantly to me.

Someday would be curious to understand kuska better and exactly how it creates these connections, and why creating a new connection (via stream) seems to have interfered with the old previously created connection.

But maybe this is working for now.

Unfortunately I don't understand the RPC reader code well enough (yet) to say exactly why this fixes the issue, but in the interest of pragmatism, this code does fix the issue. The issue was: - calling publish after creating a stream creates the error `Application error: SSB RPC failure: i/o` In this PR, I change publish to create its own sbot_connection, instead of using the sbot_connection created during sbot initialization. Since we are now creating a new sbot_connection for each query, I removed sbot_connection as a field of Sbot. This may have some overhead, but for all I know its negligible, and still seems to run instantly to me. Someday would be curious to understand kuska better and exactly how it creates these connections, and why creating a new connection (via stream) seems to have interfered with the old previously created connection. But maybe this is working for now.

notplants added 3 commits 2022-01-14 17:45:38 +00:00

887d635683 Add get_about_info function

9027ebfe84 Create new sbot connection for each query

6fd27827a0 Fix example

notplants changed target branch from main to get-about-info

2022-01-14 17:46:05 +00:00

glyph closed this pull request

2022-01-18 09:11:44 +00:00