Add publish_post method #3

notplants · 2021-12-22T19:50:32Z

notplants commented

2021-12-22 19:50:32 +00:00

Just getting warmed up here. This PR adds a wrapper method to publish_post which calls publish.

I also fixed a clippy warning in the init method, which suggests an alternate rust syntax for setting the value of a variable via an if/else clause.

Just getting warmed up here. This PR adds a wrapper method to publish_post which calls publish. I also fixed a clippy warning in the init method, which suggests an alternate rust syntax for setting the value of a variable via an if/else clause.

notplants added 2 commits 2021-12-22 19:50:43 +00:00

5b72de0b2b Add publish_post method

4701c72f6a Fix clippy warning

notplants requested review from glyph 2021-12-22 19:50:50 +00:00

glyph requested changes 2021-12-23 10:02:10 +00:00

glyph left a comment

Nice, cool to see this taking shape. I've requested some changes in the review comments.

I also suggest changing the init method name to connect; that should help to clarify that we are connecting to an sbot instance and not start / initialising one.

Nice, cool to see this taking shape. I've requested some changes in the review comments. I also suggest changing the `init` method name to `connect`; that should help to clarify that we are connecting to an sbot instance and not start / initialising one.

src/lib.rs Outdated

						
				@ -24,6 +24,8 @@

				//! }

				//! ```

				extern crate kuska_ssb;

glyph commented

2021-12-23 09:57:15 +00:00

The need to write extern crate was removed in Rust 2018. Rather write use kuska_ssb;.

The need to write `extern crate` was removed in Rust 2018. Rather write `use kuska_ssb;`.

notplants commented

2021-12-24 15:35:04 +00:00

oops hmm I'm not sure how or why this got into there, thanks

notplants marked this conversation as resolved

src/sbot.rs

						
				@ -43,2 +42,2 @@

				        if ip_port.is_none() {

				            address = "127.0.0.1:8008".to_string();

				        let address = if ip_port.is_none() {

glyph commented

2021-12-23 09:58:13 +00:00

Ahh this is so much nicer! It always pained me to write let address; but I didn't know an alternative approach.

Ahh this is _so_ much nicer! It always pained me to write `let address;` but I didn't know an alternative approach.

notplants marked this conversation as resolved

src/sbot.rs Outdated

						
				@ -116,0 +116,4 @@

				    ///

				    /// # Arguments

				    ///

				    /// * `text` - A &str which represents the text to be published in the post

glyph commented

2021-12-23 10:00:17 +00:00

Let's replace "A &str..." with "A reference to a string slice...".

👍 1

notplants marked this conversation as resolved

notplants added 2 commits 2021-12-24 15:34:24 +00:00

c12ea2c8c1 Working on publish_description

dbd880c963 Response to code review

notplants commented

2021-12-24 15:36:51 +00:00

Incorporated the code review suggestions,
and due to accidental git issues, also added the publish_description method to this PR.

but based on your comment on that other PR, it sounds like we could merge this in (since the null fields is not a breaking change, just something that would be nice to fix, and could be fixed in Kuska).

Incorporated the code review suggestions, and due to accidental git issues, also added the publish_description method to this PR. but based on your comment on that other PR, it sounds like we could merge this in (since the null fields is not a breaking change, just something that would be nice to fix, and could be fixed in Kuska).

glyph approved these changes 2021-12-24 15:55:54 +00:00

glyph left a comment

Noice 🟢