golgi-ssb/golgi
4
6
Fork 0
Code Issues 11 Pull Requests 1 Projects 1 Releases Wiki Activity

Remove lockfile from repo #48

Merged
glyph merged 3 commits from remove_lockfile into main 2022-07-01 07:41:30 +00:00
Conversation 0 Commits 3 Files Changed 3 +2 -1115
glyph commented 2022-06-29 15:06:30 +00:00
Owner
Copy Link

I recently learned that Rust libraries should not commit Cargo.lock to version control repos. There are some explanatory details in the FAQ of The Cargo Book.

This PR removes Cargo.lock from the repo, adds it to .gitignore and bumps the patch version in Cargo.toml.

I recently learned that Rust libraries should not commit `Cargo.lock` to version control repos. There are some explanatory details in the [FAQ of The Cargo Book](https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries). This PR removes `Cargo.lock` from the repo, adds it to `.gitignore` and bumps the patch version in `Cargo.toml`.
👍 1
glyph added 3 commits 2022-06-29 15:06:30 +00:00
remove lockfile 175add2c72
bump patch version e03729907f
add lockfile to git ignore list 89a98dd6ab
glyph requested review from notplants 2022-06-29 15:06:38 +00:00
glyph merged commit 1c44f0e56a into main 2022-07-01 07:41:30 +00:00
glyph deleted branch remove_lockfile 2022-07-01 07:41:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
notplants
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: golgi-ssb/golgi#48
No description provided.
Delete Branch "remove_lockfile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?