golgi-ssb
/
golgi
4
5
Fork 0
Code Issues 11 Pull Requests 1 Projects 1 Releases Wiki Activity

Introduce names RPC methods #53

Merged
glyph merged 8 commits from names_rpc into main 2022-08-09 10:14:03 +00:00
Conversation 0 Commits 8 Files Changed 1 +98 -12
glyph commented 2022-08-08 07:30:49 +00:00
Owner
Copy Link

This PR adds support for two RPC methods which have just been added to kuska (https://github.com/Kuska-ssb/ssb/pull/27):

get_image
get_signifier

The get_signifier method is essentially just get_name. I have created a new get_signifier method and am calling it from get_name; this was following a suggestion by @notplants. I like that it offers us the ability to change the get_name method in the future without having to break the API.

All methods which retrieve name and / or image data now use these new methods under the hood. I anticipate a significant performance improvement.

This PR adds support for two RPC methods which have just been added to kuska (https://github.com/Kuska-ssb/ssb/pull/27): `get_image` `get_signifier` The `get_signifier` method is essentially just `get_name`. I have created a new `get_signifier` method and am calling it from `get_name`; this was following a suggestion by @notplants. I like that it offers us the ability to change the `get_name` method in the future without having to break the API. All methods which retrieve name and / or image data now use these new methods under the hood. I anticipate a significant performance improvement.
glyph added the
enhancement
 label 2022-08-08 07:30:49 +00:00
glyph added 7 commits 2022-08-08 07:30:50 +00:00
glyph requested review from notplants 2022-08-08 08:53:16 +00:00
glyph added 1 commit 2022-08-09 10:07:25 +00:00
glyph removed review request for notplants 2022-08-09 10:13:56 +00:00
glyph merged commit 457dda6d2d into main 2022-08-09 10:14:03 +00:00
glyph deleted branch names_rpc 2022-08-09 10:14:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: golgi-ssb/golgi#53
No description provided.
Delete Branch "names_rpc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?