Add get_latest_about_message #8

Merged

notplants merged 7 commits from get-latest-about-message2 into main 2021-12-31 15:11:39 +00:00

Conversation 1 Commits 7 Files Changed 4

+131 -11

notplants commented 2021-12-30 18:38:07 +00:00

Owner

Copy Link

Copy Source

This PR is a duplicate of #7 (which got borked due to an error in the gitea flow.

This PR has incorporated all the code review changes from before and should be ready for merge now.

This PR is a duplicate of https://git.coopcloud.tech/golgi-ssb/golgi/pulls/7 (which got borked due to an error in the gitea flow. This PR has incorporated all the code review changes from before and should be ready for merge now.

notplants added 7 commits 2021-12-30 18:38:08 +00:00

Working on profile 0aeed5578e

Get description 696701e855

Add function for get_latest_about_message be19fcbfc4

Replace verbose get_description with more concise version 961f817a8b

Merge branch 'kvt-pr' into profile f764e7dfed

Revert "Remove ContentTypeDecode error variant" ... 65d64bbacf

This reverts commit 028e3a47b5.

Response to code review db948f1f67

notplants requested review from glyph 2021-12-30 18:38:38 +00:00

glyph approved these changes 2021-12-30 18:54:33 +00:00

glyph left a comment

Owner

Copy Link

Copy Source

I was curious about the closed pull request but the issue with the deleted branch makes sense to me. Thanks for opening another PR.

This all looks great to me 🟢

I was curious about the closed pull request but the issue with the deleted branch makes sense to me. Thanks for opening another PR. This all looks great to me 🟢

notplants merged commit c06b03ad54 into main 2021-12-31 15:11:39 +00:00

notplants deleted branch get-latest-about-message2 2021-12-31 15:11:39 +00:00

notplants referenced this issue from a commit 2021-12-31 15:11:40 +00:00

Merge pull request 'Add get_latest_about_message' (#8) from get-latest-about-message2 into main

Sign in to join this conversation.

Reviewers

No Reviewers

glyph

Labels

Clear labels

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

cblgh glyph (glyph) notplants

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: golgi-ssb/golgi#8