linnealovespie/aemp-seattle
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

WIP: draft corporate name improvements. #16

Draft
jessib wants to merge 4 commits from biz-name-jb-8 into main
pull from: biz-name-jb-8
merge into: linnealovespie:main
Conversation 4 Commits 4 Files Changed 1 +41 -22
jessib commented 2025-12-30 04:27:23 +00:00
Collaborator
Copy Link

#8

#8
jessib added 1 commit 2025-12-30 04:27:23 +00:00
draft corporate name improvements. 672c474fb8
linnealovespie commented 2026-01-06 01:18:51 +00:00
Owner
Copy Link

The code itself looks good! And especially handy for if/when we get more matches, we can just update the dict or even put it into a separate file. Makes me want to add a task for making a bare bones way to do testing.

The code itself looks good! And especially handy for if/when we get more matches, we can just update the dict or even put it into a separate file. Makes me want to add a task for making a bare bones way to do testing.
linnealovespie commented 2026-01-06 01:23:04 +00:00
Owner
Copy Link

For now if you want to test the code by hand, if you run gre-llc.py in the same folder you should be able to test the results. The desired result would be that any pair of (name from the KC assessor data, name from the Sec of State data) that are matched when standardized, shows up in the "exact_match" list. LMK if that doesn't make sense, either way I should probably write out a better test script.

For now if you want to test the code by hand, if you run `gre-llc.py` in the same folder you should be able to test the results. The desired result would be that any pair of (name from the KC assessor data, name from the Sec of State data) that are matched when standardized, shows up in the "exact_match" list. LMK if that doesn't make sense, either way I should probably write out a better test script.
jessib added 1 commit 2026-01-06 05:19:48 +00:00
typo 900c051800
jessib commented 2026-01-06 22:55:57 +00:00
Author
Collaborator
Copy Link

@linnealovespie : I am running gre-llc.py and the call at

processors/corp_owners.py Line 85 in 8f250bbe4c
r = requests.post(search_for_business_url, get_business_search_payload(business_name, 100, page_num))
is returning a status of 400 but the text "System verification in progress, please wait." (I also see that if I go to https://ccfs-api.prod.sos.wa.gov/api/BusinessSearch/GetBusinessSearchList in a browser or with curl.) Before I dig into this more, I wanted to ask if there is a setup piece or something else I'm missing. I also could write tests or other way to look at my changes, but thought I'd ask first.

@linnealovespie : I am running `gre-llc.py` and the call at https://git.coopcloud.tech/linnealovespie/aemp-seattle/src/commit/8f250bbe4c3f2dba2c47b5bf7589d07283b34c2c/processors/corp_owners.py#L85 is returning a status of 400 but the text "System verification in progress, please wait." (I also see that if I go to https://ccfs-api.prod.sos.wa.gov/api/BusinessSearch/GetBusinessSearchList in a browser or with curl.) Before I dig into this more, I wanted to ask if there is a setup piece or something else I'm missing. I also could write tests or other way to look at my changes, but thought I'd ask first.
jessib added 1 commit 2026-01-07 00:35:08 +00:00
escape regexp pattern 2a97e1ccb7
linnealovespie commented 2026-01-20 23:22:03 +00:00
Owner
Copy Link

Hmm no that's not expected behavior. Sometimes CCFS just moves around API access. However I dug around in the code for the connection string to the database where we have a data dump of the CCFS database, and it would be better to just use our own connection string instead.

I can work on refactoring to query our own copy of CCFS data ourselves now, or you can do it if you get to it first and I can give you the db connection string.

Hmm no that's not expected behavior. Sometimes CCFS just moves around API access. However I dug around in the code for the connection string to the database where we have a data dump of the CCFS database, and it would be better to just use our own connection string instead. I can work on refactoring to query our own copy of CCFS data ourselves now, or you can do it if you get to it first and I can give you the db connection string.
jessib added 1 commit 2026-01-22 03:01:37 +00:00
Merge branch 'main' into biz-name-jb-8 c4c766380f 
# Conflicts:
#	processors/corp_owners.py
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin biz-name-jb-8:biz-name-jb-8
git checkout biz-name-jb-8
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ammaratef45 Hedgewig1 jessib Proven-Paradox rv32ima linnealovespie
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: linnealovespie/aemp-seattle#16
No description provided.
Delete Branch "biz-name-jb-8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?